docs: document disadvantages of platform-specific maximized detection
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -16,6 +16,28 @@ saving. Fyne v2.x has no API for this; it needs per-OS native calls:
|
||||
`IsZoomed` (Windows), `_NET_WM_STATE` (X11/Linux), `NSWindow.isZoomed`
|
||||
(macOS). Unfreeze once that detection is in place.
|
||||
|
||||
**Disadvantages of a platform-specific approach:**
|
||||
|
||||
- *Three separate implementations.* Windows, macOS, and Linux each need their
|
||||
own file guarded by a build tag. Each adds CGO bindings or raw syscall
|
||||
wrappers that must be kept in sync as OS APIs evolve.
|
||||
- *Linux is not one target.* X11 and Wayland have completely different window
|
||||
state models. `_NET_WM_STATE` is X11-only; under Wayland the compositor
|
||||
controls window decorations and there is no stable client-side API to query
|
||||
the maximized state. A single `linux` build tag cannot cover both correctly.
|
||||
- *Native window handle is not exposed.* Fyne does not surface the underlying
|
||||
`HWND` / `NSWindow` / `XID` through its public API. Obtaining it requires
|
||||
either enumerating OS-level windows by PID (fragile, finds wrong windows when
|
||||
dialogs are open) or reaching into Fyne/GLFW internals (breaks on Fyne
|
||||
upgrades).
|
||||
- *Thread-safety constraints.* Win32 and GLFW both require their calls to be
|
||||
made from the OS main thread. Tray-menu callbacks run on a separate goroutine,
|
||||
so any native call must be marshalled back to the main thread, adding
|
||||
synchronisation complexity.
|
||||
- *Test coverage gap.* Maximized-state detection cannot be exercised by Fyne's
|
||||
headless test driver; it requires a real display and manual or screen-capture
|
||||
automation per platform.
|
||||
|
||||
### History tab — column filters (Trigger / Job / State)
|
||||
|
||||
Add dropdown filters above the History table so the user can narrow rows by
|
||||
|
||||
Reference in New Issue
Block a user