From 8b05d0cfd1c4e9ecc40e23c5c7a5b995027ca297 Mon Sep 17 00:00:00 2001 From: mixeme Date: Tue, 23 Jun 2026 22:14:28 +0300 Subject: [PATCH] P5: mark Phase 5 icons done; reflect size-appropriate approach Tick P5.1 and P5.2 in the completion checklist and reword the P5.2 task line to match what shipped in f533739: size-appropriate, transparent per-platform icons (tray uses the small icon; Windows window/taskbar draws from the multi-size gosentry.ico via the GLFW_ICON resource; Linux titlebar uses IconSmall) rather than "window icon stays large". Co-Authored-By: Claude Opus 4.8 --- docs/PRE-RELEASE-TASKS.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/PRE-RELEASE-TASKS.md b/docs/PRE-RELEASE-TASKS.md index 8a696e5..81a59e1 100644 --- a/docs/PRE-RELEASE-TASKS.md +++ b/docs/PRE-RELEASE-TASKS.md @@ -51,7 +51,7 @@ These land together because both edit `domain/job.go` and `storage/store.go`. | Task | Description | Model | Thinking | |------|-------------|-------|----------| | P5.1 | `assets/assets.go`: embed `gosentry-icon-16x16.png`; add `IconSmall()`; keep `Icon()`/`IconBytes()` (large). | haiku | low | -| P5.2 | `ui/tray.go`: `desk.SetSystemTrayIcon(assets.IconSmall())`; confirm window/app icon stays large in `run.go`. Verify `gosentry.ico` carries both sizes. | sonnet | low | +| P5.2 | Size-appropriate, transparent icons per platform. `ui/tray.go`: tray uses the small icon (Windows `IconSmallICO()` 16×16 `.ico`; Linux big PNG). `run.go`: Windows window/taskbar draws from multi-size `gosentry.ico` via the `GLFW_ICON` resource (hand-tuned 16 titlebar + large taskbar, so `a.SetIcon` is skipped); Linux titlebar uses `IconSmall()`. Verify `gosentry.ico` carries 16/32/48/256. | sonnet | low | ## Phase 6 — Fyne 2.7 upgrade + tray click (§6) @@ -105,8 +105,8 @@ These land together because both edit `domain/job.go` and `storage/store.go`. - [x] P4.2 — Command Browse button ### Phase 5 — Icons -- [ ] P5.1 — Embed small icon + `IconSmall()` -- [ ] P5.2 — Tray uses small icon; verify `.ico` +- [x] P5.1 — Embed small icon + `IconSmall()` +- [x] P5.2 — Size-appropriate per-platform icons (tray small; window via `.ico`/`IconSmall`); verify `.ico` ### Phase 6 — Fyne 2.7 upgrade + tray click - [ ] P6.1 — Bump Fyne to 2.7.x; rebuild