docs: track the oversized files as a roadmap item
The ~250-line guideline is currently broken by six source files, not the two the last commit named from the ui section it was editing: operations.go at 490 is the worst, and both files that were already split once are back over. Fixing them belongs in the next whole-project review rather than in one-off commits. REVIEW.md item 2 already asks for exactly this sweep, and doing all six together is what keeps the seams consistent — six separate passes would settle the same question six ways. A split also reads as pure movement while it is the easiest change in which to silently drop a function, which is an argument for one careful pass rather than several hurried ones. The item records the seams that are visible today so the pass does not start cold: operations.go splits along the three consecutive blocks it already has, history_view.go's column measurement is pure and separable, and jobs_view.go is the hard one because almost all of it is a single constructor that has to be broken up rather than moved. The three files barely over the line are flagged as re-measure-first, not split-on-sight. ARCHITECTURE now points at that item instead of describing the overage in passing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -204,9 +204,10 @@ the moment the window opens.
|
||||
|
||||
### `jobs_view.go` file structure
|
||||
|
||||
The size guideline for a file in this project is ~250 lines. `src/ui/jobs_view.go`
|
||||
is split across three files along these seams; the view file itself has grown
|
||||
back over the guideline since, and is the next candidate if it grows further:
|
||||
The size guideline for a file in this project is ~250 lines.
|
||||
`src/ui/jobs_view.go` is split across three files along these seams; the view
|
||||
file itself has grown back over the guideline since — see the split item in
|
||||
[ROADMAP.md](ROADMAP.md), which tracks every file currently over it:
|
||||
|
||||
| File | Contents |
|
||||
|------|----------|
|
||||
@@ -217,8 +218,7 @@ back over the guideline since, and is the next candidate if it grows further:
|
||||
### `settings_view.go` file structure
|
||||
|
||||
`src/ui/settings_view.go` is split across three files the same way, once its
|
||||
own size passed the guideline. `src/ui/history_view.go` is over it too and has
|
||||
not been split:
|
||||
own size passed the guideline:
|
||||
|
||||
| File | Contents |
|
||||
|------|----------|
|
||||
|
||||
Reference in New Issue
Block a user