3907ab3c18
Tests touching SysProcAttr.HideWindow/CmdLine and windowsShellCommandLine are guarded by //go:build windows; runner_test.go drops the winproc import. Linux cross-compile and Windows test run both clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
324 lines
8.9 KiB
Go
324 lines
8.9 KiB
Go
package runner
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"gitea.mixdep.ru/mix/gosentry/src/domain"
|
|
)
|
|
|
|
func echoCommand(message string) string {
|
|
if runtime.GOOS == "windows" {
|
|
return "echo " + message
|
|
}
|
|
return "echo '" + strings.ReplaceAll(message, "'", "'\\''") + "'"
|
|
}
|
|
|
|
func TestRunJobLogFileAllHeaders(t *testing.T) {
|
|
logsDir := t.TempDir()
|
|
job := domain.Job{
|
|
ID: 99,
|
|
Name: "Log Header Test",
|
|
Command: echoCommand("header test output"),
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Schedule", logsDir)
|
|
if record.LogFile == "" {
|
|
t.Fatal("expected log file to be written")
|
|
}
|
|
|
|
data, err := os.ReadFile(record.LogFile)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
content := string(data)
|
|
|
|
for _, want := range []string{
|
|
"job_id: 99",
|
|
"job_name: Log Header Test",
|
|
"trigger: Schedule",
|
|
"state: OK",
|
|
"detail: ",
|
|
"command: " + job.Command,
|
|
"arguments: <empty>",
|
|
"start_only: false",
|
|
"stdout:",
|
|
"stderr:",
|
|
} {
|
|
if !strings.Contains(content, want) {
|
|
t.Errorf("log file missing %q:\n%s", want, content)
|
|
}
|
|
}
|
|
|
|
// The time header must use the documented format.
|
|
for _, line := range strings.Split(content, "\n") {
|
|
if strings.HasPrefix(line, "time: ") {
|
|
ts := strings.TrimPrefix(line, "time: ")
|
|
if _, err := time.Parse("2006-01-02 15:04:05", ts); err != nil {
|
|
t.Errorf("time header %q does not match format 2006-01-02 15:04:05: %v", ts, err)
|
|
}
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRunJobRecordFields(t *testing.T) {
|
|
job := domain.Job{
|
|
ID: 55,
|
|
Name: "Record Fields Test",
|
|
Command: echoCommand("record field check"),
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Schedule", t.TempDir())
|
|
|
|
if record.JobID != job.ID {
|
|
t.Errorf("JobID: got %d, want %d", record.JobID, job.ID)
|
|
}
|
|
if record.JobName != job.Name {
|
|
t.Errorf("JobName: got %q, want %q", record.JobName, job.Name)
|
|
}
|
|
if record.Trigger != "Schedule" {
|
|
t.Errorf("Trigger: got %q, want 'Schedule'", record.Trigger)
|
|
}
|
|
if record.State != "OK" {
|
|
t.Errorf("State: got %q, want 'OK' (detail: %q)", record.State, record.Detail)
|
|
}
|
|
if record.LogFile == "" {
|
|
t.Error("LogFile should be a non-empty path")
|
|
}
|
|
if _, err := time.Parse("2006-01-02 15:04:05", record.Time); err != nil {
|
|
t.Errorf("Time format wrong, got %q: %v", record.Time, err)
|
|
}
|
|
if !strings.Contains(record.Output, "stdout:") {
|
|
t.Errorf("Output missing 'stdout:', got:\n%s", record.Output)
|
|
}
|
|
if !strings.Contains(record.Output, "stderr:") {
|
|
t.Errorf("Output missing 'stderr:', got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|
|
func TestFormatOutput(t *testing.T) {
|
|
got := formatOutput("hello world", "some error")
|
|
want := "stdout:\nhello world\n\nstderr:\nsome error"
|
|
if got != want {
|
|
t.Errorf("formatOutput:\ngot: %q\nwant: %q", got, want)
|
|
}
|
|
}
|
|
|
|
func TestFormatOutputEmptyStreams(t *testing.T) {
|
|
got := formatOutput("", "")
|
|
if !strings.Contains(got, "stdout:\n<empty>") {
|
|
t.Errorf("empty stdout should show <empty>, got:\n%s", got)
|
|
}
|
|
if !strings.Contains(got, "stderr:\n<empty>") {
|
|
t.Errorf("empty stderr should show <empty>, got:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestLogArguments(t *testing.T) {
|
|
cases := []struct{ input, want string }{
|
|
{"", "<empty>"},
|
|
{" ", "<empty>"},
|
|
{"--flag", "--flag"},
|
|
{"--flag\r\n--value", "--flag\n--value"},
|
|
{"--flag\n--value", "--flag\n--value"},
|
|
}
|
|
for _, tc := range cases {
|
|
if got := logArguments(tc.input); got != tc.want {
|
|
t.Errorf("logArguments(%q) = %q, want %q", tc.input, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSanitizeFileName(t *testing.T) {
|
|
cases := []struct{ input, want string }{
|
|
{"Hello Test", "Hello_Test"},
|
|
{"job-1_ok", "job-1_ok"},
|
|
{"!!!", "job"},
|
|
{"", "job"},
|
|
{"A/B:C", "A_B_C"},
|
|
}
|
|
for _, tc := range cases {
|
|
if got := sanitizeFileName(tc.input); got != tc.want {
|
|
t.Errorf("sanitizeFileName(%q) = %q, want %q", tc.input, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRunJobWritesLogFile(t *testing.T) {
|
|
logsDir := t.TempDir()
|
|
job := domain.Job{
|
|
ID: 42,
|
|
Name: "Hello Test",
|
|
Command: echoCommand("hello from test"),
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", logsDir)
|
|
if record.LogFile == "" {
|
|
t.Fatal("expected log file path")
|
|
}
|
|
if filepath.Dir(record.LogFile) != logsDir {
|
|
t.Fatalf("expected log in %q, got %q", logsDir, record.LogFile)
|
|
}
|
|
if !strings.Contains(filepath.Base(record.LogFile), "Hello_Test") {
|
|
t.Fatalf("expected job name in log filename, got %q", record.LogFile)
|
|
}
|
|
|
|
data, err := os.ReadFile(record.LogFile)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
content := string(data)
|
|
for _, want := range []string{"trigger: Manual", "job_name: Hello Test", "hello from test"} {
|
|
if !strings.Contains(content, want) {
|
|
t.Fatalf("expected log content to contain %q, got:\n%s", want, content)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRunJobRunsQuotedWindowsExecutable(t *testing.T) {
|
|
if runtime.GOOS != "windows" {
|
|
t.Skip("Windows cmd.exe quoting only")
|
|
}
|
|
|
|
logsDir := t.TempDir()
|
|
job := domain.Job{
|
|
ID: 43,
|
|
Name: "Quoted Windows Command",
|
|
Command: `"C:\Windows\System32\cmd.exe" /C echo quoted command ok`,
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", logsDir)
|
|
if record.State != "OK" {
|
|
t.Fatalf("expected quoted command to run, got state %q detail %q output:\n%s", record.State, record.Detail, record.Output)
|
|
}
|
|
if !strings.Contains(record.Output, "quoted command ok") {
|
|
t.Fatalf("expected command output, got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|
|
func TestRunJobRunsUnquotedWindowsProgramPathWithSpaces(t *testing.T) {
|
|
if runtime.GOOS != "windows" {
|
|
t.Skip("Windows cmd.exe quoting only")
|
|
}
|
|
|
|
logsDir := t.TempDir()
|
|
scriptDir := filepath.Join(t.TempDir(), "Program Files", "GoSentry Test")
|
|
if err := os.MkdirAll(scriptDir, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
scriptPath := filepath.Join(scriptDir, "hello.cmd")
|
|
if err := os.WriteFile(scriptPath, []byte("@echo off\r\necho unquoted command ok\r\n"), 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
job := domain.Job{
|
|
ID: 44,
|
|
Name: "Unquoted Windows Command",
|
|
Command: scriptPath,
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", logsDir)
|
|
if record.State != "OK" {
|
|
t.Fatalf("expected unquoted command path to run, got state %q detail %q output:\n%s", record.State, record.Detail, record.Output)
|
|
}
|
|
if !strings.Contains(record.Output, "unquoted command ok") {
|
|
t.Fatalf("expected command output, got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|
|
func TestRunJobRunsWindowsCommandWithSeparateArguments(t *testing.T) {
|
|
if runtime.GOOS != "windows" {
|
|
t.Skip("Windows command arguments only")
|
|
}
|
|
|
|
logsDir := t.TempDir()
|
|
job := domain.Job{
|
|
ID: 45,
|
|
Name: "Separate Arguments",
|
|
Command: `C:\Windows\System32\cmd.exe`,
|
|
Arguments: "/C\necho separate arguments ok",
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", logsDir)
|
|
if record.State != "OK" {
|
|
t.Fatalf("expected separate arguments to run, got state %q detail %q output:\n%s", record.State, record.Detail, record.Output)
|
|
}
|
|
if !strings.Contains(record.Output, "separate arguments ok") {
|
|
t.Fatalf("expected command output, got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|
|
func TestRunJobFailsOnNonZeroExitCode(t *testing.T) {
|
|
command := `sh -c 'exit 1'`
|
|
if runtime.GOOS == "windows" {
|
|
command = `C:\Windows\System32\cmd.exe`
|
|
}
|
|
job := domain.Job{
|
|
ID: 47,
|
|
Name: "Non-zero Exit Code",
|
|
Command: command,
|
|
}
|
|
if runtime.GOOS == "windows" {
|
|
job.Arguments = "/C\nexit /b 1"
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", t.TempDir())
|
|
if record.State != "Failed" {
|
|
t.Fatalf("expected non-zero exit code to fail, got state %q detail %q", record.State, record.Detail)
|
|
}
|
|
if !strings.Contains(record.Detail, "exit code 1") {
|
|
t.Fatalf("expected exit code detail, got %q", record.Detail)
|
|
}
|
|
}
|
|
|
|
func TestRunJobStartOnlyDoesNotWaitForExitCode(t *testing.T) {
|
|
command := "sh"
|
|
arguments := "-c\nexit 7"
|
|
if runtime.GOOS == "windows" {
|
|
command = `C:\Windows\System32\cmd.exe`
|
|
arguments = "/C\nexit /b 7"
|
|
}
|
|
job := domain.Job{
|
|
ID: 48,
|
|
Name: "Start Only",
|
|
Command: command,
|
|
Arguments: arguments,
|
|
StartOnly: true,
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", t.TempDir())
|
|
if record.State != "OK" {
|
|
t.Fatalf("expected start-only job to be OK after launch, got state %q detail %q", record.State, record.Detail)
|
|
}
|
|
if !strings.Contains(record.Detail, "not waiting for process exit") {
|
|
t.Fatalf("expected start-only detail, got %q", record.Detail)
|
|
}
|
|
if !strings.Contains(record.Output, "start_only:\ntrue") {
|
|
t.Fatalf("expected start-only output, got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|
|
func TestRunJobStartOnlyReportsStartFailure(t *testing.T) {
|
|
job := domain.Job{
|
|
ID: 49,
|
|
Name: "Missing Start Only",
|
|
Command: "definitely-missing-gosentry-command",
|
|
Arguments: "--force-direct-start",
|
|
StartOnly: true,
|
|
}
|
|
|
|
record := RunJob(context.Background(), &job, "Manual", t.TempDir())
|
|
if record.State != "Failed" {
|
|
t.Fatalf("expected missing start-only command to fail, got state %q detail %q", record.State, record.Detail)
|
|
}
|
|
if !strings.Contains(record.Output, "Process did not start") {
|
|
t.Fatalf("expected start failure output, got:\n%s", record.Output)
|
|
}
|
|
}
|
|
|