fix(panel): code-review P6 optional cleanup
test / test (push) Has been cancelled

Close the remaining low-risk items from the full-tree review: rename the settings handler, query assigned domains in SQL, bound the login limiter map, collapse panel.js show/hide helpers, and soften DMARC copy that promised a future in-panel receiver.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-08-14 14:48:43 +03:00
parent 97a0c7e508
commit 02afa0fa80
16 changed files with 260 additions and 209 deletions
+1 -1
View File
@@ -196,7 +196,7 @@ holds the cookie works after process restart, redeploy, or full backup restore.
(`renewThreshold` in [internal/web/auth/session.go](../internal/web/auth/session.go)).
- **Password change** — all other sessions are deleted; the current session stays
active ([internal/store/sessions.go](../internal/store/sessions.go),
[handlers_account.go](../internal/web/handlers/handlers_account.go)).
[handlers_settings.go](../internal/web/handlers/handlers_settings.go)).
Restoring an **older** backup also restores session rows: a session invalidated
after that backup was taken can become valid again if the browser still has the
+8 -8
View File
@@ -614,14 +614,14 @@ for SPDX consistency and deleting the done logrotate plan.
**Model: Sonnet** unless noted.
- [ ] Use `auth.RequireGlobal` or delete it (**Haiku** if delete).
- [ ] Rename `handlers_account.go` / `HandleAccount` to settings (**Haiku**).
- [ ] `ListDomainsForUser` instead of load-all-and-filter.
- [ ] Cap or periodically sweep the login limiter map (**Opus**, small).
- [ ] Collapse `panel.js` field-sync helpers.
- [ ] Soften or keep DMARC “future release” UI copy (product call).
- [ ] Optional startup `Resync` after restore (**Opus**). Only if P2s comment
fix is judged insufficient.
- [x] Use `auth.RequireGlobal` or delete it (**Haiku** if delete). Deleted.
- [x] Rename `handlers_account.go` / `HandleAccount` to settings (**Haiku**).
- [x] `ListDomainsForUser` instead of load-all-and-filter.
- [x] Cap or periodically sweep the login limiter map (**Opus**, small).
- [x] Collapse `panel.js` field-sync helpers.
- [x] Soften or keep DMARC “future release” UI copy (product call). Softened.
- [ ] Optional startup `Resync` after restore (**Opus**). Dropped — P2 backup
comment fix is sufficient.
### P7 — Security review of the P0P1 diff