audit 4: sign-in timing and sessions, server timeouts, polling that recovers
test / test (push) Canceled after 0s
test / test (push) Canceled after 0s
Steps 1-3 of stage 4, tested together (their docs share files).
Step 1 (M8, L15, L16): an unknown name pays a bcrypt comparison at the
panel's work factor too (noSuchUserHash, made once) -
TestLoginTakesAsLongForAnUnknownName holds the medians within a factor of
two; the Account form's current-password check has its own limiter, per
user (AllowPasswordChange); a sign-in destroys every session the request
presents before it issues its own.
Step 2 (L14): newHTTPServer - ReadTimeout 30 s, WriteTimeout 60 s,
IdleTimeout 2 min beside ReadHeaderTimeout; the full backup moves its write
deadline to two hours through http.ResponseController (e2e: the log shows
no failure to move it).
Step 3 (M11), read in htmx 2.0.4's source (dev/upstream/htmx-2.0.4, the npm
build byte-equal to the shipped htmx.min.js): the poll passes source: box,
and the next refresh is scheduled from htmx:afterRequest, which htmx fires
on load, error, abort and timeout, and after a swap on the nearest parent
left (the box found by detail.target's id); failures in a row double the
wait to 60 s. RequireAuth answers htmx with 401 + HX-Redirect: /login,
which htmx follows before it looks at the status. testdata/poll_test.js
runs panel.js in node against a stand-in DOM and clock (TestPanelJS; skipped
without node, which the test server lacks - run here, and it fails on the
old panel.js).
Also measured: the stage-3 e2e regression for H1 fails as it should on HEAD
with the old entrypoint ("check data/postfix/e2e_extra_map: permission
denied", the panel restarting).
Tested on the test server: go vet + go test of 25 packages, make e2e (all
pass, 639 s) on this tree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,22 @@
|
||||
package view
|
||||
|
||||
import (
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
// The refreshes of the monitoring boxes survive a failure and back off,
|
||||
// checked by running panel.js in node against a stand-in for the DOM and
|
||||
// htmx (testdata/poll_test.js; audit 2026-10-12, M11). Skipped where node is
|
||||
// not installed - the test server's Go has none; the workstation runs it.
|
||||
func TestPanelJSPolling(t *testing.T) {
|
||||
node, err := exec.LookPath("node")
|
||||
if err != nil {
|
||||
t.Skip("node is not installed")
|
||||
}
|
||||
out, err := exec.Command(node, filepath.Join("testdata", "poll_test.js"), filepath.Join("static", "panel.js")).CombinedOutput()
|
||||
if err != nil {
|
||||
t.Fatalf("panel.js polling: %v\n%s", err, out)
|
||||
}
|
||||
}
|
||||
@@ -221,6 +221,12 @@
|
||||
// trigger is kept without its filter, so it would fire on every tick.
|
||||
var pollActiveMs = 5000;
|
||||
var pollIdleMs = 30000;
|
||||
// A refresh that failed - the panel restarting, the network gone, an
|
||||
// error answer - is tried again, later each time: the wait doubles with
|
||||
// each failure in a row, up to a minute, and is back to normal after the
|
||||
// first refresh that works (audit 2026-10-12, M11).
|
||||
var pollMaxMs = 60000;
|
||||
var pollFailures = Object.create(null);
|
||||
// No pointer/keyboard/scroll input for this long → treat the tab as idle.
|
||||
var userIdleMs = 30000;
|
||||
var lastActivity = Date.now();
|
||||
@@ -232,12 +238,19 @@
|
||||
}, { passive: true });
|
||||
});
|
||||
|
||||
function pollDelayMs() {
|
||||
return Date.now() - lastActivity < userIdleMs ? pollActiveMs : pollIdleMs;
|
||||
function pollDelayMs(id) {
|
||||
var base = Date.now() - lastActivity < userIdleMs ? pollActiveMs : pollIdleMs;
|
||||
var n = pollFailures[id] || 0;
|
||||
return n ? Math.min(base * Math.pow(2, n), pollMaxMs) : base;
|
||||
}
|
||||
|
||||
// The box is the request's source, so htmx fires the request's events on
|
||||
// it and not on the body (htmx 2.0.4, src/htmx.js ajaxHelper():
|
||||
// issueAjaxRequest(verb, path, resolveTarget(context.source), ...), and
|
||||
// with no source issueAjaxRequest() falls back to the document's body).
|
||||
function triggerPoll(el) {
|
||||
htmx.ajax("GET", el.getAttribute("hx-get"), {
|
||||
source: el,
|
||||
target: "#" + el.id,
|
||||
swap: el.getAttribute("hx-swap") || "outerHTML"
|
||||
});
|
||||
@@ -266,11 +279,12 @@
|
||||
return;
|
||||
}
|
||||
triggerPoll(current);
|
||||
}, pollDelayMs());
|
||||
}, pollDelayMs(id));
|
||||
}
|
||||
|
||||
function onPollElementReady(el) {
|
||||
if (!el || !el.hasAttribute("data-poll")) {
|
||||
document.body.addEventListener("htmx:afterSwap", function (ev) {
|
||||
var el = ev.detail.elt;
|
||||
if (!el || !el.hasAttribute || !el.hasAttribute("data-poll")) {
|
||||
return;
|
||||
}
|
||||
// Swapped-in markup still carries hx-trigger="load"; strip it so htmx does
|
||||
@@ -279,15 +293,31 @@
|
||||
// elements before doSettle() runs the settle tasks, and only those
|
||||
// (makeAjaxLoadTask -> processNode) act on hx-trigger.
|
||||
el.removeAttribute("hx-trigger");
|
||||
schedulePoll(el);
|
||||
}
|
||||
|
||||
document.body.addEventListener("htmx:afterSwap", function (ev) {
|
||||
onPollElementReady(ev.detail.elt);
|
||||
});
|
||||
|
||||
document.body.addEventListener("htmx:responseError", function (ev) {
|
||||
onPollElementReady(ev.detail.elt);
|
||||
// The next refresh is scheduled when a request of the box ends, however
|
||||
// it ended. htmx 2.0.4, src/htmx.js issueAjaxRequest(): htmx:afterRequest
|
||||
// is fired on load, error, abort and timeout alike, and after a swap that
|
||||
// took the box out of the page it is fired again on the nearest parent
|
||||
// still in it - the event that reaches the body names the box by its
|
||||
// target. A refresh that ended in an error answer is not successful
|
||||
// (handleAjaxResponse(): responseInfo.successful = !isError); one cut off
|
||||
// never got that far.
|
||||
document.body.addEventListener("htmx:afterRequest", function (ev) {
|
||||
var target = ev.detail.target;
|
||||
if (!target || !target.id) {
|
||||
return;
|
||||
}
|
||||
var el = document.getElementById(target.id);
|
||||
if (!el || !el.hasAttribute("data-poll")) {
|
||||
return;
|
||||
}
|
||||
if (ev.detail.successful) {
|
||||
delete pollFailures[el.id];
|
||||
} else {
|
||||
pollFailures[el.id] = (pollFailures[el.id] || 0) + 1;
|
||||
}
|
||||
schedulePoll(el);
|
||||
});
|
||||
|
||||
document.body.addEventListener("htmx:beforeRequest", function (ev) {
|
||||
|
||||
+148
@@ -0,0 +1,148 @@
|
||||
// The polling of panel.js, run in node against a stand-in for the few parts
|
||||
// of the DOM and htmx it uses, with a clock the test moves. Run by
|
||||
// TestPanelJSPolling (paneljs_test.go): node poll_test.js <panel.js>.
|
||||
// Exits non-zero with what went wrong.
|
||||
"use strict";
|
||||
const fs = require("fs");
|
||||
const vm = require("vm");
|
||||
|
||||
const failures = [];
|
||||
function check(cond, what) {
|
||||
if (!cond) failures.push(what);
|
||||
}
|
||||
|
||||
// --- the clock ------------------------------------------------------------
|
||||
let now = 1000000;
|
||||
let timers = [];
|
||||
let nextTimer = 1;
|
||||
function setTimeout(fn, ms) {
|
||||
const id = nextTimer++;
|
||||
timers.push({ id, at: now + ms, ms, fn });
|
||||
return id;
|
||||
}
|
||||
function clearTimeout(id) {
|
||||
timers = timers.filter((t) => t.id !== id);
|
||||
}
|
||||
function pendingDelays() {
|
||||
return timers.map((t) => t.ms);
|
||||
}
|
||||
function advance(ms) {
|
||||
now += ms;
|
||||
const due = timers.filter((t) => t.at <= now);
|
||||
timers = timers.filter((t) => t.at > now);
|
||||
due.forEach((t) => t.fn());
|
||||
}
|
||||
const FakeDate = { now: () => now };
|
||||
|
||||
// --- the page ---------------------------------------------------------------
|
||||
function element(id, attrs) {
|
||||
return {
|
||||
id,
|
||||
attrs: Object.assign({}, attrs),
|
||||
hasAttribute(n) { return n in this.attrs; },
|
||||
getAttribute(n) { return n in this.attrs ? this.attrs[n] : null; },
|
||||
removeAttribute(n) { delete this.attrs[n]; },
|
||||
};
|
||||
}
|
||||
const listeners = { document: {}, body: {}, window: {} };
|
||||
function on(where) {
|
||||
return (type, fn) => {
|
||||
(listeners[where][type] = listeners[where][type] || []).push(fn);
|
||||
};
|
||||
}
|
||||
let inPage = {};
|
||||
const document = {
|
||||
hidden: false,
|
||||
addEventListener: on("document"),
|
||||
body: { addEventListener: on("body") },
|
||||
getElementById: (id) => inPage[id] || null,
|
||||
querySelectorAll: (sel) => (sel === "[data-poll]" ? Object.values(inPage).filter((e) => e.hasAttribute("data-poll")) : []),
|
||||
};
|
||||
const window = { addEventListener: on("window"), confirm: () => true };
|
||||
const requests = [];
|
||||
const htmx = {
|
||||
ajax(verb, path, ctx) {
|
||||
requests.push({ verb, path, ctx });
|
||||
},
|
||||
};
|
||||
// The operator moved the mouse: the page counts as in use for 30 s.
|
||||
function activity() {
|
||||
(listeners.document.mousemove || []).forEach((fn) => fn({}));
|
||||
}
|
||||
function fireBody(type, detail) {
|
||||
(listeners.body[type] || []).forEach((fn) => fn({ type, detail, target: detail.elt }));
|
||||
}
|
||||
|
||||
vm.runInNewContext(fs.readFileSync(process.argv[2], "utf8"), {
|
||||
document, window, htmx, setTimeout, clearTimeout, Date: FakeDate,
|
||||
Object, Math, console,
|
||||
});
|
||||
|
||||
// --- the cases --------------------------------------------------------------
|
||||
const box = element("overview-stats", { "data-poll": "", "hx-get": "/overview/stats", "hx-trigger": "load" });
|
||||
inPage = { [box.id]: box };
|
||||
|
||||
// The first load ended well: the next refresh in 5 s, as the box's source.
|
||||
fireBody("htmx:afterRequest", { target: box, elt: box, successful: true });
|
||||
check(pendingDelays().join() === "5000", "after a refresh that worked: waits " + pendingDelays() + ", want 5000");
|
||||
advance(5000);
|
||||
check(requests.length === 1, "no refresh was asked for after 5 s");
|
||||
check(requests[0] && requests[0].ctx.source === box, "the refresh does not name the box as its source");
|
||||
check(requests[0] && requests[0].ctx.target === "#overview-stats", "the refresh targets " + (requests[0] && requests[0].ctx.target));
|
||||
|
||||
// Failures in a row - an error answer, a dropped connection, a timeout -
|
||||
// each double the wait, up to a minute; a refresh is always scheduled.
|
||||
const waits = [];
|
||||
for (let i = 0; i < 5; i++) {
|
||||
activity();
|
||||
fireBody("htmx:afterRequest", { target: box, elt: box, successful: i === 0 ? false : undefined });
|
||||
waits.push(pendingDelays().join());
|
||||
advance(Number(pendingDelays()[0] || 0));
|
||||
}
|
||||
check(waits.join(" ") === "10000 20000 40000 60000 60000", "the waits after failures in a row: " + waits.join(" ") + ", want 10000 20000 40000 60000 60000");
|
||||
check(requests.length === 6, "refreshes asked for: " + requests.length + ", want one per wait");
|
||||
|
||||
// One that works puts the wait back.
|
||||
activity();
|
||||
fireBody("htmx:afterRequest", { target: box, elt: box, successful: true });
|
||||
check(pendingDelays().join() === "5000", "after failures and a success: waits " + pendingDelays() + ", want 5000");
|
||||
|
||||
// A swap replaced the box: the event that reaches the body comes from a
|
||||
// parent and names the old box as its target; the new one is scheduled.
|
||||
timers = [];
|
||||
const fresh = element("overview-stats", { "data-poll": "", "hx-get": "/overview/stats", "hx-trigger": "load" });
|
||||
inPage = { [fresh.id]: fresh };
|
||||
fireBody("htmx:afterSwap", { elt: fresh });
|
||||
check(!fresh.hasAttribute("hx-trigger"), "the swapped-in box keeps hx-trigger");
|
||||
activity();
|
||||
fireBody("htmx:afterRequest", { target: box, elt: { id: "main" }, successful: true });
|
||||
check(pendingDelays().join() === "5000", "after a swap: waits " + pendingDelays() + ", want 5000");
|
||||
advance(5000);
|
||||
check(requests[requests.length - 1].ctx.source === fresh, "the refresh after a swap is not the new box's");
|
||||
|
||||
// Idle for longer than 30 s: 30 s between refreshes, doubled from there.
|
||||
timers = [];
|
||||
now += 31000;
|
||||
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: true });
|
||||
check(pendingDelays().join() === "30000", "idle: waits " + pendingDelays() + ", want 30000");
|
||||
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: false });
|
||||
check(pendingDelays().join() === "60000", "idle, one failure: waits " + pendingDelays() + ", want 60000");
|
||||
|
||||
// A hidden tab schedules nothing.
|
||||
timers = [];
|
||||
document.hidden = true;
|
||||
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: true });
|
||||
check(timers.length === 0, "a hidden tab scheduled a refresh");
|
||||
document.hidden = false;
|
||||
|
||||
// A request of something that is not a polled box is not its business.
|
||||
timers = [];
|
||||
inPage.other = element("other", {});
|
||||
fireBody("htmx:afterRequest", { target: inPage.other, elt: inPage.other, successful: true });
|
||||
check(timers.length === 0, "a request of a box that does not poll scheduled a refresh");
|
||||
|
||||
if (failures.length) {
|
||||
console.log(failures.join("\n"));
|
||||
process.exit(1);
|
||||
}
|
||||
console.log("ok");
|
||||
Reference in New Issue
Block a user