audit 6: documents, comments, dead code and staticcheck; the test gaps closed

The last stage of the 2026-10-12 audit; no cut.

Doc drift: architecture.md (the sender check in § OpenDKIM, the limit:
row's 48 hours, the inbound log and filter-list routes and who may open
them, migrations to 0011 and every table, KitPage as production data,
Reload configuration as a restore writes, the panel's roles counted),
schema-migrations.md (tables and columns since v2), guide.md (a delivery's
lines go at the next prune; INBOUND_JOURNAL_MILTER_SOCKET moved to
architecture.md's internal list), development.md (the env guard, the
deferral the e2e proves, its fixed sleeps), roadmap.md.

Comments say what the code does now; TestBaselineIsTheOnlyMigration is
TestChainStartsAtTheBaseline; the milter package doc names its three
milters.

Dead code gone: view.Facts, dmarc HostedSuggestion and
ValidateHostedAddress, app UpdateMode (each with the test that alone kept
it), the method checks the method-bound routes made dead;
Settings.WithResult calls resultFlash. staticcheck 2026.1 in test.yml on
both modules, clean: the e2e package builds without its tests now (a test
and two constants moved out of non-test files), three findings fixed.
The test moved, TestImageBuildPreservesLogrotateMode, had sat in a
non-test file and never run; run, it failed on the entrypoint (docker run
without a hostname) and now asks with --entrypoint stat.

The test gaps no step named, each closed: follow() with mail.log gone past
blindMin and made again; CheckRestore with a manifest that is not JSON;
the origin check with a port; every /server/ pattern in web.go through
server() and in the routes table (it found GET /server/health/fragment
missing from the table - guarded, not tested); L9 as the owner decided it
on 2026-10-12, the comment on senderSession.Headers and the test passing
an h that holds the earlier messages' From:.

Plan stage 6 ticked; roadmap audit row done, 81/81.

Tested on the test server: go vet + go test of 27 packages, make e2e (all
pass, 513 s) on this tree; staticcheck locally on both modules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test/e2e/logrotate_check.go

@@ -2,11 +2,7 @@ package e2e
 
 import (
 	"fmt"
-	"os"
-	"os/exec"
-	"path/filepath"
 	"strings"
-	"testing"
 	"time"
 )
 
@@ -61,46 +57,3 @@ func checkLogrotateRotation(s *stack) error {
 	}
 	return nil
 }
-
-// TestImageBuildPreservesLogrotateMode builds from a context where
-// logrotate-mail.conf is group-writable and checks the image still ships 0644.
-func TestImageBuildPreservesLogrotateMode(t *testing.T) {
-	conf := filepath.Join(h.repoRoot, "build", "logrotate-mail.conf")
-	info, err := os.Stat(conf)
-	if err != nil {
-		t.Fatalf("stat source config: %v", err)
-	}
-	origMode := info.Mode().Perm()
-
-	if err := os.Chmod(conf, origMode|0o020); err != nil {
-		t.Fatalf("chmod g+w source config: %v", err)
-	}
-	t.Cleanup(func() {
-		_ = os.Chmod(conf, origMode)
-	})
-
-	tag := "selfpost:e2e-logrotate-mode"
-	build := exec.Command("docker", "build",
-		"-f", filepath.Join(h.repoRoot, "build", "Dockerfile"),
-		"-t", tag,
-		"--build-arg", "VERSION=e2e",
-		h.repoRoot,
-	)
-	build.Env = os.Environ()
-	if out, err := build.CombinedOutput(); err != nil {
-		t.Fatalf("docker build with group-writable context config: %v\n%s", err, out)
-	}
-	t.Cleanup(func() {
-		_, _ = exec.Command("docker", "rmi", "-f", tag).CombinedOutput()
-	})
-
-	run := exec.Command("docker", "run", "--rm", tag, "stat", "-c", "%a", "/etc/logrotate.d/mail")
-	run.Env = os.Environ()
-	out, err := run.CombinedOutput()
-	if err != nil {
-		t.Fatalf("stat in image: %v\n%s", err, out)
-	}
-	if strings.TrimSpace(string(out)) != "644" {
-		t.Fatalf("image logrotate config mode is %q, want 644", strings.TrimSpace(string(out)))
-	}
-}