release: 1.9.2: Review pass: port-25 milters, DMARC validation, rate-limit fix
Review pass over `1.4.0`…`1.9.1`: port 25 no longer shares the submission milter chain, DMARC reports are validated before they are stored, and the auto rate limit is correct for a non-default level-1 window. Schema migration `0010` (index only). Upgrading is a tag bump. Added: - SQLite migration `0010_send_log_app_login_index.sql` — - DMARC aggregate reports are accepted as **zip** as well as gzip or plain XML - e2e: `checkPort25ConfigCombinations` regenerates the Postfix configuration Changed: - README hero line and a **Positioning** block in `docs/product.md` record the Fixed: - The setup account's password is hashed at bcrypt cost `12` like every other - Login/setup rate limiter: protecting blocked buckets from eviction is now - `postqueue -p` output is bounded to 4 MiB (the timeout alone left the size of - [schema-migrations.md](docs/schema-migrations.md): the schema section was - postqueue reader is now time-bounded: `postqueue -p` runs under a 5-second … (11 more in CHANGELOG) Changed: - [roadmap.md](docs/roadmap.md) now carries everything the 2026-08-19 code - Extracted `internal/configsafe` — the empty-value and forbidden-character - Build, deploy and migration comments no longer cite the archived - Dropped the `parseDomainRateLimitForm` / `parseAppRateLimitForm` pass-through - Extracted shared helpers: `internal/atomicfile` (atomic temp-write+rename) and … (7 more in CHANGELOG) Removed: - Unused legacy asset `docs/assets/icon.png` (superseded by the four brand SVGs - Plan documents for already-shipped features: `domain-stats-auto-ratelimit`, Full detail: CHANGELOG.md (1.9.2).
This commit is contained in:
@@ -15,6 +15,13 @@ const (
|
||||
sessionCookiePrefixed = "__Host-" + sessionCookieBase
|
||||
)
|
||||
|
||||
// BcryptCost is the work factor for every panel password hash — the setup
|
||||
// account created here and the ones the settings and user pages write
|
||||
// (security.md). bcrypt records the cost inside the hash, so raising it only
|
||||
// affects passwords set from now on; existing hashes keep verifying at the
|
||||
// cost they were written with.
|
||||
const BcryptCost = 12
|
||||
|
||||
func (m *Module) sessionCookie() string {
|
||||
if m.cfg.CookieSecure {
|
||||
return sessionCookiePrefixed
|
||||
@@ -219,7 +226,7 @@ func (m *Module) submitSetup(w http.ResponseWriter, r *http.Request, token strin
|
||||
return
|
||||
}
|
||||
|
||||
hash, err := bcrypt.GenerateFromPassword([]byte(password), bcrypt.DefaultCost)
|
||||
hash, err := bcrypt.GenerateFromPassword([]byte(password), BcryptCost)
|
||||
if err != nil {
|
||||
logf("panel: setup: hashing password failed: %v", err)
|
||||
m.renderSetupForm(w, http.StatusInternalServerError, token, "Internal error. Please try again.")
|
||||
|
||||
@@ -7,6 +7,16 @@ import (
|
||||
|
||||
const defaultMaxBuckets = 4096
|
||||
|
||||
// blockedBucketCeiling is how far past maxBuckets the map may grow while every
|
||||
// bucket in it is blocked. Blocked buckets are normally protected from
|
||||
// eviction (see evictNearest), but protecting them unconditionally would let
|
||||
// an attacker with many source addresses grow the map without bound — each
|
||||
// address only has to fail max times. Past the ceiling blocked buckets are
|
||||
// evicted too, nearest expiry first: bounded memory wins over holding every
|
||||
// block, and the addresses that lose their bucket have to spend max attempts
|
||||
// again to get back to blocked.
|
||||
const blockedBucketCeiling = 4
|
||||
|
||||
// rateLimiter is a simple fixed-window per-key counter used to throttle the
|
||||
// setup and login routes (security.md). Keys are client IPs.
|
||||
type rateLimiter struct {
|
||||
@@ -14,8 +24,9 @@ type rateLimiter struct {
|
||||
window time.Duration
|
||||
maxBuckets int
|
||||
|
||||
mu sync.Mutex
|
||||
buckets map[string]*rlBucket
|
||||
mu sync.Mutex
|
||||
buckets map[string]*rlBucket
|
||||
lastOverflow time.Time
|
||||
}
|
||||
|
||||
type rlBucket struct {
|
||||
@@ -68,25 +79,51 @@ func (r *rateLimiter) makeRoom(now time.Time) {
|
||||
return
|
||||
}
|
||||
r.sweep(now)
|
||||
hardCap := r.maxBuckets * blockedBucketCeiling
|
||||
for len(r.buckets) >= r.maxBuckets {
|
||||
r.evictOldest()
|
||||
if r.evictNearest(false) {
|
||||
continue
|
||||
}
|
||||
// Nothing evictable is left: every remaining bucket is blocked. Hold
|
||||
// them until the map reaches the hard ceiling, then start evicting
|
||||
// blocked buckets as well so memory stays bounded.
|
||||
if len(r.buckets) < hardCap {
|
||||
break
|
||||
}
|
||||
if !r.evictNearest(true) {
|
||||
break
|
||||
}
|
||||
if now.Sub(r.lastOverflow) >= r.window {
|
||||
r.lastOverflow = now
|
||||
logf("panel: login rate limiter holds %d blocked buckets (cap %d) — evicting blocked entries; "+
|
||||
"this means many distinct client addresses are failing authentication", len(r.buckets), r.maxBuckets)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func (r *rateLimiter) evictOldest() {
|
||||
var oldestKey string
|
||||
var oldestEnds time.Time
|
||||
// evictNearest removes the bucket whose window ends soonest and reports whether
|
||||
// it removed one. Blocked buckets (count >= max) are skipped unless evictBlocked
|
||||
// is set, so an attacker cannot flush active rate-limit state by filling the map
|
||||
// with new keys.
|
||||
func (r *rateLimiter) evictNearest(evictBlocked bool) bool {
|
||||
var bestKey string
|
||||
var bestEnds time.Time
|
||||
first := true
|
||||
for k, b := range r.buckets {
|
||||
if first || b.windowEnds.Before(oldestEnds) {
|
||||
oldestKey = k
|
||||
oldestEnds = b.windowEnds
|
||||
if !evictBlocked && b.count >= r.max {
|
||||
continue
|
||||
}
|
||||
if first || b.windowEnds.Before(bestEnds) {
|
||||
bestKey = k
|
||||
bestEnds = b.windowEnds
|
||||
first = false
|
||||
}
|
||||
}
|
||||
if oldestKey != "" {
|
||||
delete(r.buckets, oldestKey)
|
||||
if bestKey == "" {
|
||||
return false
|
||||
}
|
||||
delete(r.buckets, bestKey)
|
||||
return true
|
||||
}
|
||||
|
||||
func (r *rateLimiter) sweep(now time.Time) {
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
package auth
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
@@ -123,3 +124,53 @@ func TestRateLimiterCapsBucketCount(t *testing.T) {
|
||||
t.Fatalf("bucket count = %d, want at most 3", len(r.buckets))
|
||||
}
|
||||
}
|
||||
|
||||
// A flood of new addresses must not be able to reset the limiter for an address
|
||||
// that is already blocked: below the hard ceiling, blocked buckets survive
|
||||
// eviction even though the map is over its soft cap.
|
||||
func TestRateLimiterKeepsBlockedBucketsUnderPressure(t *testing.T) {
|
||||
r := newRateLimiter(2, time.Minute)
|
||||
r.maxBuckets = 3
|
||||
|
||||
blocked := []string{"203.0.113.7", "198.51.100.9", "192.0.2.5"}
|
||||
for _, key := range blocked {
|
||||
for i := 0; i < 2; i++ {
|
||||
if !r.Allow(key) {
|
||||
t.Fatalf("%s refused before reaching the limit", key)
|
||||
}
|
||||
}
|
||||
if r.Allow(key) {
|
||||
t.Fatalf("%s was not blocked after 2 attempts", key)
|
||||
}
|
||||
}
|
||||
|
||||
// Fresh addresses arrive and find nothing evictable.
|
||||
for i := 0; i < 10; i++ {
|
||||
r.Allow(fmt.Sprintf("198.51.100.%d", 100+i))
|
||||
}
|
||||
|
||||
for _, key := range blocked {
|
||||
if r.Allow(key) {
|
||||
t.Fatalf("%s lost its block after new addresses arrived", key)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Protecting blocked buckets is bounded: past maxBuckets * blockedBucketCeiling
|
||||
// they are evicted too, so an attacker cannot grow the map without limit by
|
||||
// burning through source addresses.
|
||||
func TestRateLimiterBoundsBlockedBuckets(t *testing.T) {
|
||||
r := newRateLimiter(1, time.Minute)
|
||||
r.maxBuckets = 2
|
||||
hardCap := r.maxBuckets * blockedBucketCeiling
|
||||
|
||||
for i := 0; i < 100; i++ {
|
||||
r.Allow(fmt.Sprintf("192.0.2.%d", i))
|
||||
}
|
||||
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
if len(r.buckets) > hardCap {
|
||||
t.Fatalf("bucket count = %d, want at most the hard cap %d", len(r.buckets), hardCap)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user