feat: implement B.1 — persist login sessions in SQLite with sliding idle timeout
Sessions move from an in-memory map (absolute 12h TTL) to a `sessions` table (migration 0002), storing only the SHA-256 of the token. Expiry is now a sliding idle window (PANEL_SESSION_IDLE_DAYS, default 7, no absolute cap), extended at most once an hour and never by the monitoring screens' background polling (GET + HX-Request), so a forgotten open tab doesn't keep a session alive indefinitely. A login now survives a container restart or redeploy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,113 @@
|
||||
package store
|
||||
|
||||
import (
|
||||
"database/sql"
|
||||
"errors"
|
||||
"fmt"
|
||||
"time"
|
||||
)
|
||||
|
||||
// SessionRow is a persisted login session, keyed by the SHA-256 of its token
|
||||
// (see internal/web, which owns the token itself).
|
||||
type SessionRow struct {
|
||||
Username string
|
||||
ExpiresAt time.Time
|
||||
}
|
||||
|
||||
// CreateSession inserts a new session row.
|
||||
func (s *Store) CreateSession(tokenHash, username string, expiresAt time.Time) error {
|
||||
now := time.Now().UTC().Format(time.RFC3339)
|
||||
_, err := s.db.Exec(
|
||||
`INSERT INTO sessions (token_hash, username, created_at, expires_at) VALUES (?, ?, ?, ?)`,
|
||||
tokenHash, username, now, expiresAt.UTC().Format(time.RFC3339),
|
||||
)
|
||||
if err != nil {
|
||||
return fmt.Errorf("insert session: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// LookupSession returns the session for tokenHash, if any. It does not check
|
||||
// expiry itself — callers compare ExpiresAt against time.Now() and call
|
||||
// DeleteSession on an expired row, keeping the read side lock-free.
|
||||
func (s *Store) LookupSession(tokenHash string) (SessionRow, bool, error) {
|
||||
var (
|
||||
row SessionRow
|
||||
expiresAt string
|
||||
)
|
||||
err := s.db.QueryRow(
|
||||
`SELECT username, expires_at FROM sessions WHERE token_hash = ?`,
|
||||
tokenHash,
|
||||
).Scan(&row.Username, &expiresAt)
|
||||
if errors.Is(err, sql.ErrNoRows) {
|
||||
return SessionRow{}, false, nil
|
||||
}
|
||||
if err != nil {
|
||||
return SessionRow{}, false, fmt.Errorf("lookup session: %w", err)
|
||||
}
|
||||
row.ExpiresAt, err = time.Parse(time.RFC3339, expiresAt)
|
||||
if err != nil {
|
||||
return SessionRow{}, false, fmt.Errorf("parse session expiry: %w", err)
|
||||
}
|
||||
return row, true, nil
|
||||
}
|
||||
|
||||
// RenewSession pushes a session's expiry forward, implementing the sliding
|
||||
// idle timeout.
|
||||
func (s *Store) RenewSession(tokenHash string, expiresAt time.Time) error {
|
||||
_, err := s.db.Exec(
|
||||
`UPDATE sessions SET expires_at = ? WHERE token_hash = ?`,
|
||||
expiresAt.UTC().Format(time.RFC3339), tokenHash,
|
||||
)
|
||||
if err != nil {
|
||||
return fmt.Errorf("renew session: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// RenameSession updates the username carried by a session, keeping its
|
||||
// expiry, so a session stays usable after the administrator renames their own
|
||||
// account.
|
||||
func (s *Store) RenameSession(tokenHash, username string) error {
|
||||
_, err := s.db.Exec(
|
||||
`UPDATE sessions SET username = ? WHERE token_hash = ?`,
|
||||
username, tokenHash,
|
||||
)
|
||||
if err != nil {
|
||||
return fmt.Errorf("rename session: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// DeleteSession removes a session row (logout, or a lookup finding it
|
||||
// expired).
|
||||
func (s *Store) DeleteSession(tokenHash string) error {
|
||||
if _, err := s.db.Exec(`DELETE FROM sessions WHERE token_hash = ?`, tokenHash); err != nil {
|
||||
return fmt.Errorf("delete session: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// DeleteOtherSessions removes every session except keepHash. It is called
|
||||
// when the administrator changes their password: a stolen cookie issued
|
||||
// under the old password must stop working, while the session performing the
|
||||
// change stays signed in.
|
||||
func (s *Store) DeleteOtherSessions(keepHash string) error {
|
||||
if _, err := s.db.Exec(`DELETE FROM sessions WHERE token_hash != ?`, keepHash); err != nil {
|
||||
return fmt.Errorf("delete other sessions: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// DeleteExpiredSessions prunes rows whose expiry has already passed, so an
|
||||
// abandoned session (cookie never presented again) does not sit in the table
|
||||
// forever. It piggybacks on session creation rather than running as its own
|
||||
// background loop.
|
||||
func (s *Store) DeleteExpiredSessions(now time.Time) (int64, error) {
|
||||
res, err := s.db.Exec(`DELETE FROM sessions WHERE expires_at < ?`, now.UTC().Format(time.RFC3339))
|
||||
if err != nil {
|
||||
return 0, fmt.Errorf("prune sessions: %w", err)
|
||||
}
|
||||
n, _ := res.RowsAffected()
|
||||
return n, nil
|
||||
}
|
||||
Reference in New Issue
Block a user