audit 2c: findings of the two reviews

Technical review (Opus, 11 findings, 2 medium) and security review (Fable,
no high or medium) of 3c86280..HEAD. Both confirm the port gives
dkim_mail_parse()'s result on every input it parses, and that no line the
check passes is signed with another domain's key.

- F1 (medium): OpenDKIM's parser takes lines no mail program reads as one
  address - "ceo@bank.com:me@mine.com", "Name <ceo@bank.com:me@mine.com>",
  "<b@evil.com, a@mine.com>", "ceo@bank.com <me@mine.com>",
  "ceo@bank.com@mine.com" - and signs for the last while a lenient reader
  shows the first. The line must now also be one address in RFC 5322's
  grammar (net/mail, display names in any charset passed through), at the
  domain OpenDKIM signs for. A quoted display name may still hold anything.
- F2 (medium): the bindings were asked about OpenDKIM's form of the
  address, quotes and all, so "x"@mine.com passed for an application
  holding @mine.com while x@mine.com belonged to another. They are now
  asked about the reader's address, its local part unquoted, as Postfix
  holds the envelope's.
- F3 / security (low): Bindings.Allowed and DomainOf fold case in ASCII
  only: Postfix folds as Unicode (casefold.c, ICU), but every key and
  login the panel writes is ASCII, and the Unicode fold let the Kelvin sign
  pass for "k" (net/mail then refuses such a line on the domain test).
- F4 (low): a TERM between "postfix start-fg &" and "child=$!" is no longer
  lost: the wrapper stops Postfix as soon as the pid is known.
- F5 (low): for startsecs after a start any failed reload passed as "not
  running". postfix-reload is now build/postfix-reload.sh: exit 75 when
  master -t says no master runs, else exec postfix reload; RunOnce returns
  EndError with the status, and only 75 is taken as done. supervisor.State
  goes.
- F6 (low): crashexit spares postfix-reload too - a reload that could not
  be spawned is reported to whoever asked, not a reason to stop the
  container.
- F7 (low): a certs/ that is itself a link is resolved before the walk
  (filepath.WalkDir does not follow its root).
- F8 (low): at shutdown the tailer reads what is left of the rotated
  file before saving its place. Not changed: a refusal line still waiting
  on the old file at shutdown is not kept - the panel writes refused rows
  itself, only a kill loses one, and that window is the minute's grace.
- F9 (low): pct read as text - empty or unreadable is 100, the rest held
  to 0..100.
- F10 (low): the directory is synced after sasldb2's rename.
- F11 (low): POSTFIX_STARTSECS by expr, so "010" or "08" in
  MILTER_WAIT_TIMEOUT are decimal, not octal or an error.
- Security (low): pagehide also empties defaultValue - the input's value
  attribute and the textarea's text - not only .value. A sasldb2.new left
  by a killed panel is removed at start (entrypoint) and never archived.
  security.md says that links under certs/ are followed and by whom they
  can be placed.

Tests: sender check cases for F1 (four lines), F2 (a bound address
quoted, for its owner and for another), F3; EndError's state and status;
pct cases. architecture.md and CHANGELOG describe the reader rule. Stand
(2026-10-15, make e2e, exit 0); go vet and go test ./... pass on the
server (24 packages).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

internal/dmarc/parse.go

@@ -7,6 +7,7 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
+	"strconv"
 	"strings"
 	"time"
 	"unicode/utf8"
@@ -57,12 +58,12 @@ type feedbackXML struct {
 		} `xml:"date_range"`
 	} `xml:"report_metadata"`
 	Policy struct {
-		Domain string `xml:"domain"`
-		P      string `xml:"p"`
-		SP     string `xml:"sp"`
-		Pct    *int   `xml:"pct"`
-		ADKIM  string `xml:"adkim"`
-		ASPF   string `xml:"aspf"`
+		Domain string  `xml:"domain"`
+		P      string  `xml:"p"`
+		SP     string  `xml:"sp"`
+		Pct    *string `xml:"pct"`
+		ADKIM  string  `xml:"adkim"`
+		ASPF   string  `xml:"aspf"`
 	} `xml:"policy_published"`
 	Records []struct {
 		Row struct {
@@ -139,11 +140,15 @@ func ParseAggregate(raw []byte) (ParsedReport, error) {
 		PolicyASPF:   field(doc.Policy.ASPF),
 	}
 	// RFC 7489 § 6.3: pct is "between 0 and 100, inclusive", 100 when absent.
-	// An explicit 0 is a policy applied to no message, and stays 0; only a
-	// report without the element gets the default (assumptions C-M7).
+	// An explicit 0 is a policy applied to no message, and stays 0; a report
+	// without the element, or with an empty or unreadable one, gets the
+	// default, and a value outside the range is held to it (assumptions
+	// C-M7; review of stage 2c, F9).
 	out.PolicyPct = 100
 	if doc.Policy.Pct != nil {
-		out.PolicyPct = *doc.Policy.Pct
+		if n, err := strconv.Atoi(strings.TrimSpace(*doc.Policy.Pct)); err == nil {
+			out.PolicyPct = min(max(n, 0), 100)
+		}
 	}
 	for _, rec := range doc.Records {
 		row := ParsedRecord{

internal/dmarc/parse_test.go

@@ -271,6 +271,11 @@ func TestPolicyPct(t *testing.T) {
 		{"<pct>0</pct>", 0},
 		{"<pct>25</pct>", 25},
 		{"", 100},
+		{"<pct/>", 100},
+		{"<pct> 50 </pct>", 50},
+		{"<pct>150</pct>", 100},
+		{"<pct>-5</pct>", 0},
+		{"<pct>x</pct>", 100},
 	} {
 		doc := strings.Replace(sampleXML, "<pct>100</pct>", c.pct, 1)
 		got, err := ParseAggregate([]byte(doc))