user-reauth: the user form asks for your account password (audit A2)
Security audit 2026-10-17, finding A2 (high), stage 0; the mockup is
2c27275. A stolen global session could set its own password on the user
form - no current password asked, the session kept - and then pass the
backup's reauth with it, or add a second global user with a known
password. Now the user form calls reauth (the backup's check: bcrypt
against the signed-in user's own hash, under auth.AllowPasswordChange) when
it adds a user and when a save sets a password, changes the e-mail (reset
links go there) or changes the role, the own account included; deleting a
user asks too, refused on its own confirmation page (renderUserDelete, a
Flash on UserDelete). Name and reach alone are not asked. Missing or wrong:
401 on the same page, "Your account password is incorrect.", nothing saved.
Tests: TestUserFormAsksForTheAccountPassword (create, each of password,
e-mail, role, own password, reach alone, delete); the user-form tests send
the field (withAccountPassword gives root a real hash and h an auth
module). go vet, go test ./internal/web/... on Windows.
Docs: security.md § Backup and domain export, guide § Users, help word for
word with the mockup; CHANGELOG [Unreleased] Security; plan line ticked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -353,11 +353,12 @@ func TestUserFormAssignsBothDirections(t *testing.T) {
|
||||
out, _ := st.AddDomain("out.example.com", "mail")
|
||||
in, _ := st.AddInboundDomain("in.example.com")
|
||||
root := userWith(t, st, "root", store.RoleGlobal, store.Reach{})
|
||||
withAccountPassword(t, h, st, root)
|
||||
const password = "a-long-enough-password-1"
|
||||
|
||||
create := func(username string, extra url.Values) (*httptest.ResponseRecorder, store.User) {
|
||||
t.Helper()
|
||||
form := url.Values{"username": {username}, "password": {password}, "role": {"domain"}}
|
||||
form := url.Values{"username": {username}, "password": {password}, "role": {"domain"}, "account_password": {testAccountPassword}}
|
||||
for k, v := range extra {
|
||||
form[k] = v
|
||||
}
|
||||
@@ -385,6 +386,7 @@ func TestUserFormAssignsBothDirections(t *testing.T) {
|
||||
update := func(u store.User, form url.Values) store.User {
|
||||
t.Helper()
|
||||
form.Set("username", u.Username)
|
||||
form.Set("account_password", testAccountPassword)
|
||||
rec := send(h.HandleUserEdit, &root, "POST", "/server/users/"+idStr(u.ID), map[string]string{"uid": idStr(u.ID)}, form)
|
||||
if rec.Code != http.StatusSeeOther {
|
||||
t.Fatalf("update %s = %d:\n%s", u.Username, rec.Code, rec.Body.String())
|
||||
|
||||
Reference in New Issue
Block a user