user-reauth: the user form asks for your account password (audit A2)
Security audit 2026-10-17, finding A2 (high), stage 0; the mockup is
2c27275. A stolen global session could set its own password on the user
form - no current password asked, the session kept - and then pass the
backup's reauth with it, or add a second global user with a known
password. Now the user form calls reauth (the backup's check: bcrypt
against the signed-in user's own hash, under auth.AllowPasswordChange) when
it adds a user and when a save sets a password, changes the e-mail (reset
links go there) or changes the role, the own account included; deleting a
user asks too, refused on its own confirmation page (renderUserDelete, a
Flash on UserDelete). Name and reach alone are not asked. Missing or wrong:
401 on the same page, "Your account password is incorrect.", nothing saved.
Tests: TestUserFormAsksForTheAccountPassword (create, each of password,
e-mail, role, own password, reach alone, delete); the user-form tests send
the field (withAccountPassword gives root a real hash and h an auth
module). go vet, go test ./internal/web/... on Windows.
Docs: security.md § Backup and domain export, guide § Users, help word for
word with the mockup; CHANGELOG [Unreleased] Security; plan line ticked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -341,7 +341,8 @@ func NewUserForm(m Meta, in UserFormInput) *UserForm {
|
||||
// what goes with them, the one button that does it, and the way out.
|
||||
type UserDelete struct {
|
||||
Meta
|
||||
Head Head
|
||||
Head Head
|
||||
Flash *Flash
|
||||
|
||||
Danger Box
|
||||
Intro Text
|
||||
@@ -362,6 +363,8 @@ type UserDeleteInput struct {
|
||||
AllInbound bool
|
||||
Outbound []string
|
||||
Inbound []string
|
||||
// Error is a refusal of the confirmation (a wrong account password).
|
||||
Error string
|
||||
}
|
||||
|
||||
// NewUserDelete builds the page.
|
||||
@@ -384,6 +387,9 @@ func NewUserDelete(m Meta, in UserDeleteInput) *UserDelete {
|
||||
Confirm: "Delete " + in.Username,
|
||||
KeepHref: href,
|
||||
}
|
||||
if in.Error != "" {
|
||||
p.Flash = &Flash{Error: true, Text: Plain(in.Error)}
|
||||
}
|
||||
if in.Global {
|
||||
p.Consequences = append(p.Consequences, Plain("remove their global access to the server and to every domain."))
|
||||
return p
|
||||
|
||||
Reference in New Issue
Block a user