Verified the tree against docs/plans/code-review-2026-08.md and finished the tasks that were only partly done, plus two defects the pass introduced. - bcrypt: the setup account was still hashed at DefaultCost (10). The work factor now has one definition, auth.BcryptCost = 12, used everywhere. - rate limiter: protecting blocked buckets from eviction was unbounded — an attacker with many source addresses could grow the map by making each one fail its way to blocked. Blocked buckets are now evicted past maxBuckets * 4, nearest expiry first, logged once per window. Tests cover both halves. - postqueue: the 5s timeout left the output size unbounded; reads are now capped at 4 MiB and report truncation. - spec references: the ~76 `spec N` citations CHANGELOG [0.5.0] claimed were gone are removed from build/, deploy/, the first two migrations and the release workflow, with the affected comment paragraphs re-wrapped. Comments only; shell/YAML/SQL syntax re-checked. - schema-migrations.md: schema section was headed v9 with the chain at v10, and three links pointed at deleted plan files. - internal/configsafe: the shared empty/forbidden-character check behind the OpenDKIM and Postfix config writers; each writer keeps its own forbidden set. - dropped the parseDomainRateLimitForm/parseAppRateLimitForm pass-throughs left behind by the parser merge (only their own tests still called them). - plan doc now carries a status table: what shipped, what was already in place, what was declined (//go:build linux for the /proc reader) and the open CSRF-token question. Not done, each its own phase: typed template data structs, log/slog, DMARC service and handler tests, error-page/corrupted-backup tests, backup re-auth. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
package auth
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
@@ -123,3 +124,53 @@ func TestRateLimiterCapsBucketCount(t *testing.T) {
|
||||
t.Fatalf("bucket count = %d, want at most 3", len(r.buckets))
|
||||
}
|
||||
}
|
||||
|
||||
// A flood of new addresses must not be able to reset the limiter for an address
|
||||
// that is already blocked: below the hard ceiling, blocked buckets survive
|
||||
// eviction even though the map is over its soft cap.
|
||||
func TestRateLimiterKeepsBlockedBucketsUnderPressure(t *testing.T) {
|
||||
r := newRateLimiter(2, time.Minute)
|
||||
r.maxBuckets = 3
|
||||
|
||||
blocked := []string{"203.0.113.7", "198.51.100.9", "192.0.2.5"}
|
||||
for _, key := range blocked {
|
||||
for i := 0; i < 2; i++ {
|
||||
if !r.Allow(key) {
|
||||
t.Fatalf("%s refused before reaching the limit", key)
|
||||
}
|
||||
}
|
||||
if r.Allow(key) {
|
||||
t.Fatalf("%s was not blocked after 2 attempts", key)
|
||||
}
|
||||
}
|
||||
|
||||
// Fresh addresses arrive and find nothing evictable.
|
||||
for i := 0; i < 10; i++ {
|
||||
r.Allow(fmt.Sprintf("198.51.100.%d", 100+i))
|
||||
}
|
||||
|
||||
for _, key := range blocked {
|
||||
if r.Allow(key) {
|
||||
t.Fatalf("%s lost its block after new addresses arrived", key)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Protecting blocked buckets is bounded: past maxBuckets * blockedBucketCeiling
|
||||
// they are evicted too, so an attacker cannot grow the map without limit by
|
||||
// burning through source addresses.
|
||||
func TestRateLimiterBoundsBlockedBuckets(t *testing.T) {
|
||||
r := newRateLimiter(1, time.Minute)
|
||||
r.maxBuckets = 2
|
||||
hardCap := r.maxBuckets * blockedBucketCeiling
|
||||
|
||||
for i := 0; i < 100; i++ {
|
||||
r.Allow(fmt.Sprintf("192.0.2.%d", i))
|
||||
}
|
||||
|
||||
r.mu.Lock()
|
||||
defer r.mu.Unlock()
|
||||
if len(r.buckets) > hardCap {
|
||||
t.Fatalf("bucket count = %d, want at most the hard cap %d", len(r.buckets), hardCap)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user