audit 4: log paging at its edges, NaN refused, a red rate limit, recalculation asks, reload writes all
test / test (push) Canceled after 0s
test / test (push) Canceled after 0s
Step 4 of stage 4 (L10, L11, L13, L18, L19 and a row of
review-2026-08-followups):
- The Outbound log counts first and clamps the page to the last; a number
too large for an int (strconv's ErrRange with the largest int) is the
last page on both logs. Tested at the edges: first, last, past the last
however far, nonsense, an empty log asked for page 5.
- checkAutoMultiplier is "not within", so NaN and the infinities are out.
- rate-limited is red (components.go; the mockup first, 643892a).
- data-unsaved on both recalculate buttons: panel.js asks on submit
(ev.submitter) when a field of the page differs from what it was drawn
with; testdata/unsaved_test.js under TestPanelJS.
- HandleReload writes what a restore's first start writes - the filter
lists and the DMARC maps too - and a failed step is an error flash on
Health that names it, not plain text; the success flash says what was
written.
Tested on the test server: go vet + go test of 25 packages, make e2e (all
pass, 695 s) on this tree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -50,8 +50,11 @@ func parseAutoMultiplier(raw string) (float64, error) {
|
||||
|
||||
// checkAutoMultiplier is the rule for an auto limit's multiplier, shared by
|
||||
// the form and a domain import.
|
||||
// Written as "not within" so NaN, which compares false with everything, is
|
||||
// outside too: ParseFloat reads "NaN" (audit 2026-10-12, L11 - stored as NULL,
|
||||
// read back as 0, recalculated as the default without a word).
|
||||
func checkAutoMultiplier(v float64) error {
|
||||
if v < store.MinAutoMultiplier || v > store.MaxAutoMultiplier {
|
||||
if !(v >= store.MinAutoMultiplier && v <= store.MaxAutoMultiplier) {
|
||||
return fmt.Errorf("multiplier must be between %.1f and %.1f", store.MinAutoMultiplier, store.MaxAutoMultiplier)
|
||||
}
|
||||
return nil
|
||||
|
||||
Reference in New Issue
Block a user