mix/selfpost
1
0
Fork 0
Code Issues Pull Requests Actions 10 Packages Projects Releases Wiki Activity

entrypoint: no link followed at the DMARC maps (audit I2)

Browse Source 
Security audit 2026-10-17, finding I2 (= M4), stage 0. drop_links listed
the outbound maps, sasldb2, the key tree and mail.log but not the three
DMARC maps that postfix-config.sh creates as root with `[ -e ] || : >`
when DMARC_REPORTS_ENABLE=true; -e is false for a dangling link and the
redirect follows it, and /data/postfix is the panel's. Now the three are in
drop_links, and both map loops refuse to create through a link
(`[ -e ] || [ -L ] || : >`).

e2e: TestStartsOnA28Data plants a dangling /data/postfix/dmarc_transport
with DMARC reports on and expects the "removing the symbolic link" line,
no file at the link's target, and a regular map. To be run on the server
with the stage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
mix
2026-10-17 21:30:03 +03:00
co-authored by Claude Opus 5.5
parent a37aba6594
commit f2ef705470
5 changed files with 28 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/e2e/upgrade_test.go
+15 -1
View File
@@ -95,6 +95,14 @@ func TestStartsOnA28Data(t *testing.T) {
t.Fatalf("generate throwaway TLS cert: %v", err)
}
// A dangling link where root creates an empty DMARC map: the panel owns
// /data/postfix and could plant one. The entrypoint removes it and
// creates nothing at its target (audit 2026-10-17, I2).
const planted = "/etc/selfpost-planted-by-the-panel"
if err := os.Symlink(planted, filepath.Join(dataDir, "postfix", "dmarc_transport")); err != nil {
t.Fatal(err)
}
name := "selfpost-e2e-upgrade"
_ = exec.Command("docker", "rm", "-f", name).Run()
defer func() {
@@ -103,7 +111,7 @@ func TestStartsOnA28Data(t *testing.T) {
_ = exec.Command("docker", "rm", "-f", name).Run()
}()
if out, err := exec.Command("docker", "run", "-d", "--name", name,
"-e", "SELFPOST_HOSTNAME="+host, "-e", "MILTER_WAIT_TIMEOUT=10",
"-e", "SELFPOST_HOSTNAME="+host, "-e", "MILTER_WAIT_TIMEOUT=10", "-e", "DMARC_REPORTS_ENABLE=true",
"-v", dataDir+":/data", "-v", certDir+":/etc/postfix/tls:ro",
"selfpost:e2e").CombinedOutput(); err != nil {
t.Fatalf("docker run: %v\n%s", err, out)
@@ -147,6 +155,12 @@ func TestStartsOnA28Data(t *testing.T) {
// its postrotate asks no reload of a Postfix not running yet (the test
// server's rollout of 2026-10-16 logged "fatal: the Postfix mail system
// is not running"; build/logrotate-mail.conf).
if !strings.Contains(logs(), "entrypoint: removing the symbolic link /data/postfix/dmarc_transport") {
t.Errorf("the entrypoint did not remove the planted link:\n%s", logs())
}
if got := exec1(`test -e ` + planted + ` && echo created || echo absent; test -f /data/postfix/dmarc_transport && ! test -L /data/postfix/dmarc_transport && echo file`); got != "absent\nfile" {
t.Errorf("planted link: %q, want the target absent and the map a regular file", got)
}
if got := exec1(`test -f /data/log/mail.log.1 && echo rotated`); got != "rotated" {
t.Errorf("the rotation due at the start did not run: %q", got)
}