Files
mixandClaude Opus 5.5 eaa7de0754
test / test (push) Canceled after 0s
audit 4: findings of the two reviews
- Two inbound domains on one upstream could never change its TLS mode,
  each save refused for the other (medium): SetTransportAs changes the
  mode for every domain on the upstream when the one saving may change
  them all; a domain user who may not is refused with the mode, not the
  other tenant's domain name (security F1: the first version named it).
- A deletion's leftover DKIM key is removed by Resync (Reload
  configuration, a restore's first start) for names no domain has.
- The backup's write deadline moves before Check.
- hasUnsavedEdit skips password and file fields and compares a multiple
  select's options; htmx.config.timeout 30 s, so a refresh never answered
  ends and is tried again; a failed refresh's promise is handled.
- An empty filtered Outbound log says no message matches the filters.
- The dummy bcrypt hash is made at start; a DMARC part over 8 MiB is
  refused for its size like the other two limits.
- Health's Configuration box says what Reload writes (design first,
  32dfe4a).
- Docs: CHANGELOG, guide § Inbound, security.md (the shared upstream's
  mode, the profile form's "username taken"), architecture.md (owed to an
  address), the plan's notes corrected.
Tests: the shared upstream (service, handler), the leftover key, all eight
Health boxes ordered, the subject from before migration 0011, the new JS
cases.

Tested on the test server: go vet + go test of 25 packages, make e2e (all
pass, 636 s) on this tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 12:46:52 +03:00

153 lines
6.1 KiB
JavaScript

// The polling of panel.js, run in node against a stand-in for the few parts
// of the DOM and htmx it uses, with a clock the test moves. Run by
// TestPanelJS (paneljs_test.go): node poll_test.js <panel.js>.
// Exits non-zero with what went wrong.
"use strict";
const fs = require("fs");
const vm = require("vm");
const failures = [];
function check(cond, what) {
if (!cond) failures.push(what);
}
// --- the clock ------------------------------------------------------------
let now = 1000000;
let timers = [];
let nextTimer = 1;
function setTimeout(fn, ms) {
const id = nextTimer++;
timers.push({ id, at: now + ms, ms, fn });
return id;
}
function clearTimeout(id) {
timers = timers.filter((t) => t.id !== id);
}
function pendingDelays() {
return timers.map((t) => t.ms);
}
function advance(ms) {
now += ms;
const due = timers.filter((t) => t.at <= now);
timers = timers.filter((t) => t.at > now);
due.forEach((t) => t.fn());
}
const FakeDate = { now: () => now };
// --- the page ---------------------------------------------------------------
function element(id, attrs) {
return {
id,
attrs: Object.assign({}, attrs),
hasAttribute(n) { return n in this.attrs; },
getAttribute(n) { return n in this.attrs ? this.attrs[n] : null; },
removeAttribute(n) { delete this.attrs[n]; },
};
}
const listeners = { document: {}, body: {}, window: {} };
function on(where) {
return (type, fn) => {
(listeners[where][type] = listeners[where][type] || []).push(fn);
};
}
let inPage = {};
const document = {
hidden: false,
addEventListener: on("document"),
body: { addEventListener: on("body") },
getElementById: (id) => inPage[id] || null,
querySelectorAll: (sel) => (sel === "[data-poll]" ? Object.values(inPage).filter((e) => e.hasAttribute("data-poll")) : []),
};
const window = { addEventListener: on("window"), confirm: () => true };
const requests = [];
const htmx = {
config: {},
ajax(verb, path, ctx) {
requests.push({ verb, path, ctx });
},
};
// The operator moved the mouse: the page counts as in use for 30 s.
function activity() {
(listeners.document.mousemove || []).forEach((fn) => fn({}));
}
function fireBody(type, detail) {
(listeners.body[type] || []).forEach((fn) => fn({ type, detail, target: detail.elt }));
}
vm.runInNewContext(fs.readFileSync(process.argv[2], "utf8"), {
document, window, htmx, setTimeout, clearTimeout, Date: FakeDate,
Object, Math, console,
});
// --- the cases --------------------------------------------------------------
// A request that never ends is ended: htmx's default is no timeout.
check(htmx.config.timeout === 30000, "htmx.config.timeout is " + htmx.config.timeout + ", want 30000");
const box = element("overview-stats", { "data-poll": "", "hx-get": "/overview/stats", "hx-trigger": "load" });
inPage = { [box.id]: box };
// The first load ended well: the next refresh in 5 s, as the box's source.
fireBody("htmx:afterRequest", { target: box, elt: box, successful: true });
check(pendingDelays().join() === "5000", "after a refresh that worked: waits " + pendingDelays() + ", want 5000");
advance(5000);
check(requests.length === 1, "no refresh was asked for after 5 s");
check(requests[0] && requests[0].ctx.source === box, "the refresh does not name the box as its source");
check(requests[0] && requests[0].ctx.target === "#overview-stats", "the refresh targets " + (requests[0] && requests[0].ctx.target));
// Failures in a row - an error answer, a dropped connection, a timeout -
// each double the wait, up to a minute; a refresh is always scheduled.
const waits = [];
for (let i = 0; i < 5; i++) {
activity();
fireBody("htmx:afterRequest", { target: box, elt: box, successful: i === 0 ? false : undefined });
waits.push(pendingDelays().join());
advance(Number(pendingDelays()[0] || 0));
}
check(waits.join(" ") === "10000 20000 40000 60000 60000", "the waits after failures in a row: " + waits.join(" ") + ", want 10000 20000 40000 60000 60000");
check(requests.length === 6, "refreshes asked for: " + requests.length + ", want one per wait");
// One that works puts the wait back.
activity();
fireBody("htmx:afterRequest", { target: box, elt: box, successful: true });
check(pendingDelays().join() === "5000", "after failures and a success: waits " + pendingDelays() + ", want 5000");
// A swap replaced the box: the event that reaches the body comes from a
// parent and names the old box as its target; the new one is scheduled.
timers = [];
const fresh = element("overview-stats", { "data-poll": "", "hx-get": "/overview/stats", "hx-trigger": "load" });
inPage = { [fresh.id]: fresh };
fireBody("htmx:afterSwap", { elt: fresh });
check(!fresh.hasAttribute("hx-trigger"), "the swapped-in box keeps hx-trigger");
activity();
fireBody("htmx:afterRequest", { target: box, elt: { id: "main" }, successful: true });
check(pendingDelays().join() === "5000", "after a swap: waits " + pendingDelays() + ", want 5000");
advance(5000);
check(requests[requests.length - 1].ctx.source === fresh, "the refresh after a swap is not the new box's");
// Idle for longer than 30 s: 30 s between refreshes, doubled from there.
timers = [];
now += 31000;
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: true });
check(pendingDelays().join() === "30000", "idle: waits " + pendingDelays() + ", want 30000");
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: false });
check(pendingDelays().join() === "60000", "idle, one failure: waits " + pendingDelays() + ", want 60000");
// A hidden tab schedules nothing.
timers = [];
document.hidden = true;
fireBody("htmx:afterRequest", { target: fresh, elt: fresh, successful: true });
check(timers.length === 0, "a hidden tab scheduled a refresh");
document.hidden = false;
// A request of something that is not a polled box is not its business.
timers = [];
inPage.other = element("other", {});
fireBody("htmx:afterRequest", { target: inPage.other, elt: inPage.other, successful: true });
check(timers.length === 0, "a request of a box that does not poll scheduled a refresh");
if (failures.length) {
console.log(failures.join("\n"));
process.exit(1);
}
console.log("ok");