Files
mixandClaude Opus 5.5 49c872f836 backup-reauth: the account password before a backup or an export
Agreed with the owner on 2026-10-13, taken up on 2026-10-16 ("Да"); the
mockup is 1888dce. Both secret downloads - the full backup on Server ›
Backup and a domain's export on its settings - ask for "Your account
password": reauth (handlers_backup.go) checks the signed-in user's own
password with bcrypt, as a password change does, under the same limiter
(auth.AllowPasswordChange: ten in fifteen minutes per user, shared with the
Account form). A wrong or missing one is 401 on the same page with "Your
account password is incorrect.", logged; nothing is sent. The import and
the selfpost-backup CLI are not asked.

Also, the owner's phone screenshot of 2026-10-16 ("кнопка выбора файла не
такая, как в макете. Это косяк?"): the import's file field was a bare
<input type="file"> drawn by the browser ("Browse…"), where the mockup has
Bulma's .file - "Choose a file…" and the name chosen. The template now
follows the mockup; panel.js writes the name into .file-name on change and
at load (testdata/filename_test.js, run by TestPanelJS). No other file
field exists.

Tests: TestSecretDownloadsAskForTheAccountPassword (missing, wrong, right,
the limiter), the export refusals of the settings page with the password,
cmd/panel's restore tests and e2e's backups with it, e2e's refusal of a
backup without and with a wrong password. go vet + go test (26 packages)
and make e2e on the test server for this tree.

Docs: security.md § Backup and domain export, guide § Full backup and
restore, help (word for word with the mockup); CHANGELOG [Unreleased];
roadmap row done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 22:39:13 +03:00

105 lines
3.4 KiB
Go

package e2e
import (
"bytes"
"net/url"
"os"
"path/filepath"
"strings"
"testing"
"time"
)
// testCertbotLayout: certs/ as the guide now has an operator leave it with
// certbot - two links into /etc/letsencrypt/live/<host>/, whose files are
// relative links into archive/ - and /etc/letsencrypt mounted at the same
// path (compose.override.yml mounts the stage's ./letsencrypt there). Postfix
// serves the certificate the links lead to, Health shows it with nothing
// waiting, and a full backup carries the files, not the links (assumptions
// C-A1, C-Q4). Until 2.5.2 the guide had certs/ linked to live/<host>, and
// the container got links into a directory it did not have.
func testCertbotLayout(t *testing.T, sc *scenario) {
le := filepath.Join(h.stageDir, "letsencrypt")
archive := filepath.Join(le, "archive", selfpostHostname)
live := filepath.Join(le, "live", selfpostHostname)
for _, d := range []string{archive, live} {
if err := os.MkdirAll(d, 0o755); err != nil {
t.Fatal(err)
}
}
// A new pair, so what is served afterwards can only have come through
// the links.
if err := writeSelfSignedCert(filepath.Join(archive, "fullchain1.pem"), filepath.Join(archive, "privkey1.pem")); err != nil {
t.Fatal(err)
}
certs := filepath.Join(h.stageDir, "certs")
for _, f := range []string{"fullchain", "privkey"} {
link := filepath.Join(live, f+".pem")
_ = os.Remove(link)
if err := os.Symlink("../../archive/"+selfpostHostname+"/"+f+"1.pem", link); err != nil {
t.Fatal(err)
}
mounted := filepath.Join(certs, f+".pem")
if err := os.Remove(mounted); err != nil {
t.Fatal(err)
}
if err := os.Symlink("/etc/letsencrypt/live/"+selfpostHostname+"/"+f+".pem", mounted); err != nil {
t.Fatal(err)
}
}
if err := h.recreateSelfpost(); err != nil {
t.Fatalf("recreate selfpost over certbot's layout: %v", err)
}
if err := waitForPanelReady(); err != nil {
t.Fatalf("%v\n%s", err, h.logs("selfpost"))
}
if err := waitForSMTPSReady(60 * time.Second); err != nil {
t.Fatalf("%v\n%s", err, h.logs("selfpost"))
}
want, err := fileSerial(filepath.Join(archive, "fullchain1.pem"))
if err != nil {
t.Fatal(err)
}
got, err := servedSerial()
if err != nil {
t.Fatal(err)
}
if got.Cmp(want) != 0 {
t.Fatalf("port 465 serves serial %s, want %s, the certificate certs/ links to", got, want)
}
_, body, err := sc.panel.get("/server/health")
if err != nil {
t.Fatal(err)
}
if strings.Contains(body, "<dt>Renewal expires</dt>") {
t.Fatalf("Health names a renewal waiting, but Postfix serves what certs/ leads to")
}
resp, archived, err := sc.panel.postForm("/server/backup", url.Values{"account_password": {adminPassword}})
if err != nil || resp.StatusCode != 200 {
t.Fatalf("full backup over certbot's layout: %v, status %v\n%.600s", err, resp, archived)
}
dir := t.TempDir()
names, err := untar(dir, []byte(archived))
if err != nil {
t.Fatal(err)
}
for _, f := range []string{"fullchain", "privkey"} {
name := "certs/" + f + ".pem"
if !names[name] {
t.Fatalf("the backup has no %s", name)
}
fi, err := os.Lstat(filepath.Join(dir, name))
if err != nil || !fi.Mode().IsRegular() {
t.Fatalf("%s in the backup: %v, %v; want the file, not a link", name, fi, err)
}
inBackup, _ := os.ReadFile(filepath.Join(dir, name))
original, _ := os.ReadFile(filepath.Join(archive, f+"1.pem"))
if !bytes.Equal(inBackup, original) {
t.Fatalf("%s in the backup is not the file certbot's link leads to", name)
}
}
}