7b4549a35d
Phase 13. Two new packages and one new screen. internal/health owns the shared status vocabulary (ok/warn/error/unknown) and the local checks: supervisord's process table, TLS certificate expiry and the two milter sockets. Each check reports a problem as a status rather than an error, so one broken component costs a line and not the page. internal/dnscheck does the read-only lookups: forward-confirmed reverse DNS for SELFPOST_HOSTNAME, and per-domain DKIM (compared against the key this server actually signs with), SPF and DMARC. Every check is bounded by a timeout and cached, and the resolver sits behind an interface so the tests drive every branch without touching the network. The SPF check is deliberately shallow: it looks for a mechanism literally covering the server's address and does not follow include:/redirect=, so a record that authorises us through an include is reported as "cannot tell" rather than as a failure. /status renders both, with the local checks in an HTMX-polled fragment and the DNS lookups behind a Re-check button, and becomes the panel's landing page: / now redirects there and the domain list lives at /domains. The Reload button moves onto /status, where it reads as what it is — a drift-recovery for the daemons — with text explaining what it regenerates. A template test fails on any remaining href="/" so a stale link cannot silently land on the wrong screen. Also fixes a defect this made visible: the panel could never read the mail queue in the documented deployment. postqueue relies on its setgid-postdrop bit, which the compose file's no-new-privileges disables, so the Queue screen always said "Could not read the mail queue" — including in the released 1.0.0 image. The panel user is now a real member of postdrop, which needs no setgid transition. Verified in a container on the dev server against real DNS: PTR matching (selfpost.example.com) and not matching (example.com), DKIM absent and mismatched, SPF absent and via include:, DMARC p=quarantine/p=reject/absent, and a resolver timeout degrading to "unknown" without hanging the page. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
166 lines
5.5 KiB
Go
166 lines
5.5 KiB
Go
package web
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strconv"
|
|
|
|
"codeberg.org/mix/selfpost/internal/store"
|
|
)
|
|
|
|
// handleDashboard is the authenticated landing page: the list of sending
|
|
// domains with their DKIM/selector and application counts, plus the add-domain
|
|
// form (spec 7.2.2). Applications and the send log arrive in later phases.
|
|
func (s *Server) handleDashboard(w http.ResponseWriter, r *http.Request) {
|
|
s.renderDashboard(w, r, http.StatusOK, "", "")
|
|
}
|
|
|
|
// renderDashboard renders the domain list. formErr and formName repopulate the
|
|
// add-domain form after a rejected submission; flash surfaces a one-shot status
|
|
// message keyed by a redirect query flag (never reflected user input).
|
|
func (s *Server) renderDashboard(w http.ResponseWriter, r *http.Request, status int, formErr, formName string) {
|
|
domains, err := s.domains.List()
|
|
if err != nil {
|
|
logf("panel: dashboard: list domains: %v", err)
|
|
http.Error(w, "internal error", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
s.render(w, status, "dashboard", map[string]any{
|
|
"Title": "SelfPost",
|
|
"User": currentUser(r),
|
|
"Active": "domains",
|
|
"Domains": domains,
|
|
"Error": formErr,
|
|
"FormName": formName,
|
|
"Flash": dashboardFlash(r),
|
|
})
|
|
}
|
|
|
|
// dashboardFlash maps a fixed redirect flag to a fixed message, so status text
|
|
// after a redirect is never attacker-influenced.
|
|
func dashboardFlash(r *http.Request) string {
|
|
if r.URL.Query().Get("deleted") != "" {
|
|
return "Domain deleted."
|
|
}
|
|
return ""
|
|
}
|
|
|
|
// handleAddDomain validates the submitted name, creates the domain (DKIM key +
|
|
// OpenDKIM reload), and redirects to the domain's page so the DNS record to
|
|
// publish is shown (spec 7.2.3).
|
|
func (s *Server) handleAddDomain(w http.ResponseWriter, r *http.Request) {
|
|
if err := r.ParseForm(); err != nil {
|
|
s.renderDashboard(w, r, http.StatusBadRequest, "Invalid form submission.", "")
|
|
return
|
|
}
|
|
raw := r.PostFormValue("name")
|
|
name := normalizeDomain(raw)
|
|
if err := validateDomain(name); err != nil {
|
|
s.renderDashboard(w, r, http.StatusBadRequest, err.Error(), raw)
|
|
return
|
|
}
|
|
|
|
d, err := s.domains.Add(name)
|
|
if err != nil {
|
|
if errors.Is(err, store.ErrDomainExists) {
|
|
s.renderDashboard(w, r, http.StatusConflict, "That domain is already configured.", raw)
|
|
return
|
|
}
|
|
logf("panel: add domain %q: %v", name, err)
|
|
s.renderDashboard(w, r, http.StatusInternalServerError,
|
|
"Could not add the domain. Please check the logs and try again.", raw)
|
|
return
|
|
}
|
|
http.Redirect(w, r, fmt.Sprintf("/domains/%d", d.ID), http.StatusSeeOther)
|
|
}
|
|
|
|
// handleDeleteConfirm shows the cascade warning before a domain is removed: the
|
|
// panel must explicitly state that all bound applications go with it (spec 7.2.4).
|
|
func (s *Server) handleDeleteConfirm(w http.ResponseWriter, r *http.Request) {
|
|
d, ok := s.lookupDomain(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
s.render(w, http.StatusOK, "domain_delete", map[string]any{
|
|
"Title": "SelfPost — delete " + d.Name,
|
|
"User": currentUser(r),
|
|
"Active": "domains",
|
|
"Domain": d,
|
|
})
|
|
}
|
|
|
|
// handleDeleteDomain performs the deletion (cascade + DKIM key + OpenDKIM reload)
|
|
// and returns to the domain list.
|
|
func (s *Server) handleDeleteDomain(w http.ResponseWriter, r *http.Request) {
|
|
id, ok := parseDomainID(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
// Drop any cached DNS verdict for the name while it is still resolvable, so
|
|
// re-adding the domain later starts from a fresh check instead of a stale
|
|
// one from before it was removed.
|
|
if d, err := s.domains.Get(id); err == nil {
|
|
defer s.dns.Forget(d.Name)
|
|
}
|
|
if err := s.domains.Delete(id); err != nil {
|
|
if errors.Is(err, store.ErrDomainNotFound) {
|
|
http.NotFound(w, r)
|
|
return
|
|
}
|
|
logf("panel: delete domain %d: %v", id, err)
|
|
http.Error(w, "internal error", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
http.Redirect(w, r, "/domains?deleted=1", http.StatusSeeOther)
|
|
}
|
|
|
|
// handleReload re-applies both the OpenDKIM configuration and the Postfix
|
|
// sender map on demand (spec 7.2.12). Each Resync regenerates its files from the
|
|
// database and reloads its daemon, so the button doubles as a drift-recovery.
|
|
// The button lives on the status page (phase 13.D): it is a "put the daemons
|
|
// back in the state the database describes" action, which belongs with the rest
|
|
// of the server-health screen rather than in the domain list's top bar.
|
|
func (s *Server) handleReload(w http.ResponseWriter, r *http.Request) {
|
|
if err := s.domains.Resync(); err != nil {
|
|
logf("panel: manual reload (opendkim): %v", err)
|
|
http.Error(w, "reload failed", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
if err := s.apps.Resync(); err != nil {
|
|
logf("panel: manual reload (postfix): %v", err)
|
|
http.Error(w, "reload failed", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
http.Redirect(w, r, "/status?reloaded=1", http.StatusSeeOther)
|
|
}
|
|
|
|
// lookupDomain resolves the {id} path value to a domain, writing a 404 for a
|
|
// bad id or a missing domain and reporting ok=false in that case.
|
|
func (s *Server) lookupDomain(w http.ResponseWriter, r *http.Request) (store.Domain, bool) {
|
|
id, ok := parseDomainID(w, r)
|
|
if !ok {
|
|
return store.Domain{}, false
|
|
}
|
|
d, err := s.domains.Get(id)
|
|
if err != nil {
|
|
if errors.Is(err, store.ErrDomainNotFound) {
|
|
http.NotFound(w, r)
|
|
return store.Domain{}, false
|
|
}
|
|
logf("panel: get domain %d: %v", id, err)
|
|
http.Error(w, "internal error", http.StatusInternalServerError)
|
|
return store.Domain{}, false
|
|
}
|
|
return d, true
|
|
}
|
|
|
|
func parseDomainID(w http.ResponseWriter, r *http.Request) (int64, bool) {
|
|
id, err := strconv.ParseInt(r.PathValue("id"), 10, 64)
|
|
if err != nil || id <= 0 {
|
|
http.NotFound(w, r)
|
|
return 0, false
|
|
}
|
|
return id, true
|
|
}
|