test / test (push) Has been cancelled
Verified the tree against docs/plans/code-review-2026-08.md and finished the tasks that were only partly done, plus two defects the pass introduced. - bcrypt: the setup account was still hashed at DefaultCost (10). The work factor now has one definition, auth.BcryptCost = 12, used everywhere. - rate limiter: protecting blocked buckets from eviction was unbounded — an attacker with many source addresses could grow the map by making each one fail its way to blocked. Blocked buckets are now evicted past maxBuckets * 4, nearest expiry first, logged once per window. Tests cover both halves. - postqueue: the 5s timeout left the output size unbounded; reads are now capped at 4 MiB and report truncation. - spec references: the ~76 `spec N` citations CHANGELOG [0.5.0] claimed were gone are removed from build/, deploy/, the first two migrations and the release workflow, with the affected comment paragraphs re-wrapped. Comments only; shell/YAML/SQL syntax re-checked. - schema-migrations.md: schema section was headed v9 with the chain at v10, and three links pointed at deleted plan files. - internal/configsafe: the shared empty/forbidden-character check behind the OpenDKIM and Postfix config writers; each writer keeps its own forbidden set. - dropped the parseDomainRateLimitForm/parseAppRateLimitForm pass-throughs left behind by the parser merge (only their own tests still called them). - plan doc now carries a status table: what shipped, what was already in place, what was declined (//go:build linux for the /proc reader) and the open CSRF-token question. Not done, each its own phase: typed template data structs, log/slog, DMARC service and handler tests, error-page/corrupted-backup tests, backup re-auth. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
110 lines
3.7 KiB
Go
110 lines
3.7 KiB
Go
package postfix
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"os/exec"
|
|
"regexp"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
const postqueueTimeout = 5 * time.Second
|
|
|
|
// maxQueueOutput bounds how much of `postqueue -p` the panel keeps. A deferred
|
|
// queue with a very large backlog prints one paragraph per message, and the
|
|
// whole listing is held in memory and then rendered into a page — so the read
|
|
// is capped and the remainder reported as truncated rather than being allowed
|
|
// to size the panel's memory by the size of the queue.
|
|
const maxQueueOutput = 4 << 20
|
|
|
|
// limitWriter keeps the first remaining bytes written to it and drops the rest,
|
|
// recording that it did. Writes always report full consumption so postqueue is
|
|
// never killed by a short write; the extra output is simply discarded.
|
|
type limitWriter struct {
|
|
buf bytes.Buffer
|
|
remaining int
|
|
truncated bool
|
|
}
|
|
|
|
func (l *limitWriter) Write(p []byte) (int, error) {
|
|
keep := len(p)
|
|
if keep > l.remaining {
|
|
keep = l.remaining
|
|
l.truncated = true
|
|
}
|
|
if keep > 0 {
|
|
l.buf.Write(p[:keep])
|
|
l.remaining -= keep
|
|
}
|
|
return len(p), nil
|
|
}
|
|
|
|
// Queue returns Postfix's own human-readable mail-queue listing
|
|
// (architecture.md § Panel HTTP surface): active, deferred and held messages,
|
|
// exactly as an administrator would see via the CLI. The command takes a
|
|
// single fixed flag and no user input, so it never goes through a shell
|
|
// (security.md). The panel is responsible for escaping the output before
|
|
// display (security.md); this function returns it as-is.
|
|
func Queue() (string, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), postqueueTimeout)
|
|
defer cancel()
|
|
cmd := exec.CommandContext(ctx, "postqueue", "-p")
|
|
out := &limitWriter{remaining: maxQueueOutput}
|
|
cmd.Stdout = out
|
|
cmd.Stderr = out
|
|
err := cmd.Run()
|
|
if ctx.Err() == context.DeadlineExceeded {
|
|
return "", fmt.Errorf("postqueue -p timed out after %s", postqueueTimeout)
|
|
}
|
|
if err != nil {
|
|
return "", fmt.Errorf("postqueue -p: %w: %s", err, strings.TrimSpace(out.buf.String()))
|
|
}
|
|
text := out.buf.String()
|
|
if out.truncated {
|
|
text += fmt.Sprintf("\n[listing truncated at %d bytes]\n", maxQueueOutput)
|
|
}
|
|
return text, nil
|
|
}
|
|
|
|
// QueueIDs returns the set of queue ids Postfix is still holding — everything
|
|
// in the maildrop, incoming, active, deferred and hold queues. It answers the
|
|
// one question the log-tailer's reconcile sweep asks about a send-log row stuck
|
|
// at "queued": is Postfix still working on this message, or has it left the
|
|
// queue without the panel ever seeing a delivery line for it (architecture.md §
|
|
// Log tailer)?
|
|
//
|
|
// An error means the queue could not be listed and therefore says nothing about
|
|
// any message; the caller must treat it as "no information", never as an empty
|
|
// queue.
|
|
func QueueIDs() (map[string]struct{}, error) {
|
|
out, err := Queue()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return parseQueueIDs(out), nil
|
|
}
|
|
|
|
// queueEntryRe matches the first line of a `postqueue -p` entry, e.g.
|
|
//
|
|
// 3C5B04E6C1* 446 Thu Aug 7 10:12:31 app@example.com
|
|
//
|
|
// The id is at the start of the line, optionally flagged '*' (in the active
|
|
// queue) or '!' (on hold), and is followed by the message size. Requiring the
|
|
// size is what separates an entry from the listing's other left-margin lines:
|
|
// the '-Queue ID-' header, the '-- 5 Kbytes in 2 Requests.' trailer, a deferred
|
|
// entry's '(connect timed out)' reason, and 'Mail queue is empty'. Recipient
|
|
// lines are indented and never match.
|
|
var queueEntryRe = regexp.MustCompile(`^([0-9A-Za-z]+)[*!]?\s+\d+\s`)
|
|
|
|
func parseQueueIDs(listing string) map[string]struct{} {
|
|
ids := make(map[string]struct{})
|
|
for _, line := range strings.Split(listing, "\n") {
|
|
if m := queueEntryRe.FindStringSubmatch(line); m != nil {
|
|
ids[m[1]] = struct{}{}
|
|
}
|
|
}
|
|
return ids
|
|
}
|