mixandClaude Opus 5
ab2cd885c4
test / test (push) Has been cancelled
Verified the tree against docs/plans/code-review-2026-08.md and finished the tasks that were only partly done, plus two defects the pass introduced. - bcrypt: the setup account was still hashed at DefaultCost (10). The work factor now has one definition, auth.BcryptCost = 12, used everywhere. - rate limiter: protecting blocked buckets from eviction was unbounded — an attacker with many source addresses could grow the map by making each one fail its way to blocked. Blocked buckets are now evicted past maxBuckets * 4, nearest expiry first, logged once per window. Tests cover both halves. - postqueue: the 5s timeout left the output size unbounded; reads are now capped at 4 MiB and report truncation. - spec references: the ~76 `spec N` citations CHANGELOG [0.5.0] claimed were gone are removed from build/, deploy/, the first two migrations and the release workflow, with the affected comment paragraphs re-wrapped. Comments only; shell/YAML/SQL syntax re-checked. - schema-migrations.md: schema section was headed v9 with the chain at v10, and three links pointed at deleted plan files. - internal/configsafe: the shared empty/forbidden-character check behind the OpenDKIM and Postfix config writers; each writer keeps its own forbidden set. - dropped the parseDomainRateLimitForm/parseAppRateLimitForm pass-throughs left behind by the parser merge (only their own tests still called them). - plan doc now carries a status table: what shipped, what was already in place, what was declined (//go:build linux for the /proc reader) and the open CSRF-token question. Not done, each its own phase: typed template data structs, log/slog, DMARC service and handler tests, error-page/corrupted-backup tests, backup re-auth. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
75 lines
2.6 KiB
Go
75 lines
2.6 KiB
Go
package postfix
|
|
|
|
import "testing"
|
|
|
|
// The reconcile sweep decides whether a message is still Postfix's problem, so
|
|
// the parser must pick queue ids out of a real listing and nothing else out of
|
|
// it: not the header, not the byte-count trailer, and above all not a deferred
|
|
// entry's reason line, which — unlike the recipient lines — starts at the left
|
|
// margin just as an entry does.
|
|
func TestParseQueueIDs(t *testing.T) {
|
|
listing := `-Queue ID- --Size-- ----Arrival Time---- -Sender/Recipient-------
|
|
3C5B04E6C1* 446 Fri Aug 8 10:12:31 app@example.com
|
|
rcpt@example.net
|
|
|
|
5B4A2C1D3E 446 Fri Aug 8 10:13:31 app@example.com
|
|
(connect to mx.example.net[203.0.113.9]:25: Connection timed out)
|
|
deferred@example.net
|
|
|
|
A1B2C3D4E5F! 891 Fri Aug 8 10:14:31 app@example.com
|
|
held@example.net
|
|
|
|
-- 1 Kbytes in 3 Requests.
|
|
`
|
|
ids := parseQueueIDs(listing)
|
|
want := []string{"3C5B04E6C1", "5B4A2C1D3E", "A1B2C3D4E5F"}
|
|
for _, id := range want {
|
|
if _, ok := ids[id]; !ok {
|
|
t.Errorf("queue id %s not found in %v", id, ids)
|
|
}
|
|
}
|
|
if len(ids) != len(want) {
|
|
t.Errorf("got %d ids %v, want exactly %v", len(ids), ids, want)
|
|
}
|
|
}
|
|
|
|
// An empty queue must come back as an empty set, not as a phantom id parsed out
|
|
// of Postfix's prose — every stale row would otherwise be compared against a
|
|
// listing that claims to hold a message called "Mail".
|
|
func TestParseQueueIDsOnAnEmptyQueue(t *testing.T) {
|
|
if ids := parseQueueIDs("Mail queue is empty\n"); len(ids) != 0 {
|
|
t.Errorf("got %v, want no ids", ids)
|
|
}
|
|
}
|
|
|
|
// The queue listing is held in memory and rendered into a page, so a very large
|
|
// queue must not size the panel's allocation: the writer keeps the cap and
|
|
// reports the rest as dropped, while still accepting every write so postqueue
|
|
// itself is never cut short.
|
|
func TestLimitWriterCapsOutput(t *testing.T) {
|
|
w := &limitWriter{remaining: 8}
|
|
n, err := w.Write([]byte("12345"))
|
|
if n != 5 || err != nil {
|
|
t.Fatalf("first write = %d, %v", n, err)
|
|
}
|
|
if w.truncated {
|
|
t.Fatal("truncated before the cap was reached")
|
|
}
|
|
n, err = w.Write([]byte("67890"))
|
|
if n != 5 || err != nil {
|
|
t.Fatalf("second write = %d, %v", n, err)
|
|
}
|
|
if !w.truncated {
|
|
t.Fatal("write past the cap was not recorded as truncated")
|
|
}
|
|
if got := w.buf.String(); got != "12345678" {
|
|
t.Fatalf("kept %q, want the first 8 bytes", got)
|
|
}
|
|
if n, err := w.Write([]byte("more")); n != 4 || err != nil {
|
|
t.Fatalf("write after the cap = %d, %v (must still accept)", n, err)
|
|
}
|
|
if got := w.buf.String(); got != "12345678" {
|
|
t.Fatalf("buffer grew past the cap: %q", got)
|
|
}
|
|
}
|