test / test (push) Canceled after 0s
M14, M15: queryEach gives each resolver 2 s within the check's context and asks the one that answered last first; an address or PTR lookup not answered is Unknown, an answered mismatch beside it still an error; Checker.Server keeps the last answer's addresses, so SPF does not go Unknown with it. Notifications report faults only, now tested with SPF unknown alone and beside a wrong DKIM. DMARC reports: tests of malformed XML, gzip and zip bombs, a message over the limit, the service's Resync, hosted suggestion and validation. The finding: both limits cut silently and an oversized report failed as damaged; readAtMost refuses it for its size (MaxMessage 10 MiB, moved into IngestMessage). healthReadings replaces map[string]any for Health and Overview. L5: an inbound upstream has one TLS mode - a second domain to the same [host]:port with another mode is refused, naming the first; the TLS policy map holds each next hop once. Tested on the test server: go vet + go test of 25 packages, make e2e (all pass, 631 s) on this tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
108 lines
3.4 KiB
Go
108 lines
3.4 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/mixeme/selfpost/internal/health"
|
|
)
|
|
|
|
// checkServer resolves the panel's own hostname and confirms the reverse
|
|
// lookup of each address points back at that name (FCrDNS). A missing or
|
|
// mismatched PTR is the single most common reason mail from a self-hosted
|
|
// server is rejected or scored as spam, which is why it is an error and not
|
|
// advice.
|
|
func (c *Checker) checkServer(ctx context.Context, hostname string) Server {
|
|
srv := Server{Hostname: hostname, CheckedAt: time.Now()}
|
|
if hostname == "" {
|
|
srv.PTR = Result{
|
|
Status: health.StatusUnknown,
|
|
Detail: "SELFPOST_HOSTNAME is not set, so the server's own name in DNS cannot be checked. Set it in the deployment environment.",
|
|
}
|
|
return srv
|
|
}
|
|
|
|
addrs, err := c.resolver.LookupIPAddr(ctx, hostname)
|
|
if err != nil && !isNotFound(err) {
|
|
// The resolvers did not answer: not known, rather than "does not
|
|
// resolve" (audit 2026-10-12, M15). Checker.Server keeps the
|
|
// addresses it had, for the SPF check that needs them.
|
|
srv.PTR = lookupFailed("the address of "+hostname, err)
|
|
return srv
|
|
}
|
|
if len(addrs) == 0 {
|
|
srv.PTR = Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("%s does not resolve to any address. Publish an A (or AAAA) record for it — receiving servers check the name this server announces in HELO.", hostname),
|
|
}
|
|
return srv
|
|
}
|
|
|
|
want := normalizeName(hostname)
|
|
matched, total, unanswered := 0, len(addrs), 0
|
|
var records []string
|
|
var lastErr error
|
|
for _, a := range addrs {
|
|
ip := a.IP.String()
|
|
srv.IPs = append(srv.IPs, ip)
|
|
|
|
names, err := c.resolver.LookupAddr(ctx, ip)
|
|
if err != nil && !isNotFound(err) {
|
|
unanswered++
|
|
lastErr = err
|
|
records = append(records, ip+" → not answered ("+dnsErrorText(err)+")")
|
|
continue
|
|
}
|
|
if len(names) == 0 {
|
|
records = append(records, ip+" → no PTR record")
|
|
continue
|
|
}
|
|
hit := false
|
|
for _, n := range names {
|
|
if normalizeName(n) == want {
|
|
hit = true
|
|
}
|
|
}
|
|
if hit {
|
|
matched++
|
|
records = append(records, ip+" → "+normalizeName(names[0]))
|
|
} else {
|
|
records = append(records, ip+" → "+normalizeName(names[0])+" (does not match)")
|
|
}
|
|
}
|
|
|
|
srv.PTR.Records = records
|
|
switch {
|
|
case unanswered > 0 && matched+unanswered == total:
|
|
// Every address that was answered matches; the rest are not known.
|
|
srv.PTR.Status = health.StatusUnknown
|
|
srv.PTR.Detail = lookupFailed("the reverse DNS of "+joinIPs(srv.IPs), lastErr).Detail
|
|
case matched == total:
|
|
srv.PTR.Status = health.StatusOK
|
|
srv.PTR.Detail = fmt.Sprintf("%s resolves to %s and the reverse lookup points back at it.", hostname, joinIPs(srv.IPs))
|
|
case matched > 0:
|
|
srv.PTR.Status = health.StatusWarn
|
|
srv.PTR.Detail = fmt.Sprintf("Only %d of %d addresses of %s have a matching PTR record. Mail sent from the others may be rejected — set the reverse DNS of every address at your hosting provider.", matched, total, hostname)
|
|
default:
|
|
srv.PTR.Status = health.StatusError
|
|
srv.PTR.Detail = fmt.Sprintf("No address of %s has a reverse (PTR) record pointing back at it. Many receiving servers reject or spam-score mail from such a host — set the reverse DNS of the server's IP to %s at your hosting provider.", hostname, hostname)
|
|
}
|
|
return srv
|
|
}
|
|
|
|
func joinIPs(ips []string) string {
|
|
switch len(ips) {
|
|
case 0:
|
|
return "no address"
|
|
case 1:
|
|
return ips[0]
|
|
default:
|
|
out := ips[0]
|
|
for _, ip := range ips[1:] {
|
|
out += ", " + ip
|
|
}
|
|
return out
|
|
}
|
|
}
|