mixandClaude Opus 5.5
2b8e0c086d
test / test (push) Canceled after 0s
L17: past DeleteDomain both rebuilds run, their errors joined under domain.ErrDeletedIncomplete; the key is removed only when OpenDKIM's tables were rebuilt (they may still name it otherwise); the domain list says the domain is deleted and that Reload configuration finishes it, not "internal error". Tests in domain (the tables failing, the sender map failing) and handlers. The Outbound log's status and day filters (owner, 2026-10-13; the mockup first,80e3979): view.OutLogFilter carried by the poll, the pages, the rows' links and the message's way back; SendLogFilter.Status, Since, Until (whole UTC days, as the Inbound log's); rejected is the three refusals together; a status not in the list is no narrowing. Tests: the filters through the handler, the poll and the way back; the day boundaries in store. The plan's milter-socket step is ticked: done in 2.5.2 (98e09fe). Tested on the test server: go vet + go test of 25 packages, make e2e (all pass, 642 s) on this tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
72 lines
2.1 KiB
Go
72 lines
2.1 KiB
Go
package domain
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/mixeme/selfpost/internal/store"
|
|
)
|
|
|
|
// countingApps is fakeApps that counts the sender map's rebuilds and can
|
|
// fail them.
|
|
type countingApps struct {
|
|
fakeApps
|
|
resyncs int
|
|
resyncErr error
|
|
}
|
|
|
|
func (c *countingApps) Resync() error {
|
|
c.resyncs++
|
|
return c.resyncErr
|
|
}
|
|
|
|
// A deletion that fails after the domain's row is gone says the domain is
|
|
// deleted, and runs every rebuild anyway: the sender map was left naming the
|
|
// purged logins when OpenDKIM's tables failed first (audit 2026-10-12, L17).
|
|
// The key stays while the tables may still name it.
|
|
func TestDeleteRunsEveryRebuildAndSaysTheDomainIsGone(t *testing.T) {
|
|
apps := &countingApps{}
|
|
s, odk := newTestService(t, apps)
|
|
d, err := s.Add("gone.example")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
keyDir := filepath.Join(odk.keysDir, d.Name)
|
|
apps.resyncs = 0
|
|
|
|
odk.reload = func() error { return errors.New("supervisor away") }
|
|
err = s.Delete(d.ID)
|
|
if !errors.Is(err, ErrDeletedIncomplete) {
|
|
t.Fatalf("Delete with OpenDKIM's reload failing = %v, want ErrDeletedIncomplete", err)
|
|
}
|
|
if _, err := s.Get(d.ID); !errors.Is(err, store.ErrDomainNotFound) {
|
|
t.Errorf("the domain is still in the registry: %v", err)
|
|
}
|
|
if apps.resyncs != 1 {
|
|
t.Errorf("the sender map was rebuilt %d times, want once", apps.resyncs)
|
|
}
|
|
if _, err := os.Stat(keyDir); err != nil {
|
|
t.Errorf("the key went while the tables may still name it: %v", err)
|
|
}
|
|
}
|
|
|
|
// The sender map failing is the same: deleted, said so; the tables were
|
|
// rebuilt, so the key goes.
|
|
func TestDeleteWithTheSenderMapFailing(t *testing.T) {
|
|
apps := &countingApps{resyncErr: errors.New("postfix away")}
|
|
s, odk := newTestService(t, apps)
|
|
d, err := s.Add("gone.example")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
keyDir := filepath.Join(odk.keysDir, d.Name)
|
|
if err := s.Delete(d.ID); !errors.Is(err, ErrDeletedIncomplete) {
|
|
t.Fatalf("Delete with the sender map failing = %v, want ErrDeletedIncomplete", err)
|
|
}
|
|
if _, err := os.Stat(keyDir); !os.IsNotExist(err) {
|
|
t.Errorf("the key is still there after the tables were rebuilt: %v", err)
|
|
}
|
|
}
|