Comments only, no behaviour changed. go-milter v0.4.1 (session.go: one session per connection, replaced after a non-continue reply; macros per stage), Postfix 3.7.11 (milter8.c, smtpd_check.c reject_auth_sender_login_mismatch(), mail_addr_find.c, showq_compat.c, mail_conf_time.c, mail_params.h), Cyrus SASL 2.1.28 (saslpasswd.c, plugins/sasldb.c: deleting a missing login is not an error), OpenDKIM 2.11.0~beta2 (opendkim-db.c, opendkim-genkey), Berkeley DB 5.3 db_dump, rspamd 3.11.0. Comments that claimed what the source denies are corrected (sasldb keeps the password as given, not hashed; an embedded newline is kept, not truncated; rspamd sorts symbols by absolute weight); fixtures say seen or composed. The sender check's From: parsing gets no citations: it is replaced by the port of OpenDKIM's dkim_mail_parse next. Contradictions left for their own commits: B-G5 cleanAddress, B-PS1 first key wins, B-PQ1 the forced-expire flag, B-PQ10/PQ11 Postfix's time units. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
158 lines
5.3 KiB
Go
158 lines
5.3 KiB
Go
package postfix
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
"os/exec"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
// RetryPolicy is this Postfix's deferred-mail retry timings, as postconf
|
|
// reports them. The panel loads it once at HTTP start (architecture.md) and
|
|
// never re-reads it for a request.
|
|
type RetryPolicy struct {
|
|
QueueRunDelay time.Duration
|
|
MinimalBackoff time.Duration
|
|
MaximalBackoff time.Duration
|
|
MaximalQueueLifetime time.Duration
|
|
BounceQueueLifetime time.Duration
|
|
DelayWarningTime time.Duration
|
|
// FromDefaults is true when postconf could not be read and the compiled-in
|
|
// Postfix 3.x values were substituted. The Mail queue card shows a muted
|
|
// note in that case so an operator who overrode the parameters is not
|
|
// silently shown the stock numbers.
|
|
FromDefaults bool
|
|
}
|
|
|
|
// DefaultRetryPolicy is Postfix 3.x compiled-in values for the six parameters
|
|
// build/postfix-config.sh does not set. Used when postconf is missing (unit
|
|
// tests, a binary outside the container) so the panel still starts.
|
|
//
|
|
// Postfix 3.7.11, src/global/mail_params.h: DEF_QUEUE_RUN_DELAY "300s",
|
|
// DEF_MIN_BACKOFF_TIME DEF_QUEUE_RUN_DELAY, DEF_MAX_BACKOFF_TIME "4000s",
|
|
// DEF_MAX_QUEUE_TIME "5d", DEF_DSN_QUEUE_TIME "5d", DEF_DELAY_WARN_TIME "0h".
|
|
func DefaultRetryPolicy() RetryPolicy {
|
|
return RetryPolicy{
|
|
QueueRunDelay: 300 * time.Second,
|
|
MinimalBackoff: 300 * time.Second,
|
|
MaximalBackoff: 4000 * time.Second,
|
|
MaximalQueueLifetime: 5 * 24 * time.Hour,
|
|
BounceQueueLifetime: 5 * 24 * time.Hour,
|
|
DelayWarningTime: 0,
|
|
FromDefaults: true,
|
|
}
|
|
}
|
|
|
|
// retryConfKeys is the fixed argv tail for `postconf -h`. Order matches the
|
|
// fields of RetryPolicy. No user input is interpolated (security.md).
|
|
var retryConfKeys = []string{
|
|
"queue_run_delay",
|
|
"minimal_backoff_time",
|
|
"maximal_backoff_time",
|
|
"maximal_queue_lifetime",
|
|
"bounce_queue_lifetime",
|
|
"delay_warning_time",
|
|
}
|
|
|
|
// readRetryConf runs `postconf -h` for the retry-policy keys. Tests replace it
|
|
// the same way logtail stubs queueIDs.
|
|
var readRetryConf = postconfRetryValues
|
|
|
|
func postconfRetryValues() ([]string, error) {
|
|
// Fixed argv, no user input — same pattern as Queue (security.md).
|
|
// Postfix 3.7.11, src/postconf/postconf_main.c, pcf_show_parameters():
|
|
// named parameters are printed in argument order, with -h one "%s\n"
|
|
// value each, as written in main.cf (not expanded without -x).
|
|
cmd := exec.Command("postconf", "-h",
|
|
"queue_run_delay",
|
|
"minimal_backoff_time",
|
|
"maximal_backoff_time",
|
|
"maximal_queue_lifetime",
|
|
"bounce_queue_lifetime",
|
|
"delay_warning_time",
|
|
)
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("postconf -h: %w: %s", err, strings.TrimSpace(string(out)))
|
|
}
|
|
lines := strings.Split(strings.TrimSpace(string(out)), "\n")
|
|
if len(lines) != len(retryConfKeys) {
|
|
return nil, fmt.Errorf("postconf -h: got %d values, want %d", len(lines), len(retryConfKeys))
|
|
}
|
|
for i := range lines {
|
|
lines[i] = strings.TrimSpace(lines[i])
|
|
}
|
|
return lines, nil
|
|
}
|
|
|
|
// LoadRetryPolicy reads the effective Postfix retry parameters. On any failure
|
|
// it logs a warning and returns DefaultRetryPolicy; the HTTP role must not
|
|
// refuse to start because postconf is absent.
|
|
func LoadRetryPolicy() RetryPolicy {
|
|
lines, err := readRetryConf()
|
|
if err != nil {
|
|
log.Printf("postfix: retry policy: %v; using compiled-in defaults", err)
|
|
return DefaultRetryPolicy()
|
|
}
|
|
p, err := parseRetryPolicy(lines)
|
|
if err != nil {
|
|
log.Printf("postfix: retry policy: %v; using compiled-in defaults", err)
|
|
return DefaultRetryPolicy()
|
|
}
|
|
return p
|
|
}
|
|
|
|
func parseRetryPolicy(lines []string) (RetryPolicy, error) {
|
|
if len(lines) != len(retryConfKeys) {
|
|
return RetryPolicy{}, fmt.Errorf("got %d values, want %d", len(lines), len(retryConfKeys))
|
|
}
|
|
var durs [6]time.Duration
|
|
for i, line := range lines {
|
|
d, err := ParseDuration(line)
|
|
if err != nil {
|
|
return RetryPolicy{}, fmt.Errorf("%s: %w", retryConfKeys[i], err)
|
|
}
|
|
durs[i] = d
|
|
}
|
|
return RetryPolicy{
|
|
QueueRunDelay: durs[0],
|
|
MinimalBackoff: durs[1],
|
|
MaximalBackoff: durs[2],
|
|
MaximalQueueLifetime: durs[3],
|
|
BounceQueueLifetime: durs[4],
|
|
DelayWarningTime: durs[5],
|
|
}, nil
|
|
}
|
|
|
|
// FirstRetry is the human string for the first deferred retry (minimal
|
|
// backoff), shared by the Mail queue card and delivery history.
|
|
func (p RetryPolicy) FirstRetry() string {
|
|
return FormatDuration(p.MinimalBackoff)
|
|
}
|
|
|
|
// BackoffCap is the human string for maximal_backoff_time.
|
|
func (p RetryPolicy) BackoffCap() string {
|
|
return FormatDuration(p.MaximalBackoff)
|
|
}
|
|
|
|
// LongestLifetime is how long Postfix may go on working on a message: the
|
|
// larger of the queue lifetime for ordinary mail and for mail from the null
|
|
// sender, which an application may submit too. It bounds which stored log
|
|
// lines can be about a send-log row (store.SendLogLines).
|
|
//
|
|
// Postfix 3.7.11, src/qmgr/qmgr_active.c, qmgr_active_done(): a message
|
|
// expires after var_max_queue_time, or var_dsn_queue_time when its sender is
|
|
// null - whoever submitted it (qmgr.c caps the second at the first).
|
|
func (p RetryPolicy) LongestLifetime() time.Duration {
|
|
if p.BounceQueueLifetime > p.MaximalQueueLifetime {
|
|
return p.BounceQueueLifetime
|
|
}
|
|
return p.MaximalQueueLifetime
|
|
}
|
|
|
|
// QueueLifetime is the human string for maximal_queue_lifetime.
|
|
func (p RetryPolicy) QueueLifetime() string {
|
|
return FormatDuration(p.MaximalQueueLifetime)
|
|
}
|