mix
d49351c022
Codeberg is being retired as the project's public site, so every reference now points at GitHub. That includes the Go module path (codeberg.org/mix/selfpost → github.com/mixeme/selfpost): leaving an import path on a host that is going away would break `go get` and `go install`, so this is not only a docs change. Touches go.mod, test/e2e/go.mod, all imports, Makefile MODULE, the -ldflags version stamp in build/Dockerfile and docs/development.md, the licence headers in the SVG/HTML assets, and README (no more primary/mirror pair). Comments no longer cite the archived specification. "spec 7.6.1", "spec 5.1" and friends pointed into docs/archive/specification-v1.0.md, which is marked as not a source of truth; each is now a reference to the live document that owns the subject — architecture.md (with section), product.md, security.md or the README. The review only asked for the 7.x refs (code-review.md § 4), but 4/5/6/ 8/9 had the same defect, so they went too. Comments only, no behaviour change. Also closes the remaining review items: architecture.md gained a Code layers section with the layer diagram (A2), and TestParseDelivery gained the exotic mail.log cases (§ 3). Fixes a bug that last test found: the delivery-line pattern matched status= greedily, taking the *last* occurrence on the line. Postfix appends the remote server's reply verbatim, so a rejection whose reply quoted "status=sent" was filed as a delivered message in the send log. It now takes the first status= after the recipient, which is the real field. R7 (CONTRIBUTING.md) moved to roadmap 2.x — one developer, no external PR flow, so the file would have no audience yet. R1 (compose image tag) and the git tag stay in roadmap § v1.x as the release-commit steps. gofmt/go vet clean on both modules; go test ./... green except the three known Windows-only failures (file perms, backslash paths, renaming an open file). Not exercised on the dev server — no Docker locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.0 KiB
Go
61 lines
2.0 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mixeme/selfpost/internal/health"
|
|
)
|
|
|
|
func TestSPFExample(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
hostname string
|
|
ips []string
|
|
want string
|
|
}{
|
|
{"ipv4", "mail.example.com", []string{"203.0.113.10"}, "v=spf1 ip4:203.0.113.10 -all"},
|
|
{"both families", "mail.example.com", []string{"203.0.113.10", "2001:db8::1"},
|
|
"v=spf1 ip4:203.0.113.10 ip6:2001:db8::1 -all"},
|
|
// The hostname does not resolve, so there is no address to name; an "a:"
|
|
// mechanism still gives the operator a publishable record.
|
|
{"no addresses", "mail.example.com", nil, "v=spf1 a:mail.example.com -all"},
|
|
{"unparsable addresses", "mail.example.com", []string{"not-an-ip"}, "v=spf1 a:mail.example.com -all"},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
if got := SPFExample(c.hostname, c.ips); got != c.want {
|
|
t.Errorf("SPFExample = %q, want %q", got, c.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// The record the panel shows and the one a failed check suggests must be the
|
|
// same string, or the operator is told two different things on one page.
|
|
func TestMissingRecordChecksSuggestTheShownExample(t *testing.T) {
|
|
f := &fakeResolver{}
|
|
c := newTestChecker(f)
|
|
|
|
spf := c.checkSPF(context.Background(), Query{
|
|
Name: "example.com",
|
|
Hostname: "mail.example.com",
|
|
ServerIPs: []string{"203.0.113.10"},
|
|
})
|
|
if spf.Status != health.StatusError {
|
|
t.Fatalf("SPF status = %q, want error (%s)", spf.Status, spf.Detail)
|
|
}
|
|
if want := SPFExample("mail.example.com", []string{"203.0.113.10"}); !strings.Contains(spf.Detail, want) {
|
|
t.Errorf("SPF advice %q does not suggest %q", spf.Detail, want)
|
|
}
|
|
|
|
dmarc := c.checkDMARC(context.Background(), "example.com")
|
|
if dmarc.Status != health.StatusWarn {
|
|
t.Fatalf("DMARC status = %q, want warn (%s)", dmarc.Status, dmarc.Detail)
|
|
}
|
|
if want := DMARCExample("example.com"); !strings.Contains(dmarc.Detail, want) {
|
|
t.Errorf("DMARC advice %q does not suggest %q", dmarc.Detail, want)
|
|
}
|
|
}
|