Review pass over `1.4.0`…`1.9.1`: port 25 no longer shares the submission milter chain, DMARC reports are validated before they are stored, and the auto rate limit is correct for a non-default level-1 window. Schema migration `0010` (index only). Upgrading is a tag bump. Added: - SQLite migration `0010_send_log_app_login_index.sql` — - DMARC aggregate reports are accepted as **zip** as well as gzip or plain XML - e2e: `checkPort25ConfigCombinations` regenerates the Postfix configuration Changed: - README hero line and a **Positioning** block in `docs/product.md` record the Fixed: - The setup account's password is hashed at bcrypt cost `12` like every other - Login/setup rate limiter: protecting blocked buckets from eviction is now - `postqueue -p` output is bounded to 4 MiB (the timeout alone left the size of - [schema-migrations.md](docs/schema-migrations.md): the schema section was - postqueue reader is now time-bounded: `postqueue -p` runs under a 5-second … (11 more in CHANGELOG) Changed: - [roadmap.md](docs/roadmap.md) now carries everything the 2026-08-19 code - Extracted `internal/configsafe` — the empty-value and forbidden-character - Build, deploy and migration comments no longer cite the archived - Dropped the `parseDomainRateLimitForm` / `parseAppRateLimitForm` pass-through - Extracted shared helpers: `internal/atomicfile` (atomic temp-write+rename) and … (7 more in CHANGELOG) Removed: - Unused legacy asset `docs/assets/icon.png` (superseded by the four brand SVGs - Plan documents for already-shipped features: `domain-stats-auto-ratelimit`, Full detail: CHANGELOG.md (1.9.2).
217 lines
5.7 KiB
Go
217 lines
5.7 KiB
Go
package dmarc
|
|
|
|
import (
|
|
"archive/zip"
|
|
"bytes"
|
|
"compress/gzip"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/mixeme/selfpost/internal/store"
|
|
)
|
|
|
|
const sampleXML = `<?xml version="1.0"?>
|
|
<feedback>
|
|
<report_metadata>
|
|
<org_name>google.com</org_name>
|
|
<email>noreply@google.com</email>
|
|
<report_id>12345</report_id>
|
|
<date_range><begin>1723593600</begin><end>1723680000</end></date_range>
|
|
</report_metadata>
|
|
<policy_published>
|
|
<domain>example.com</domain>
|
|
<p>none</p><sp>none</sp><pct>100</pct>
|
|
<adkim>r</adkim><aspf>r</aspf>
|
|
</policy_published>
|
|
<record>
|
|
<row>
|
|
<source_ip>203.0.113.10</source_ip>
|
|
<count>10</count>
|
|
<policy_evaluated>
|
|
<disposition>none</disposition>
|
|
<dkim>pass</dkim><spf>pass</spf>
|
|
</policy_evaluated>
|
|
</row>
|
|
<identifiers><header_from>example.com</header_from></identifiers>
|
|
</record>
|
|
<record>
|
|
<row>
|
|
<source_ip>198.51.100.1</source_ip>
|
|
<count>2</count>
|
|
<policy_evaluated>
|
|
<disposition>none</disposition>
|
|
<dkim>fail</dkim><spf>fail</spf>
|
|
</policy_evaluated>
|
|
</row>
|
|
<identifiers><header_from>example.com</header_from></identifiers>
|
|
</record>
|
|
</feedback>`
|
|
|
|
func TestParseAggregateGzip(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
zw := gzip.NewWriter(&buf)
|
|
if _, err := zw.Write([]byte(sampleXML)); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := zw.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, err := ParseAggregate(buf.Bytes())
|
|
if err != nil {
|
|
t.Fatalf("ParseAggregate: %v", err)
|
|
}
|
|
if got.Domain != "example.com" || got.Reporter != "google.com" {
|
|
t.Fatalf("metadata = %+v", got)
|
|
}
|
|
if got.PassCount != 10 || got.FailCount != 2 {
|
|
t.Fatalf("counts = %d pass %d fail", got.PassCount, got.FailCount)
|
|
}
|
|
if !got.PeriodBegin.Equal(time.Unix(1723593600, 0).UTC()) {
|
|
t.Fatalf("period begin = %v", got.PeriodBegin)
|
|
}
|
|
}
|
|
|
|
func TestIngestMessageStoresReport(t *testing.T) {
|
|
st, err := store.Open(t.TempDir() + "/test.db")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer st.Close()
|
|
if _, err := st.AddDomain("example.com", "selfpost"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var gz bytes.Buffer
|
|
zw := gzip.NewWriter(&gz)
|
|
_, _ = zw.Write([]byte(sampleXML))
|
|
_ = zw.Close()
|
|
|
|
msg := bytes.NewBufferString(
|
|
"From: noreply@google.com\r\n" +
|
|
"To: dmarc-reports@mail.example.com\r\n" +
|
|
"Subject: Report\r\n" +
|
|
"Content-Type: application/gzip; name=\"report.xml.gz\"\r\n" +
|
|
"\r\n",
|
|
)
|
|
// append raw gzip for simple single-part test
|
|
msg.Write(gz.Bytes())
|
|
|
|
if err := IngestMessage(st, msg, "dmarc-reports@mail.example.com", time.Now().UTC()); err != nil {
|
|
t.Fatalf("IngestMessage: %v", err)
|
|
}
|
|
list, err := st.ListDMARCReports(nil, 10)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(list) != 1 {
|
|
t.Fatalf("reports = %d", len(list))
|
|
}
|
|
if list[0].PassCount != 10 {
|
|
t.Fatalf("pass = %d", list[0].PassCount)
|
|
}
|
|
}
|
|
|
|
func TestHostedReportAddress(t *testing.T) {
|
|
got := HostedReportAddress("mail.example.com", "Example.COM")
|
|
want := "dmarc-reports+example.com@mail.example.com"
|
|
if got != want {
|
|
t.Fatalf("got %q want %q", got, want)
|
|
}
|
|
}
|
|
|
|
func TestIngestMessageRejectsUnknownDomain(t *testing.T) {
|
|
st, err := store.Open(t.TempDir() + "/test.db")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer st.Close()
|
|
|
|
if err := IngestMessage(st, bytes.NewBufferString(gzipMessage(t, sampleXML)), "dmarc-reports@mail.example.com", time.Now().UTC()); err == nil {
|
|
t.Fatal("report for an unconfigured domain was accepted")
|
|
}
|
|
list, err := st.ListDMARCReports(nil, 10)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(list) != 0 {
|
|
t.Fatalf("stored %d report(s) for an unconfigured domain", len(list))
|
|
}
|
|
}
|
|
|
|
// A report claiming example.com must not be accepted at the address tagged for
|
|
// another domain, even when both domains are configured here.
|
|
func TestIngestMessageRejectsTagMismatch(t *testing.T) {
|
|
st, err := store.Open(t.TempDir() + "/test.db")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer st.Close()
|
|
if _, err := st.AddDomain("example.com", "selfpost"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := st.AddDomain("other.example", "selfpost"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = IngestMessage(st, bytes.NewBufferString(gzipMessage(t, sampleXML)),
|
|
"dmarc-reports+other.example@mail.example.com", time.Now().UTC())
|
|
if err == nil {
|
|
t.Fatal("report was accepted at an address tagged for another domain")
|
|
}
|
|
}
|
|
|
|
func TestTaggedDomain(t *testing.T) {
|
|
cases := map[string]string{
|
|
"dmarc-reports+example.com@mail.example.com": "example.com",
|
|
"dmarc-reports@mail.example.com": "",
|
|
"postmaster+example.com@mail.example.com": "",
|
|
"not-an-address": "",
|
|
}
|
|
for addr, want := range cases {
|
|
if got := TaggedDomain(addr); got != want {
|
|
t.Errorf("TaggedDomain(%q) = %q, want %q", addr, got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseAggregateFromZip(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
zw := zip.NewWriter(&buf)
|
|
w, err := zw.Create("report.xml")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := w.Write([]byte(sampleXML)); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := zw.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
got, err := ParseAggregate(buf.Bytes())
|
|
if err != nil {
|
|
t.Fatalf("ParseAggregate(zip): %v", err)
|
|
}
|
|
if got.Domain != "example.com" || got.PassCount != 10 {
|
|
t.Fatalf("zip report = %+v", got)
|
|
}
|
|
}
|
|
|
|
// gzipMessage wraps xml in the single-part gzip message the ingest pipe sees.
|
|
func gzipMessage(t *testing.T, xml string) string {
|
|
t.Helper()
|
|
var gz bytes.Buffer
|
|
zw := gzip.NewWriter(&gz)
|
|
if _, err := zw.Write([]byte(xml)); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := zw.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return "From: noreply@google.com\r\n" +
|
|
"To: dmarc-reports@mail.example.com\r\n" +
|
|
"Subject: Report\r\n" +
|
|
"Content-Type: application/gzip; name=\"report.xml.gz\"\r\n" +
|
|
"\r\n" + gz.String()
|
|
}
|