A bounce could be recorded as a successful delivery. The log-tailer's Fixed: - A bounce could be recorded as a successful delivery. The log-tailer's - Log-tailer resumes where it stopped instead of jumping to end-of-file on - Level-2 rate limit no longer overshoots under concurrency: messages that Changed: - The project has a single public home: `github.com/mixeme/selfpost`. Codeberg - Code comments no longer cite the archived specification. References like - `docs/code-review.md` is gone. Its plan is finished — phases 0 (bar the - `docs/architecture.md` gained a *Code layers* section: a diagram of - Phase 1 doc/code hygiene (`docs/code-review.md`): removed ~30 stale … (1 more in CHANGELOG) Security: - Pre-release security review (plan § D, model Fable, 2026-08-06): full pass - `saslpasswd2` argv: the application login is now passed after a `--` Added: - Optional password encryption for the two secret-bearing downloads (plan - Domain import accepts an encrypted export: the envelope is detected by its - `selfpost-backup` writes encrypted archives and reads them back: - `TestParseDelivery` covers the exotic mail.log shapes the review asked for - docs: README *Encrypting a backup or export*; `docs/security.md` § … (14 more in CHANGELOG) Removed: - docs: `security.md` — accepted risk «restore old backup revives session rows» Changed: - docs: `implementation-plan.md` trimmed to the sole open v1.x gate — pre-release - docs: `architecture.md` — sessions (SQLite, idle renew, password change), - docs: `development.md` — expanded e2e stack and `release.yml` matrix workflow. - docs: `security.md` — accepted risk for send-log rows stuck at `queued` after - docs: `roadmap.md` — optional send-log / `mail.log` follow-ups under v1.x tail. … (10 more in CHANGELOG) Full detail: CHANGELOG.md (0.5.0).
131 lines
4.2 KiB
Go
131 lines
4.2 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/mixeme/selfpost/internal/health"
|
|
)
|
|
|
|
// checkDKIM compares the TXT record published at <selector>._domainkey.<domain>
|
|
// with the key this server signs with. A wrong or absent record means every
|
|
// message fails DKIM at the receiver, so both are errors.
|
|
func (c *Checker) checkDKIM(ctx context.Context, q Query) Result {
|
|
name := q.Selector + "._domainkey." + q.Name
|
|
txt, found, err := c.lookupTXT(ctx, name)
|
|
if err != nil {
|
|
return lookupFailed("the DKIM record", err)
|
|
}
|
|
|
|
expected := publicKeyTag(q.ExpectedDKIM)
|
|
if !found {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("No TXT record is published at %s. Publish the record shown above — until then every message fails DKIM.", name),
|
|
}
|
|
}
|
|
|
|
for _, rec := range txt {
|
|
got := publicKeyTag(rec)
|
|
if got == "" {
|
|
continue
|
|
}
|
|
if got == expected {
|
|
return Result{
|
|
Status: health.StatusOK,
|
|
Detail: fmt.Sprintf("Published at %s and matching the key this server signs with.", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
}
|
|
|
|
// Something is published, but it is not our key. Separate the revoked case
|
|
// (empty p=), which reads as a deliberate act rather than a typo.
|
|
for _, rec := range txt {
|
|
if v, ok := tagValue(rec, "p"); ok && v == "" {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("The record at %s has an empty p= tag, which revokes the key. Replace it with the record shown above.", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
}
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("A TXT record exists at %s but its public key is not the one this server signs with — mail will fail DKIM. Replace it with the record shown above (an old record from a previous server is the usual cause).", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
|
|
// checkDMARC reports whether the domain publishes a DMARC policy. DMARC is not
|
|
// required for delivery, so its absence is advice (warn), not a fault.
|
|
func (c *Checker) checkDMARC(ctx context.Context, domainName string) Result {
|
|
name := DMARCRecordName(domainName)
|
|
txt, found, err := c.lookupTXT(ctx, name)
|
|
if err != nil {
|
|
return lookupFailed("the DMARC record", err)
|
|
}
|
|
|
|
var records []string
|
|
for _, rec := range txt {
|
|
if strings.HasPrefix(strings.ToLower(strings.TrimSpace(rec)), "v=dmarc1") {
|
|
records = append(records, rec)
|
|
}
|
|
}
|
|
if !found || len(records) == 0 {
|
|
return Result{
|
|
Status: health.StatusWarn,
|
|
Detail: fmt.Sprintf("No DMARC record at %s. Delivery works without one, but publishing at least %q tells receivers what to do with mail that fails DKIM and gets you reports.", name, DMARCExample(domainName)),
|
|
}
|
|
}
|
|
if len(records) > 1 {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("More than one DMARC record is published at %s. Receivers treat that as no policy at all — keep exactly one.", name),
|
|
Records: records,
|
|
}
|
|
}
|
|
|
|
policy, ok := tagValue(records[0], "p")
|
|
if !ok || policy == "" {
|
|
return Result{
|
|
Status: health.StatusWarn,
|
|
Detail: "A DMARC record is published but has no p= policy tag, so receivers ignore it. Add p=none, p=quarantine or p=reject.",
|
|
Records: records,
|
|
}
|
|
}
|
|
detail := fmt.Sprintf("Published with policy p=%s.", policy)
|
|
if strings.EqualFold(policy, "none") {
|
|
detail += " That is monitoring only — tighten it to quarantine or reject once the reports look clean."
|
|
}
|
|
return Result{Status: health.StatusOK, Detail: detail, Records: records}
|
|
}
|
|
|
|
// publicKeyTag extracts the p= (public key) tag of a DKIM record, with all
|
|
// whitespace removed: DNS providers and TXT chunking freely insert spaces and
|
|
// line breaks into the base64, none of which are part of the key.
|
|
func publicKeyTag(record string) string {
|
|
v, ok := tagValue(record, "p")
|
|
if !ok {
|
|
return ""
|
|
}
|
|
return strings.Join(strings.Fields(v), "")
|
|
}
|
|
|
|
// tagValue reads one tag from a DKIM/DMARC-style "tag=value; tag=value" record.
|
|
// Tag names are case-sensitive per RFC 6376/7489, and values keep their case.
|
|
func tagValue(record, tag string) (string, bool) {
|
|
for _, part := range strings.Split(record, ";") {
|
|
part = strings.TrimSpace(part)
|
|
key, value, found := strings.Cut(part, "=")
|
|
if !found {
|
|
continue
|
|
}
|
|
if strings.TrimSpace(key) == tag {
|
|
return strings.TrimSpace(value), true
|
|
}
|
|
}
|
|
return "", false
|
|
}
|