mixandClaude Opus 5.5
c171fb5bc7
test / test (push) Canceled after 0s
A message's From: line is held against the application that sends it, under the rule Postfix holds the envelope sender to. OpenDKIM chooses the key by that line, so until now an application could have mail signed as another domain of the server or as the server itself. The check (internal/milter/sender.go) - A role of the panel on a socket of its own (SENDER_CHECK_SOCKET), first in smtpd_milters and strict: default_action=tempfail. The journal milter keeps its socket and stays fail-open. postfix-wrapper waits for the new socket. - It reads no database: what an application may send as comes from Postfix's own sender_login_maps, what the server signs for from OpenDKIM's SigningTable. Both are read again when they change; one that cannot be read defers mail. - One From: field, one address, allowed by the envelope's lookup; then no other name of the SigningTable may appear anywhere in the raw line. Refused: 550 5.7.1 naming the line, reduced to printable ASCII. - A refusal is a send-log row with reason "from" and the header address (migration 0006), written by another goroutine and not waited for. The journal's refusals record their reason too (limit, client), and the notifier takes only a limit's. What it costs (docs/plans/from-header-binding.md, Statistics) - The role marks itself alive every 2 s; at start the gap since the mark is downtime, counted from Postfix's start if later and not at all when supervisord says Postfix is not running. - The log tailer counts the connections Postfix turned away: a warning that names the socket, then milter-reject "Service unavailable" from the same smtpd. Seen on the stand: the client is refused from CONNECT on and leaves at AUTH (454), so no MAIL line is ever written. - sender_check_days, a row per UTC day, kept a year. Pages - Health: the card "Sender check", the socket's row, and the cards layout - boxes numbered by importance in two stacks read in rows; the left stack polls, the three readings of the right one are swapped in by id. - Outbound log: a refused row says why in its tag (wrong From, wrong client, rate-limited); the message's page shows the From: line and what the application may send as. - Help: topic "Sender check", word for word the mockup's. Found by the stand, fixed here: the names for the second look came from the sender bindings, and a domain with a key and no application yet was not among them. e2e: negative_journal_milter_fail_open is gone - it proved that mail passes with the panel down, which is no longer so. In its place sender_check_holds_the_from_line (another domain's From:, the hostname's, a stranger's, an address off the list, another sender in the display name - refused; own addresses - delivered) and panel_down_defers_mail (4xx with the panel stopped, the container alive, mail again after, downtime and one deferred message on Health, the card warning). Test server, this tree before the last cosmetic edits (a fixture row, a fact's size, docs): go vet ok, go test 23 packages ok, make e2e ok (337 s). Locally after them: internal/web/view ok. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
27 lines
1.3 KiB
SQL
27 lines
1.3 KiB
SQL
-- The sender check: a message's From: line is held against the application
|
|
-- that sends it (from-header-binding, 2.4.0). DDL only; nothing existing
|
|
-- changes.
|
|
|
|
-- Why a refused row was refused. Until now "rejected" was one status for
|
|
-- three things, and the row did not say which:
|
|
-- limit a level-2 rate limit
|
|
-- client the application's list of client addresses
|
|
-- from the From: line is not the application's
|
|
-- A row from before this migration has '' and is shown as plainly rejected.
|
|
ALTER TABLE send_log ADD COLUMN reason TEXT NOT NULL DEFAULT '';
|
|
|
|
-- For a row refused for its From: line, what the header said - cut and
|
|
-- reduced to printable characters by the check before it is stored. from_addr
|
|
-- stays the envelope sender, the address the application had the right to.
|
|
ALTER TABLE send_log ADD COLUMN header_from TEXT NOT NULL DEFAULT '';
|
|
|
|
-- What the strict check costs, a row per UTC day that has something to say:
|
|
-- for how many seconds the panel did not answer while Postfix was running,
|
|
-- and how many messages Postfix deferred because the check did not answer.
|
|
-- Kept a year. The first day counted is in settings, "sender_check_since".
|
|
CREATE TABLE sender_check_days (
|
|
day TEXT PRIMARY KEY,
|
|
down_seconds INTEGER NOT NULL DEFAULT 0,
|
|
deferred INTEGER NOT NULL DEFAULT 0
|
|
);
|