mixandClaude Opus 5.5
8d1af89e1a
Stage 1, step 1. BREAKING: a 1.x database is not migrated.
Schema
- internal/store/migrations/ holds one file, 0001_init.sql, equal to the
2.0 schema; 0002..0010 are deleted (they stay in history at 1.9.5). No
admin table created and dropped, no ALTERs.
- users.email replaces users.dmarc_report_email: the address is the
user's own. The default DMARC report address is a user's setting
(dmarc_default_mode hosted/account/custom/none, dmarc_default_address);
the instance setting that mirrored the global user's field is gone.
- domains.dmarc_rua_user_id: a domain follows a named user's default, or
has an address of its own in dmarc_rua ('' = none). ON DELETE SET NULL
leaves it at "no reports", never at someone else's default.
- user_inbound_domains, users.all_domains, users.all_inbound_domains: in
the schema for the inbound delegation of the next step.
- users.role is 'global' / 'domain' (was 'domain_admin');
rate_limits.allowed_ips, unused since 1.9.0, is dropped.
Opening a database
- The baseline sets PRAGMA application_id ("SP20"). store.Open refuses a
file that has a schema version without it (ErrForeignSchema) and one
newer than the build. A 1.x file at user_version 10 would otherwise read
as already migrated. The refused file is left untouched.
Code
- Store.DomainDMARCRua is the one place a domain's report address is
resolved; dnscheck.ResolveDMARCRua and Store.GlobalDMARCReportEmail are
gone. dmarc.AllowedRecipients, the domain page, the dashboard and the
DNS re-check go through it.
- The old templates keep working on the new model until their pages are
restyled: the Settings form's address field is the account e-mail and
switches the user's default between it and none; a domain's "Same as
Settings" makes it follow the user who chose it; a new or imported
domain follows its creator.
- Domain export/import: a domain that follows a user exports no address.
Tests: the baseline pinned table by table (TestBaselineSchema), refusal of a
1.x and of a newer database, constraints and cascades of the new columns and
table, resolution in every default mode, the deleted-user case, and the three
bridged handlers.
docs/schema-migrations.md is rewritten for the baseline; roadmap 11/27,
schema-squash marked built.
go test ./... (Windows)
ok for every package except two that fail the same way before this commit:
internal/domain TestWriteLoadPrivateKeyRoundtrip (file mode on NTFS)
internal/logtail TestFollowTailsAndRotates (rename of an open file)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
103 lines
2.8 KiB
Go
103 lines
2.8 KiB
Go
package store
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func TestUpdateUser(t *testing.T) {
|
|
st := openTestStore(t)
|
|
|
|
if err := st.CreateGlobalUser("admin", "hash-one"); err != nil {
|
|
t.Fatalf("CreateGlobalUser: %v", err)
|
|
}
|
|
u, err := st.GetUserByUsername("admin")
|
|
if err != nil {
|
|
t.Fatalf("GetUserByUsername: %v", err)
|
|
}
|
|
if err := st.UpdateUser(u.ID, "operator", "hash-two", "reports@hub.example"); err != nil {
|
|
t.Fatalf("UpdateUser: %v", err)
|
|
}
|
|
|
|
got, err := st.GetUser(u.ID)
|
|
if err != nil {
|
|
t.Fatalf("GetUser: %v", err)
|
|
}
|
|
if got.Email != "reports@hub.example" {
|
|
t.Fatalf("email = %q", got.Email)
|
|
}
|
|
// The account e-mail is the user's own: saving it does not make it anyone's
|
|
// report address, and nothing is mirrored into the instance settings.
|
|
if got.DMARCDefaultMode != DMARCDefaultNone {
|
|
t.Fatalf("dmarc default mode = %q after setting the e-mail, want %q", got.DMARCDefaultMode, DMARCDefaultNone)
|
|
}
|
|
if v, err := st.GetSetting("dmarc_report_email"); err == nil && v != "" {
|
|
t.Fatalf("the e-mail leaked into the instance settings: %q", v)
|
|
}
|
|
|
|
if err := st.UpdateUser(u.ID, "operator", "hash-three", ""); err != nil {
|
|
t.Fatalf("clear e-mail: %v", err)
|
|
}
|
|
got, err = st.GetUser(u.ID)
|
|
if err != nil {
|
|
t.Fatalf("GetUser: %v", err)
|
|
}
|
|
if got.Username != "operator" || got.PasswordHash != "hash-three" {
|
|
t.Fatalf("unexpected user after update: %+v", got)
|
|
}
|
|
if got.CreatedAt.IsZero() {
|
|
t.Fatal("update dropped created_at")
|
|
}
|
|
}
|
|
|
|
func TestUpdateUserWithoutUser(t *testing.T) {
|
|
st := openTestStore(t)
|
|
|
|
if err := st.UpdateUser(1, "operator", "hash", ""); !errors.Is(err, ErrUserNotFound) {
|
|
t.Fatalf("UpdateUser without user = %v, want ErrUserNotFound", err)
|
|
}
|
|
exists, err := st.UserExists()
|
|
if err != nil {
|
|
t.Fatalf("UserExists: %v", err)
|
|
}
|
|
if exists {
|
|
t.Fatal("UpdateUser created a user")
|
|
}
|
|
}
|
|
|
|
func TestCreateDomainAdminUser(t *testing.T) {
|
|
st := openTestStore(t)
|
|
if err := st.CreateGlobalUser("admin", "hash"); err != nil {
|
|
t.Fatalf("CreateGlobalUser: %v", err)
|
|
}
|
|
d, err := st.AddDomain("example.com", "s1")
|
|
if err != nil {
|
|
t.Fatalf("AddDomain: %v", err)
|
|
}
|
|
id, err := st.CreateUser("domainop", "hash2", RoleDomain, []int64{d.ID})
|
|
if err != nil {
|
|
t.Fatalf("CreateUser: %v", err)
|
|
}
|
|
u, err := st.GetUser(id)
|
|
if err != nil {
|
|
t.Fatalf("GetUser: %v", err)
|
|
}
|
|
if len(u.DomainIDs) != 1 || u.DomainIDs[0] != d.ID {
|
|
t.Fatalf("domain ids = %v, want [%d]", u.DomainIDs, d.ID)
|
|
}
|
|
}
|
|
|
|
func TestDeleteLastGlobalUser(t *testing.T) {
|
|
st := openTestStore(t)
|
|
if err := st.CreateGlobalUser("admin", "hash"); err != nil {
|
|
t.Fatalf("CreateGlobalUser: %v", err)
|
|
}
|
|
u, err := st.GetUserByUsername("admin")
|
|
if err != nil {
|
|
t.Fatalf("GetUserByUsername: %v", err)
|
|
}
|
|
if err := st.DeleteUser(u.ID); !errors.Is(err, ErrLastGlobal) {
|
|
t.Fatalf("DeleteUser = %v, want ErrLastGlobal", err)
|
|
}
|
|
}
|