mix
7ef7f75246
Review pass over `1.4.0`…`1.9.1`: port 25 no longer shares the submission milter chain, DMARC reports are validated before they are stored, and the auto rate limit is correct for a non-default level-1 window. Schema migration `0010` (index only). Upgrading is a tag bump. Added: - SQLite migration `0010_send_log_app_login_index.sql` — - DMARC aggregate reports are accepted as **zip** as well as gzip or plain XML - e2e: `checkPort25ConfigCombinations` regenerates the Postfix configuration Changed: - README hero line and a **Positioning** block in `docs/product.md` record the Fixed: - The setup account's password is hashed at bcrypt cost `12` like every other - Login/setup rate limiter: protecting blocked buckets from eviction is now - `postqueue -p` output is bounded to 4 MiB (the timeout alone left the size of - [schema-migrations.md](docs/schema-migrations.md): the schema section was - postqueue reader is now time-bounded: `postqueue -p` runs under a 5-second … (11 more in CHANGELOG) Changed: - [roadmap.md](docs/roadmap.md) now carries everything the 2026-08-19 code - Extracted `internal/configsafe` — the empty-value and forbidden-character - Build, deploy and migration comments no longer cite the archived - Dropped the `parseDomainRateLimitForm` / `parseAppRateLimitForm` pass-through - Extracted shared helpers: `internal/atomicfile` (atomic temp-write+rename) and … (7 more in CHANGELOG) Removed: - Unused legacy asset `docs/assets/icon.png` (superseded by the four brand SVGs - Plan documents for already-shipped features: `domain-stats-auto-ratelimit`, Full detail: CHANGELOG.md (1.9.2).
94 lines
2.8 KiB
Go
94 lines
2.8 KiB
Go
package handlers
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Domain and application limits are parsed by the same function; the form
|
|
// fields and the level-1 backstop are identical for both scopes.
|
|
func TestParseRateLimitForm(t *testing.T) {
|
|
t.Parallel()
|
|
form := func(vals url.Values) *http.Request {
|
|
r := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(vals.Encode()))
|
|
r.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
|
return r
|
|
}
|
|
|
|
in, err := parseRateLimitForm(form(url.Values{
|
|
"mode": {"manual"},
|
|
"max_messages": {"50"},
|
|
"window_seconds": {"3600"},
|
|
}), 100)
|
|
if err != nil || in.clear || in.maxMessages != 50 || in.windowSeconds != 3600 || len(in.ips) != 0 {
|
|
t.Fatalf("valid domain = %+v err=%v", in, err)
|
|
}
|
|
|
|
in, err = parseRateLimitForm(form(url.Values{"max_messages": {""}}), 100)
|
|
if err != nil || !in.clear {
|
|
t.Fatalf("empty max should clear: %+v err=%v", in, err)
|
|
}
|
|
|
|
_, err = parseRateLimitForm(form(url.Values{
|
|
"mode": {"manual"},
|
|
"max_messages": {"150"},
|
|
"window_seconds": {"3600"},
|
|
}), 100)
|
|
if err == nil || !strings.Contains(err.Error(), "level-1") {
|
|
t.Fatalf("over L1 want error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestParseAppAuthIPsForm(t *testing.T) {
|
|
t.Parallel()
|
|
form := func(vals url.Values) *http.Request {
|
|
r := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(vals.Encode()))
|
|
r.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
|
return r
|
|
}
|
|
|
|
restrict, ips, err := parseAppAuthIPsForm(form(url.Values{
|
|
"auth_ip_restrict": {"1"},
|
|
"auth_allowed_ips": {"203.0.113.10"},
|
|
}))
|
|
if err != nil || !restrict || len(ips) != 1 {
|
|
t.Fatalf("enabled with IP = restrict=%v ips=%v err=%v", restrict, ips, err)
|
|
}
|
|
|
|
restrict, ips, err = parseAppAuthIPsForm(form(url.Values{}))
|
|
if err != nil || restrict || ips != nil {
|
|
t.Fatalf("disabled = restrict=%v ips=%v err=%v", restrict, ips, err)
|
|
}
|
|
|
|
_, _, err = parseAppAuthIPsForm(form(url.Values{"auth_ip_restrict": {"1"}}))
|
|
if err == nil || !strings.Contains(err.Error(), "at least one client IP") {
|
|
t.Fatalf("enabled without IPs want error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestParseRateLimitFormAuto(t *testing.T) {
|
|
t.Parallel()
|
|
form := func(vals url.Values) *http.Request {
|
|
r := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(vals.Encode()))
|
|
r.Header.Set("Content-Type", "application/x-www-form-urlencoded")
|
|
return r
|
|
}
|
|
in, err := parseRateLimitForm(form(url.Values{
|
|
"mode": {"auto"},
|
|
"auto_multiplier": {"2.5"},
|
|
}), 100)
|
|
if err != nil || in.mode != "auto" || in.autoMultiplier != 2.5 {
|
|
t.Fatalf("auto domain = %+v err=%v", in, err)
|
|
}
|
|
_, err = parseRateLimitForm(form(url.Values{
|
|
"mode": {"auto"},
|
|
"auto_multiplier": {"10"},
|
|
}), 100)
|
|
if err == nil {
|
|
t.Fatal("multiplier out of range should fail")
|
|
}
|
|
}
|