test / test (push) Canceled after 0s
M17: the supervisord control socket is root:supervisor 0770, a group whose one member is the panel; OpenDKIM and Postfix keep `selfpost` for the files under /data and no longer reach the socket. L30, read in OpenDKIM 2.11.0~beta2's source first: it logs through syslog(3) only and has no Logfile option, and nothing in the container served /dev/log. internal/syslogrelay (the panel binary with -syslog-relay=/run/syslog/log, program syslog-relay before OpenDKIM, /dev/log a link to its socket) passes the datagrams to stdout, error and worse marked. opendkim.conf: Syslog yes, Canonicalization relaxed/simple, OversignHeaders From (RFC 6376 § 3.4, § 8.15). e2e: OpenDKIM's start line reaches the container log; every program RUNNING; DKIM verifies. Tested on the test server: go vet + go test of 26 packages, make e2e (all pass, 626 s) on this tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
144 lines
5.7 KiB
Go
144 lines
5.7 KiB
Go
package e2e
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
// wantRunning are the supervisord programs that must be RUNNING once the
|
|
// container is up (build/supervisord.conf). postfix-reload is deliberately
|
|
// excluded: autostart=false, so it rests STOPPED until its first run and
|
|
// EXITED after it (supervisor 4.2.5, supervisor/process.py,
|
|
// Subprocess.finish(); assumptions C-V10).
|
|
var wantRunning = []string{"syslog-relay", "opendkim", "panel", "postfix", "cert-reload", "logrotate"}
|
|
|
|
// checkSupervisorProcesses shells into the container directly (not through the
|
|
// panel's /overview page) so it works before an administrator account even
|
|
// exists — this is the first thing the harness checks after `docker compose
|
|
// up` (plan C.4). Programs take a moment to leave STARTING right after the
|
|
// container starts - postfix its startsecs, MILTER_WAIT_TIMEOUT plus ten
|
|
// seconds, 20 on this stand - so this polls rather than checking once.
|
|
func checkSupervisorProcesses(s *stack) error {
|
|
var lastErr error
|
|
err := waitFor("all supervised programs to reach their steady state", 60*time.Second, 500*time.Millisecond, func() (bool, error) {
|
|
out, execErr := s.execIn("selfpost", "supervisorctl", "-c", "/etc/supervisor/supervisord.conf", "status")
|
|
// supervisorctl exits non-zero when any program is not RUNNING, which
|
|
// is expected for postfix-reload — parse the output regardless of exit
|
|
// status.
|
|
states := parseSupervisorStatus(out)
|
|
if len(states) == 0 {
|
|
lastErr = fmt.Errorf("supervisorctl status produced nothing to parse: %v\n%s", execErr, out)
|
|
return false, lastErr
|
|
}
|
|
for _, name := range wantRunning {
|
|
state, ok := states[name]
|
|
if !ok {
|
|
lastErr = fmt.Errorf("program %q not reported by supervisorctl:\n%s", name, out)
|
|
return false, lastErr
|
|
}
|
|
if state != "RUNNING" {
|
|
lastErr = fmt.Errorf("program %q is %s, want RUNNING:\n%s", name, state, out)
|
|
return false, lastErr
|
|
}
|
|
}
|
|
if state, ok := states["postfix-reload"]; ok && state != "STOPPED" && state != "EXITED" {
|
|
lastErr = fmt.Errorf("program postfix-reload is %s, want STOPPED or EXITED (autostart=false):\n%s", state, out)
|
|
return false, lastErr
|
|
}
|
|
return true, nil
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("%w\n==== selfpost logs ====\n%s", err, s.logs("selfpost"))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func parseSupervisorStatus(out string) map[string]string {
|
|
states := make(map[string]string)
|
|
for _, line := range strings.Split(out, "\n") {
|
|
fields := strings.Fields(line)
|
|
if len(fields) < 2 {
|
|
continue
|
|
}
|
|
states[fields[0]] = fields[1]
|
|
}
|
|
return states
|
|
}
|
|
|
|
// checkInboundRelayOff asserts the default image does not accept mail on
|
|
// port 25: smtp/inet is absent from master.cf (Debian's stock listener is
|
|
// removed when INBOUND_RELAY_ENABLE is not true). For an absent service
|
|
// postconf -M prints nothing on stdout and "warning: unmatched request" on
|
|
// stderr (Postfix 3.7.11, src/postconf/postconf_master.c,
|
|
// pcf_show_master_entries()).
|
|
func checkInboundRelayOff(s *stack) error {
|
|
out, err := s.execIn("selfpost", "postconf", "-M", "smtp/inet")
|
|
combined := out
|
|
if err != nil {
|
|
combined += err.Error()
|
|
}
|
|
if strings.Contains(combined, "smtpd") && !strings.Contains(combined, "warning:") && !strings.Contains(combined, "fatal:") {
|
|
return fmt.Errorf("inbound smtp/inet is present while INBOUND_RELAY_ENABLE is off:\n%s", out)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// checkCitedPackageVersions compares the Debian packages the image runs with
|
|
// the versions their sources were read at (docs/development.md, the table
|
|
// between the cited-package-versions markers). The image installs unpinned
|
|
// from a moving bookworm, so a point release changes them on a rebuild
|
|
// without anyone reading what changed (assumptions C-D1).
|
|
func checkCitedPackageVersions(s *stack) error {
|
|
doc, err := os.ReadFile(filepath.Join(s.repoRoot, "docs", "development.md"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
text := string(doc)
|
|
start := strings.Index(text, "<!-- cited-package-versions -->")
|
|
end := strings.Index(text, "<!-- /cited-package-versions -->")
|
|
if start < 0 || end < start {
|
|
return fmt.Errorf("docs/development.md has no cited-package-versions table")
|
|
}
|
|
row := regexp.MustCompile("(?m)^[|] `([^`]+)` [|] `([^`]+)` [|]$")
|
|
want := map[string]string{}
|
|
var names []string
|
|
for _, m := range row.FindAllStringSubmatch(text[start:end], -1) {
|
|
want[m[1]] = m[2]
|
|
names = append(names, m[1])
|
|
}
|
|
if len(names) == 0 {
|
|
return fmt.Errorf("the cited-package-versions table lists no package")
|
|
}
|
|
out, err := s.execIn("selfpost", append([]string{"dpkg-query", "-W", "-f", "${Package} ${Version}\n"}, names...)...)
|
|
if err != nil {
|
|
return fmt.Errorf("dpkg-query: %v\n%s", err, out)
|
|
}
|
|
var diffs []string
|
|
for _, line := range strings.Split(strings.TrimSpace(out), "\n") {
|
|
f := strings.Fields(line)
|
|
if len(f) == 2 && want[f[0]] != f[1] {
|
|
diffs = append(diffs, fmt.Sprintf("%s: the image has %s, the citations were read at %s", f[0], f[1], want[f[0]]))
|
|
}
|
|
}
|
|
if len(diffs) > 0 {
|
|
return fmt.Errorf("packages changed under the citations - re-read them (docs/development.md):\n%s", strings.Join(diffs, "\n"))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// checkOpenDKIMLogs waits for OpenDKIM's start line in the container's log:
|
|
// OpenDKIM logs through syslog(3) only, and /dev/log is the syslog-relay
|
|
// program's (audit 2026-10-12, L30). OpenDKIM 2.11.0~beta2,
|
|
// opendkim/opendkim.c: syslog(LOG_INFO, "%s v%s starting%s%s%s",
|
|
// DKIMF_PRODUCT, ...), DKIMF_PRODUCT "OpenDKIM Filter" (opendkim.h).
|
|
func checkOpenDKIMLogs(s *stack) error {
|
|
return waitFor("OpenDKIM's start line in the container log", 20*time.Second, 500*time.Millisecond, func() (bool, error) {
|
|
out := s.logs("selfpost")
|
|
return strings.Contains(out, "opendkim[") && strings.Contains(out, "OpenDKIM Filter v"), fmt.Errorf("no OpenDKIM line in the log")
|
|
})
|
|
}
|