mixandClaude Opus 5.5
6023feb405
test / test (push) Canceled after 0s
The last stage of the 2026-10-12 audit; no cut. Doc drift: architecture.md (the sender check in § OpenDKIM, the limit: row's 48 hours, the inbound log and filter-list routes and who may open them, migrations to 0011 and every table, KitPage as production data, Reload configuration as a restore writes, the panel's roles counted), schema-migrations.md (tables and columns since v2), guide.md (a delivery's lines go at the next prune; INBOUND_JOURNAL_MILTER_SOCKET moved to architecture.md's internal list), development.md (the env guard, the deferral the e2e proves, its fixed sleeps), roadmap.md. Comments say what the code does now; TestBaselineIsTheOnlyMigration is TestChainStartsAtTheBaseline; the milter package doc names its three milters. Dead code gone: view.Facts, dmarc HostedSuggestion and ValidateHostedAddress, app UpdateMode (each with the test that alone kept it), the method checks the method-bound routes made dead; Settings.WithResult calls resultFlash. staticcheck 2026.1 in test.yml on both modules, clean: the e2e package builds without its tests now (a test and two constants moved out of non-test files), three findings fixed. The test moved, TestImageBuildPreservesLogrotateMode, had sat in a non-test file and never run; run, it failed on the entrypoint (docker run without a hostname) and now asks with --entrypoint stat. The test gaps no step named, each closed: follow() with mail.log gone past blindMin and made again; CheckRestore with a manifest that is not JSON; the origin check with a port; every /server/ pattern in web.go through server() and in the routes table (it found GET /server/health/fragment missing from the table - guarded, not tested); L9 as the owner decided it on 2026-10-12, the comment on senderSession.Headers and the test passing an h that holds the earlier messages' From:. Plan stage 6 ticked; roadmap audit row done, 81/81. Tested on the test server: go vet + go test of 27 packages, make e2e (all pass, 513 s) on this tree; staticcheck locally on both modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
60 lines
2.4 KiB
Go
60 lines
2.4 KiB
Go
package e2e
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
)
|
|
|
|
// checkLogrotateConfigMode verifies the image pins /etc/logrotate.d/mail at 0644
|
|
// so logrotate will not silently ignore it (docs/development.md § Building
|
|
// binaries and the image).
|
|
func checkLogrotateConfigMode(s *stack) error {
|
|
mode, err := s.execIn("selfpost", "stat", "-c", "%a", "/etc/logrotate.d/mail")
|
|
if err != nil {
|
|
return fmt.Errorf("stat logrotate config: %w", err)
|
|
}
|
|
mode = strings.TrimSpace(mode)
|
|
if mode != "644" {
|
|
return fmt.Errorf("/etc/logrotate.d/mail mode is %q, want 644", mode)
|
|
}
|
|
// The state file is beside the log, under /data, so a recreated container
|
|
// keeps when mail.log was last rotated (audit 2026-10-12, M19); the loop
|
|
// runs logrotate at once when it starts.
|
|
return waitFor("logrotate's state under /data/log", 20*time.Second, 500*time.Millisecond, func() (bool, error) {
|
|
out, _ := s.execIn("selfpost", "sh", "-c", "test -s /data/log/.logrotate.status && echo yes")
|
|
out = strings.TrimSpace(out)
|
|
return out == "yes", fmt.Errorf("state file: %q", out)
|
|
})
|
|
}
|
|
|
|
// checkLogrotateRotation forces a rotation and checks the recreated mail.log is
|
|
// panel-readable (0640 postfix:selfpost per build/logrotate-mail.conf).
|
|
func checkLogrotateRotation(s *stack) error {
|
|
const logPath = "/data/log/mail.log"
|
|
marker := "e2e-logrotate-marker\n"
|
|
if _, err := s.execIn("selfpost", "sh", "-c",
|
|
fmt.Sprintf("printf %q >> %s", marker, logPath)); err != nil {
|
|
return fmt.Errorf("write mail.log: %w", err)
|
|
}
|
|
if _, err := s.execIn("selfpost", "logrotate", "-f", "/etc/logrotate.d/mail"); err != nil {
|
|
return fmt.Errorf("logrotate -f: %w", err)
|
|
}
|
|
rotated, err := s.execIn("selfpost", "sh", "-c", "test -f /data/log/mail.log.1 && echo yes")
|
|
if err != nil || strings.TrimSpace(rotated) != "yes" {
|
|
return fmt.Errorf("expected /data/log/mail.log.1 after forced rotation (out=%q err=%v)", rotated, err)
|
|
}
|
|
mode, err := s.execIn("selfpost", "stat", "-c", "%a", logPath)
|
|
if err != nil {
|
|
return fmt.Errorf("stat rotated mail.log: %w", err)
|
|
}
|
|
if strings.TrimSpace(mode) != "640" {
|
|
return fmt.Errorf("new %s mode is %q, want 640", logPath, strings.TrimSpace(mode))
|
|
}
|
|
body, err := s.execIn("selfpost", "grep", "-F", strings.TrimSpace(marker), "/data/log/mail.log.1")
|
|
if err != nil || !strings.Contains(body, strings.TrimSpace(marker)) {
|
|
return fmt.Errorf("rotated file does not contain marker (out=%q err=%v)", body, err)
|
|
}
|
|
return nil
|
|
}
|