mixandClaude Opus 5.5
be98efa549
The owner's "проверь, что документация актуальна с кодом" (2026-10-16).
Read-only reviews checked every present-tense claim against the code;
each finding was read in the source before it was fixed here.
architecture.md: held inbound mail has its row from the journal milter,
not the tailer; the antispam action is accept or tempfail, anything else
stops the start; tls-internal's certificate is 0644; the signer logs to
stderr; the log's fingerprint is the inode, not the device; a mail.log
postlogd makes is 0640 (maillog_file_permissions); an unreadable stored
place starts at end-of-file too; the test-message route; no map in page
data; design-first compares whitespace aside; the queue and sasldb2.new
are not backed up; antispam/ under /data; POSTFIX_QUEUE_DIR's desync;
SELFPOST_BACKUP_PASSWORD (the CLI's).
schema-migrations.md: inbound_spam_log's upstream columns (v12),
send_log's sender reason, row 9's client_ip.
security.md: /data/opendkim since 2.9.0 (removed, or the start refused),
sasldb2 under /data/sasl, the trigger for mandatory encryption, the
password minimum counted in characters.
development.md: Staticcheck in CI, the e2e ports 20025 and 20053/udp.
README: the client IP list refuses at MAIL FROM, overrides are per
application. product.md: the optional rspamd sidecar.
Code: validate.AdminPassword counted bytes, so six Cyrillic letters
passed for twelve characters; it counts runes, as the backup password
always did (TestAdminPasswordCountsCharacters). envdoc reads
cmd/selfpost-backup too, and a name kept in a constant. A stale comment
of cmd/panel's run ("three roles").
go vet + go test (26 packages) and make e2e on the test server for this
tree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
79 lines
1.7 KiB
Go
79 lines
1.7 KiB
Go
package validate
|
|
|
|
import "testing"
|
|
|
|
func TestNormalizeDomain(t *testing.T) {
|
|
cases := map[string]string{
|
|
" Example.COM ": "example.com",
|
|
"MAIL.Example.Org": "mail.example.org",
|
|
"example.com": "example.com",
|
|
}
|
|
for in, want := range cases {
|
|
if got := NormalizeDomain(in); got != want {
|
|
t.Errorf("NormalizeDomain(%q) = %q, want %q", in, got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainValid(t *testing.T) {
|
|
valid := []string{
|
|
"example.com",
|
|
"mail.example.com",
|
|
"a.co",
|
|
"sub-domain.example.co.uk",
|
|
"x1.y2.z3",
|
|
"1example.com",
|
|
}
|
|
for _, d := range valid {
|
|
if err := Domain(d); err != nil {
|
|
t.Errorf("Domain(%q) unexpected error: %v", d, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainInvalid(t *testing.T) {
|
|
invalid := []string{
|
|
"",
|
|
"localhost",
|
|
"example",
|
|
".example.com",
|
|
"example.com.",
|
|
"exa mple.com",
|
|
"example..com",
|
|
"-example.com",
|
|
"example-.com",
|
|
"example.com\n",
|
|
"exa*mple.com",
|
|
"exa_mple.com",
|
|
"Example.com",
|
|
"пример.рф",
|
|
"example.c/m",
|
|
}
|
|
for _, d := range invalid {
|
|
if err := Domain(d); err == nil {
|
|
t.Errorf("Domain(%q) = nil, want error", d)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainLongLabelRejected(t *testing.T) {
|
|
label := make([]byte, 64)
|
|
for i := range label {
|
|
label[i] = 'a'
|
|
}
|
|
if err := Domain(string(label) + ".com"); err == nil {
|
|
t.Error("expected error for over-long label")
|
|
}
|
|
}
|
|
|
|
// The minimum counts characters, not bytes: six Cyrillic letters are twelve
|
|
// bytes and six characters.
|
|
func TestAdminPasswordCountsCharacters(t *testing.T) {
|
|
if err := AdminPassword("пароль"); err == nil {
|
|
t.Error("six Cyrillic letters passed for twelve characters")
|
|
}
|
|
if err := AdminPassword("парольпароль"); err != nil {
|
|
t.Errorf("twelve Cyrillic letters: %v", err)
|
|
}
|
|
}
|