mix
18da021526
Phase 11 of PROJECT_REVIEW_PLAN.md: the themed cleanup pass over every low-severity finding still open (2.2-2.3, 3.4-3.6, 4.3-4.7, 6.4-6.7, 7.1-7.3, 8.2-8.3, 9.1-9.4, and the under-documented decisions in §10/§11). Behavioral fixes: - Reassign duplicate job IDs in a hand-edited jobs.json instead of letting two jobs share one runtime, schedule entry, and SeedStats bucket. - Disambiguate run-log file names that collide within the same second. - Compute AvgDurationMS as DurationSumMS/TimedRunCount instead of an incremental integer mean, so it always matches the seeded-from-logs average instead of drifting from truncation error. - Clean absolute paths in ResolveConfiguredPath so two spellings of the same jobs file do not trigger a spurious adoption. - Report InstallDesktopIcon failures through ErrorOccurred instead of discarding them silently. - Move settingsView's blocking AutostartStatus (PowerShell on Windows) off the UI thread. - Give notify-timing.tsv its own extension so CleanupLogs no longer manages it as a run log. - Replace the settingsView Save handler's second copy of validateConfig's rules with a bare parse, letting the Service's own error surface. Cleanups: - Delete collectActivity, the dead yaml tags on RunRecord, and the logArguments/LogArguments alias. - Fold the two systemTrayRegistered/mainWindowHidden globals into one trayState instance Run owns and threads through Settings and the single-instance reveal path. - Fix stale comments/docs: the frozen window-size restore claim, a reference to a renamed recordRun, README's "Pause all" and notification wording, the PowerShell quoting note for TESTS.md's coverage command, and scripts/test.bat's UTF-8 checkmarks under a non-UTF-8 code page. - Document the single-instance fallback's consequence and the unauthenticated instance-channel port in STANDARDS.md; record the config-shim retirement plan in ROADMAP.md. 3.5, 7.3, and 9.4 turned out to already be fixed by earlier phases; no change needed for those three. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
43 lines
1.2 KiB
Batchfile
43 lines
1.2 KiB
Batchfile
@echo off
|
|
setlocal enabledelayedexpansion
|
|
REM GoSentry test runner
|
|
REM Runs go vet and go test with race detection
|
|
|
|
REM Move to repository root
|
|
cd /d "%~dp0\.."
|
|
|
|
REM This file is UTF-8 (the ✓/✗ below). cmd.exe reads batch files in the
|
|
REM console's active code page, which defaults to the system locale (e.g.
|
|
REM CP866 on Russian Windows) rather than UTF-8, so without this the two
|
|
REM symbols render as mojibake. Switching the console to UTF-8 first fixes
|
|
REM that; >nul silences chcp's own "Active code page" confirmation line.
|
|
chcp 65001 >nul
|
|
|
|
REM Fyne uses native libraries through CGO. MSYS2 UCRT64 provides the GCC toolchain
|
|
REM expected by the Windows build; prepending it keeps the script self-contained
|
|
REM without permanently changing the user's system PATH.
|
|
if exist "C:\msys64\ucrt64\bin" set "PATH=C:\msys64\ucrt64\bin;%PATH%"
|
|
|
|
REM Race detector requires CGO
|
|
set "CGO_ENABLED=1"
|
|
|
|
echo Running go vet...
|
|
go vet ./...
|
|
if errorlevel 1 (
|
|
echo.
|
|
echo ✗ go vet failed
|
|
exit /b 1
|
|
)
|
|
|
|
echo.
|
|
echo Running go test with race detection...
|
|
go test -race ./...
|
|
if errorlevel 1 (
|
|
echo.
|
|
echo ✗ go test failed
|
|
exit /b 1
|
|
)
|
|
|
|
echo.
|
|
echo ✓ All tests passed
|