2 Commits

Include renames

Author	SHA1	Message	Date
mixandClaude Opus 5.5	a39eda5a0b	audit 5: findings of the two reviews ... - The e2e's numeric-settings test ran a container that passed every gate and never ended: the good values are checked beside a bad one after them; each run is named, bounded to a minute and removed. - The gates refuse a value under the parameter's minimum (a zero window kills anvil, a zero milter timeout smtpd) and one past an int, in seconds for a time value (src/global/conv_time.c, src/anvil/anvil.c). - OpenDKIM waits, five seconds at most, for the relay's socket. - The relay marks its lines `syslog: `, writes control characters out, reads into a queue at once and drops past 200 lines a second, saying how many (security F1, F2; a stuck relay would hold OpenDKIM in syslog(3)). - smtp_tls_mandatory_protocols >=TLSv1.2 too. - extract-cert.sh keeps the old files' group and sets its trap before mktemp. - crashexit spares cert-reload; architecture.md "four times running" and what else exits the container; security.md the restart after five panel exits and the /dev/log socket. - Measured against the technical review: smtpd has the selfpost group (Groups 104 998), so it did reach the supervisor socket before this stage. Accepted, reasons in the plan: the logrotate state file in the postfix user's directory, envdoc_test's reading of `${VAR:-}` only, crashexit's window pruning untested. Tested on the test server: go vet + go test of 27 packages, make e2e (all pass, 592 s) on this tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-15 13:53:14 +03:00
mixandClaude Opus 5.5	dab7715e80	audit 5: the supervisor socket the panel's alone, OpenDKIM logs and oversigns From ... M17: the supervisord control socket is root:supervisor 0770, a group whose one member is the panel; OpenDKIM and Postfix keep `selfpost` for the files under /data and no longer reach the socket. L30, read in OpenDKIM 2.11.0~beta2's source first: it logs through syslog(3) only and has no Logfile option, and nothing in the container served /dev/log. internal/syslogrelay (the panel binary with -syslog-relay=/run/syslog/log, program syslog-relay before OpenDKIM, /dev/log a link to its socket) passes the datagrams to stdout, error and worse marked. opendkim.conf: Syslog yes, Canonicalization relaxed/simple, OversignHeaders From (RFC 6376 § 3.4, § 8.15). e2e: OpenDKIM's start line reaches the container log; every program RUNNING; DKIM verifies. Tested on the test server: go vet + go test of 26 packages, make e2e (all pass, 626 s) on this tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-15 13:07:28 +03:00