mixandClaude Opus 5.5
ef18ef21a0
test / test (push) Canceled after 0s
Technical review (Opus) and security review (Fable) of a59e3d4..cb5a4a2;
reports in the session's scratchpad. Nothing critical, high or medium; no
outright bug. Fixed:
- F2, F3 (0008 backfill, before it runs on the live database): rows are
filled by the rule new rows follow - the application's domain, then the
name's - and only by a domain and application that existed when the row
was written (created_at); the inbound log likewise. Test: the migration's
UPDATEs re-run on prepared rows (before the domain, after, null sender,
application gone, a stranger's name). Dry run on a copy of the live
database: 68/68 and 10/10 rows filled, none disagreeing with its login's
domain, integrity ok.
- V2, F4: an application's statistics and level-2 count are its login's
rows of its domain (appByLogin), and StatsWindow starts no earlier than
the entity's creation; the message page's "may send as" only for a login
still of the row's domain. Test: a login taken again in another domain
starts at zero.
- F7: MAIL FROM:<> is held to the domain limit of its login
(ApplicationByLogin fills DomainName).
- V3: an imported DKIM selector is held to DNS labels (validate.Selector).
- F5, F6: an imported auto limit's numbers are dropped and recalculated
right after the import; its mode is stored trimmed.
- V6: the store refuses a role that is neither global nor domain.
- F9: SaveUser keeps the stored hash when no new password is given (the
form no longer writes back the hash it read). F10: a reach naming a
domain deleted meanwhile is ErrNoSuchDomain, answered on the form.
- V4, F12: from-lines-other.txt - lines naming another sender ({other}) in
a quoted string, a quoted pair, capitals, a comment, an encoded word, a
quoted local part; the unit test wants each refused, the e2e
(lines_naming_another_sender_never_signed_for_it) wants each refused and
none signed for it. The passed list gained a.{DOMAIN}, a comment after
the angle address, a quoted local part, and "b@ {other}" - passed by
design (security.md), and the e2e shows it signed for the own domain.
- F13: e2e login_in_other_capitals_does_not_authenticate - AUTH with the
login upper-cased gets 535.
Not changed, written down: V1/F1 - L8 is half closed (refused or passed
still tells an application which domains are hosted here); security.md's
accepted risks and the CHANGELOG say so, and the owner is asked whether to
refuse every foreign address in a display name (changes the 2.4.0 rule).
F11 - deleting a domain rewrites its rows' domain_id (seconds at 1e5 rows),
accepted at this size. F8 (test cannot tell write-first from read-first;
the reviewer verified it with two stores, 30/30), V5, V7, P2: noted.
Evidence on the test server for this tree: go vet clean, go test ./... 23
packages ok, make e2e exit 0 with the three new cases.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
83 lines
2.4 KiB
Go
83 lines
2.4 KiB
Go
package store
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestSendStatsTotalPeakAvg(t *testing.T) {
|
|
st := openTestStore(t)
|
|
d, err := st.AddDomain("example.com", "selfpost")
|
|
if err != nil {
|
|
t.Fatalf("AddDomain: %v", err)
|
|
}
|
|
a, err := st.AddApplication(d.ID, "app1", AddressModeWildcard, nil)
|
|
if err != nil {
|
|
t.Fatalf("AddApplication: %v", err)
|
|
}
|
|
|
|
now := time.Now().UTC()
|
|
hour := now.Format("2006-01-02T15")
|
|
prevHour := now.Add(-2 * time.Hour).Format("2006-01-02T15")
|
|
// Both were created before the messages below: statistics start at the
|
|
// entity's creation.
|
|
created := now.Add(-3 * time.Hour)
|
|
d.CreatedAt, a.CreatedAt = created, created
|
|
|
|
// Hour 1: two messages (Q1 two recipients + Q2).
|
|
for _, to := range []string{"a@x.net", "b@x.net"} {
|
|
if err := st.InsertQueued(SendLogEntry{QueueID: "Q1", Domain: "example.com", AppLogin: "app1", To: to}); err != nil {
|
|
t.Fatalf("InsertQueued: %v", err)
|
|
}
|
|
}
|
|
if err := st.InsertQueued(SendLogEntry{QueueID: "Q2", Domain: "example.com", AppLogin: "app1", To: "c@x.net"}); err != nil {
|
|
t.Fatalf("InsertQueued: %v", err)
|
|
}
|
|
// Hour 2: one message.
|
|
if _, err := st.db.Exec(`UPDATE send_log SET created_at = ? WHERE queue_id = 'Q2'`,
|
|
prevHour+":00:00Z"); err != nil {
|
|
t.Fatalf("backdate Q2: %v", err)
|
|
}
|
|
if _, err := st.db.Exec(`UPDATE send_log SET created_at = ? WHERE queue_id = 'Q1'`,
|
|
hour+":10:00Z"); err != nil {
|
|
t.Fatalf("backdate Q1: %v", err)
|
|
}
|
|
if err := st.InsertRejected(SendLogEntry{Domain: "example.com", AppLogin: "app1"}); err != nil {
|
|
t.Fatalf("InsertRejected: %v", err)
|
|
}
|
|
|
|
stats, err := st.DomainSendStats("example.com", 90, d.CreatedAt)
|
|
if err != nil {
|
|
t.Fatalf("DomainSendStats: %v", err)
|
|
}
|
|
if stats.Total != 2 {
|
|
t.Fatalf("total = %d, want 2", stats.Total)
|
|
}
|
|
if stats.PeakPerHour != 1 {
|
|
t.Fatalf("peak = %d, want 1 (one message per hour bucket)", stats.PeakPerHour)
|
|
}
|
|
if stats.AvgPerHour <= 0 {
|
|
t.Fatalf("avg should be positive, got %v", stats.AvgPerHour)
|
|
}
|
|
|
|
appStats, err := st.AppSendStats("app1", 90, a.CreatedAt)
|
|
if err != nil {
|
|
t.Fatalf("AppSendStats: %v", err)
|
|
}
|
|
if appStats.Total != 2 {
|
|
t.Fatalf("app total = %d, want 2", appStats.Total)
|
|
}
|
|
}
|
|
|
|
func TestStatsWindowShortRetention(t *testing.T) {
|
|
st := openTestStore(t)
|
|
d, _ := st.AddDomain("example.com", "selfpost")
|
|
stats, err := st.DomainSendStats("example.com", 7, d.CreatedAt)
|
|
if err != nil {
|
|
t.Fatalf("DomainSendStats: %v", err)
|
|
}
|
|
if stats.WindowDays != 7 {
|
|
t.Fatalf("window days = %d, want 7", stats.WindowDays)
|
|
}
|
|
}
|