mixandClaude Opus 5
23d52bab7c
test / test (push) Has been cancelled
Review pass over the 1.4.0-1.9.1 work. Port 25 no longer inherits main.cf's submission milter chain: smtpd_milters is always overridden on smtp/inet, to the antispam milter or to nothing. Without that, OpenDKIM (strict, tempfail) gated relayed mail during a signing outage, and the journal-milter filed inbound mail into the outbound send log under the sender's domain -- so Deliveries showed other people's mail and a forged From: consumed that domain's level-2 budget. architecture.md already described the intended behaviour; the code now matches. DMARC reports are checked before they are stored: the policy domain must be a configured sending domain, and must match the +tag of a per-domain hosted address. The rua address form is predictable, so anyone able to reach it could file reports under any domain and evict genuine ones through the retention cap. Zip attachments are now decompressed as well as gzip. The auto level-2 ceiling is scaled to the level-1 window before the multiplier is applied; any window other than 3600s shifted the allowance by window/3600. Migration 0010 indexes send_log(app_login, created_at) -- both the per-MAIL FROM rate-limit count and the per-application statistics were scanning the created_at range. e2e now regenerates the Postfix config in-container for all four port-25 flag combinations and requires postfix check to pass; the 1.9.1 crash-loop shipped in 1.4.0 and survived three releases because only the flags-off path was exercised. Migration 0009 stays as shipped -- its conversion branch only fires for a database carrying application-scope allowed_ips from before 1.9.0. The schema reference notes that the old list was permissive and the new column is restrictive; the guide documents the allow-list as a sending control on a fail-open path, not an authentication boundary. Also: gofmt across cmd/ and internal/, unused duplicate validators dropped from internal/web/validate, export no longer swallows store errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
68 lines
1.3 KiB
Go
68 lines
1.3 KiB
Go
package validate
|
|
|
|
import "testing"
|
|
|
|
func TestNormalizeDomain(t *testing.T) {
|
|
cases := map[string]string{
|
|
" Example.COM ": "example.com",
|
|
"MAIL.Example.Org": "mail.example.org",
|
|
"example.com": "example.com",
|
|
}
|
|
for in, want := range cases {
|
|
if got := NormalizeDomain(in); got != want {
|
|
t.Errorf("NormalizeDomain(%q) = %q, want %q", in, got, want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainValid(t *testing.T) {
|
|
valid := []string{
|
|
"example.com",
|
|
"mail.example.com",
|
|
"a.co",
|
|
"sub-domain.example.co.uk",
|
|
"x1.y2.z3",
|
|
"1example.com",
|
|
}
|
|
for _, d := range valid {
|
|
if err := Domain(d); err != nil {
|
|
t.Errorf("Domain(%q) unexpected error: %v", d, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainInvalid(t *testing.T) {
|
|
invalid := []string{
|
|
"",
|
|
"localhost",
|
|
"example",
|
|
".example.com",
|
|
"example.com.",
|
|
"exa mple.com",
|
|
"example..com",
|
|
"-example.com",
|
|
"example-.com",
|
|
"example.com\n",
|
|
"exa*mple.com",
|
|
"exa_mple.com",
|
|
"Example.com",
|
|
"пример.рф",
|
|
"example.c/m",
|
|
}
|
|
for _, d := range invalid {
|
|
if err := Domain(d); err == nil {
|
|
t.Errorf("Domain(%q) = nil, want error", d)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestValidateDomainLongLabelRejected(t *testing.T) {
|
|
label := make([]byte, 64)
|
|
for i := range label {
|
|
label[i] = 'a'
|
|
}
|
|
if err := Domain(string(label) + ".com"); err == nil {
|
|
t.Error("expected error for over-long label")
|
|
}
|
|
}
|