7b4549a35d
Phase 13. Two new packages and one new screen. internal/health owns the shared status vocabulary (ok/warn/error/unknown) and the local checks: supervisord's process table, TLS certificate expiry and the two milter sockets. Each check reports a problem as a status rather than an error, so one broken component costs a line and not the page. internal/dnscheck does the read-only lookups: forward-confirmed reverse DNS for SELFPOST_HOSTNAME, and per-domain DKIM (compared against the key this server actually signs with), SPF and DMARC. Every check is bounded by a timeout and cached, and the resolver sits behind an interface so the tests drive every branch without touching the network. The SPF check is deliberately shallow: it looks for a mechanism literally covering the server's address and does not follow include:/redirect=, so a record that authorises us through an include is reported as "cannot tell" rather than as a failure. /status renders both, with the local checks in an HTMX-polled fragment and the DNS lookups behind a Re-check button, and becomes the panel's landing page: / now redirects there and the domain list lives at /domains. The Reload button moves onto /status, where it reads as what it is — a drift-recovery for the daemons — with text explaining what it regenerates. A template test fails on any remaining href="/" so a stale link cannot silently land on the wrong screen. Also fixes a defect this made visible: the panel could never read the mail queue in the documented deployment. postqueue relies on its setgid-postdrop bit, which the compose file's no-new-privileges disables, so the Queue screen always said "Could not read the mail queue" — including in the released 1.0.0 image. The panel user is now a real member of postdrop, which needs no setgid transition. Verified in a container on the dev server against real DNS: PTR matching (selfpost.example.com) and not matching (example.com), DKIM absent and mismatched, SPF absent and via include:, DMARC p=quarantine/p=reject/absent, and a resolver timeout degrading to "unknown" without hanging the page. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
131 lines
4.2 KiB
Go
131 lines
4.2 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"codeberg.org/mix/selfpost/internal/health"
|
|
)
|
|
|
|
// checkDKIM compares the TXT record published at <selector>._domainkey.<domain>
|
|
// with the key this server signs with. A wrong or absent record means every
|
|
// message fails DKIM at the receiver, so both are errors.
|
|
func (c *Checker) checkDKIM(ctx context.Context, q Query) Result {
|
|
name := q.Selector + "._domainkey." + q.Name
|
|
txt, found, err := c.lookupTXT(ctx, name)
|
|
if err != nil {
|
|
return lookupFailed("the DKIM record", err)
|
|
}
|
|
|
|
expected := publicKeyTag(q.ExpectedDKIM)
|
|
if !found {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("No TXT record is published at %s. Publish the record shown above — until then every message fails DKIM.", name),
|
|
}
|
|
}
|
|
|
|
for _, rec := range txt {
|
|
got := publicKeyTag(rec)
|
|
if got == "" {
|
|
continue
|
|
}
|
|
if got == expected {
|
|
return Result{
|
|
Status: health.StatusOK,
|
|
Detail: fmt.Sprintf("Published at %s and matching the key this server signs with.", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
}
|
|
|
|
// Something is published, but it is not our key. Separate the revoked case
|
|
// (empty p=), which reads as a deliberate act rather than a typo.
|
|
for _, rec := range txt {
|
|
if v, ok := tagValue(rec, "p"); ok && v == "" {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("The record at %s has an empty p= tag, which revokes the key. Replace it with the record shown above.", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
}
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("A TXT record exists at %s but its public key is not the one this server signs with — mail will fail DKIM. Replace it with the record shown above (an old record from a previous server is the usual cause).", name),
|
|
Records: txt,
|
|
}
|
|
}
|
|
|
|
// checkDMARC reports whether the domain publishes a DMARC policy. DMARC is not
|
|
// required for delivery, so its absence is advice (warn), not a fault.
|
|
func (c *Checker) checkDMARC(ctx context.Context, domainName string) Result {
|
|
name := "_dmarc." + domainName
|
|
txt, found, err := c.lookupTXT(ctx, name)
|
|
if err != nil {
|
|
return lookupFailed("the DMARC record", err)
|
|
}
|
|
|
|
var records []string
|
|
for _, rec := range txt {
|
|
if strings.HasPrefix(strings.ToLower(strings.TrimSpace(rec)), "v=dmarc1") {
|
|
records = append(records, rec)
|
|
}
|
|
}
|
|
if !found || len(records) == 0 {
|
|
return Result{
|
|
Status: health.StatusWarn,
|
|
Detail: fmt.Sprintf("No DMARC record at %s. Delivery works without one, but publishing at least \"v=DMARC1; p=none; rua=mailto:you@%s\" tells receivers what to do with mail that fails DKIM and gets you reports.", name, domainName),
|
|
}
|
|
}
|
|
if len(records) > 1 {
|
|
return Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("More than one DMARC record is published at %s. Receivers treat that as no policy at all — keep exactly one.", name),
|
|
Records: records,
|
|
}
|
|
}
|
|
|
|
policy, ok := tagValue(records[0], "p")
|
|
if !ok || policy == "" {
|
|
return Result{
|
|
Status: health.StatusWarn,
|
|
Detail: "A DMARC record is published but has no p= policy tag, so receivers ignore it. Add p=none, p=quarantine or p=reject.",
|
|
Records: records,
|
|
}
|
|
}
|
|
detail := fmt.Sprintf("Published with policy p=%s.", policy)
|
|
if strings.EqualFold(policy, "none") {
|
|
detail += " That is monitoring only — tighten it to quarantine or reject once the reports look clean."
|
|
}
|
|
return Result{Status: health.StatusOK, Detail: detail, Records: records}
|
|
}
|
|
|
|
// publicKeyTag extracts the p= (public key) tag of a DKIM record, with all
|
|
// whitespace removed: DNS providers and TXT chunking freely insert spaces and
|
|
// line breaks into the base64, none of which are part of the key.
|
|
func publicKeyTag(record string) string {
|
|
v, ok := tagValue(record, "p")
|
|
if !ok {
|
|
return ""
|
|
}
|
|
return strings.Join(strings.Fields(v), "")
|
|
}
|
|
|
|
// tagValue reads one tag from a DKIM/DMARC-style "tag=value; tag=value" record.
|
|
// Tag names are case-sensitive per RFC 6376/7489, and values keep their case.
|
|
func tagValue(record, tag string) (string, bool) {
|
|
for _, part := range strings.Split(record, ";") {
|
|
part = strings.TrimSpace(part)
|
|
key, value, found := strings.Cut(part, "=")
|
|
if !found {
|
|
continue
|
|
}
|
|
if strings.TrimSpace(key) == tag {
|
|
return strings.TrimSpace(value), true
|
|
}
|
|
}
|
|
return "", false
|
|
}
|