mixandClaude Opus 5.5
1c6e04b7d3
test / test (push) Canceled after 0s
The runtime base is debian:trixie-slim, the build stage golang:1.26-trixie:
Postfix 3.10.13 with upstream's 2026 security fixes up to the August
batch, libmilter 8.18.1, OpenSSL 3.5. Every citation of another program in
code, scripts and documents was re-read against the trixie sources
(dev/upstream; bookworm's kept in dev/upstream-bookworm) and updated;
development.md's cited-package table holds the trixie versions.
What the re-reading changed in behaviour:
- logtail: reject lines with sasl_method/sasl_username/sasl_sender
(smtpd_check.c:1019-1026); cleanup's "removed (canceled)" forgets a
port-25 id (cleanup_api.c:363-364).
- internal/postfix/retry.go reads postconf's stdout only: since 3.9 a
deprecated-parameter warning on stderr made one value too many and the
panel fell back to the compiled-in retry policy.
- logrotate-loop.sh: logrotate 3.22 exits 1 when it ignores a config;
the loop refuses on that output whatever the status.
- postfix-config.sh: cyrus_sasl_config_path set explicitly (bookworm's
07_sasl_config.diff is gone); maillog_file_permissions=0640; mynetworks
explicit; Dockerfile: SYNC_CHROOT= in /etc/default/postfix,
opendkim-tools dropped, openssl named, systemd-standalone-sysusers so
cron does not bring the whole of systemd.
- The selfpost group is 10998, outside the system range 100-999: in
trixie a package took 998 and the build failed (owner's decision:
a conflict-free id, the distribution's own ids untouched). The
entrypoint hands /data back by name when the user or the group differs.
Guide, backup refusal text, help (design commit 68ec8b2), e2e.
- smtpd_hide_client_session=yes on smtps and submission (owner's
decision): Received: names no client, TLS, login or protocol; port 25
keeps the full header. e2e checks both.
- test/upstream/opendkim-probe.sh makes keys with openssl genrsa.
Tests: on the server, make e2e exit 0 (674 s, the image built on trixie),
go vet + go test 27 packages ok. CHANGELOG [Unreleased], guide,
architecture.md, security.md, roadmap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
73 lines
1.9 KiB
Go
73 lines
1.9 KiB
Go
package postfix
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Postfix 3.10.13, src/global/conv_time.c, conv_time(): one number, one
|
|
// lower-case unit, the default unit when there is none, the rest ignored.
|
|
func TestParseTime(t *testing.T) {
|
|
cases := []struct {
|
|
in string
|
|
unit byte
|
|
want time.Duration
|
|
}{
|
|
{"5d", 's', 5 * 24 * time.Hour},
|
|
{"300s", 'd', 300 * time.Second},
|
|
{"4000s", 's', 4000 * time.Second},
|
|
{"1h", 's', time.Hour},
|
|
{"0", 's', 0},
|
|
{"0s", 's', 0},
|
|
{"300", 's', 300 * time.Second},
|
|
{"3", 'd', 3 * 24 * time.Hour}, // maximal_queue_lifetime = 3
|
|
{"2", 'h', 2 * time.Hour}, // delay_warning_time = 2
|
|
{" 300s ", 's', 300 * time.Second},
|
|
{"+5m", 's', 5 * time.Minute},
|
|
{"1h7m", 's', time.Hour}, // what follows the unit is ignored
|
|
{"1h 5x", 's', time.Hour},
|
|
{"1w", 's', 7 * 24 * time.Hour},
|
|
{"2m", 's', 2 * time.Minute},
|
|
{"s", 'd', 0}, // strtol() reads nothing and stops at the "s"
|
|
}
|
|
for _, tc := range cases {
|
|
got, err := ParseTime(tc.in, tc.unit)
|
|
if err != nil {
|
|
t.Errorf("ParseTime(%q, %c): %v", tc.in, tc.unit, err)
|
|
continue
|
|
}
|
|
if got != tc.want {
|
|
t.Errorf("ParseTime(%q, %c) = %v, want %v", tc.in, tc.unit, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseTimeRejectsInvalid(t *testing.T) {
|
|
for _, in := range []string{"", "foo", "5x", "-300s", "5D", "1H", " s", "99999999999s", "400000w"} {
|
|
if _, err := ParseTime(in, 's'); err == nil {
|
|
t.Errorf("ParseTime(%q) = nil, want error", in)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestFormatDuration(t *testing.T) {
|
|
cases := []struct {
|
|
in time.Duration
|
|
want string
|
|
}{
|
|
{5 * 24 * time.Hour, "5 days"},
|
|
{300 * time.Second, "5 minutes"},
|
|
{4000 * time.Second, "about 1 hour 7 minutes"},
|
|
{time.Hour, "1 hour"},
|
|
{0, "0 seconds"},
|
|
{time.Second, "1 second"},
|
|
{2 * time.Minute, "2 minutes"},
|
|
{24 * time.Hour, "1 day"},
|
|
}
|
|
for _, tc := range cases {
|
|
if got := FormatDuration(tc.in); got != tc.want {
|
|
t.Errorf("FormatDuration(%v) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
}
|