c0d9aa7518
Codeberg is being retired as the project's public site, so every reference now points at GitHub. That includes the Go module path (codeberg.org/mix/selfpost → github.com/mixeme/selfpost): leaving an import path on a host that is going away would break `go get` and `go install`, so this is not only a docs change. Touches go.mod, test/e2e/go.mod, all imports, Makefile MODULE, the -ldflags version stamp in build/Dockerfile and docs/development.md, the licence headers in the SVG/HTML assets, and README (no more primary/mirror pair). Comments no longer cite the archived specification. "spec 7.6.1", "spec 5.1" and friends pointed into docs/archive/specification-v1.0.md, which is marked as not a source of truth; each is now a reference to the live document that owns the subject — architecture.md (with section), product.md, security.md or the README. The review only asked for the 7.x refs (code-review.md § 4), but 4/5/6/ 8/9 had the same defect, so they went too. Comments only, no behaviour change. Also closes the remaining review items: architecture.md gained a Code layers section with the layer diagram (A2), and TestParseDelivery gained the exotic mail.log cases (§ 3). Fixes a bug that last test found: the delivery-line pattern matched status= greedily, taking the *last* occurrence on the line. Postfix appends the remote server's reply verbatim, so a rejection whose reply quoted "status=sent" was filed as a delivered message in the send log. It now takes the first status= after the recipient, which is the real field. R7 (CONTRIBUTING.md) moved to roadmap 2.x — one developer, no external PR flow, so the file would have no audience yet. R1 (compose image tag) and the git tag stay in roadmap § v1.x as the release-commit steps. gofmt/go vet clean on both modules; go test ./... green except the three known Windows-only failures (file perms, backslash paths, renaming an open file). Not exercised on the dev server — no Docker locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
108 lines
3.6 KiB
Go
108 lines
3.6 KiB
Go
package web
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"unicode"
|
|
)
|
|
|
|
// minAdminPasswordLen is the floor for the administrator password. The panel is
|
|
// public (security.md), so this is deliberately not tiny.
|
|
const minAdminPasswordLen = 12
|
|
|
|
const (
|
|
minUsernameLen = 3
|
|
maxUsernameLen = 64
|
|
)
|
|
|
|
// minSecretFilePasswordLen is the floor for the password protecting an
|
|
// encrypted backup or domain export. Such a file is offline and can be attacked
|
|
// at leisure, so the floor matches the administrator password's rather than the
|
|
// weaker "any password is better than none".
|
|
const minSecretFilePasswordLen = minAdminPasswordLen
|
|
|
|
// validateUsername enforces a strict server-side whitelist (security.md):
|
|
// letters, digits, dot, dash, underscore. Client validation is never trusted.
|
|
func validateUsername(u string) error {
|
|
if len(u) < minUsernameLen || len(u) > maxUsernameLen {
|
|
return fmt.Errorf("username must be %d-%d characters", minUsernameLen, maxUsernameLen)
|
|
}
|
|
for _, r := range u {
|
|
if r > unicode.MaxASCII || (!isASCIILetterOrDigit(r) && r != '.' && r != '-' && r != '_') {
|
|
return fmt.Errorf("username may contain only letters, digits, '.', '-' and '_'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// validateAdminPassword enforces a minimum length. Composition rules beyond
|
|
// length tend to reduce entropy in practice, so length is the sole gate.
|
|
func validateAdminPassword(p string) error {
|
|
if len(p) < minAdminPasswordLen {
|
|
return fmt.Errorf("password must be at least %d characters", minAdminPasswordLen)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func isASCIILetterOrDigit(r rune) bool {
|
|
return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9')
|
|
}
|
|
|
|
const maxDomainLen = 253 // RFC 1035 limit on a fully-qualified name
|
|
|
|
// normalizeDomain lower-cases and trims a domain name. Domain names are
|
|
// case-insensitive, and the generated OpenDKIM tables/keys use the canonical
|
|
// lower-case form, so we normalise before both validation and storage.
|
|
func normalizeDomain(name string) string {
|
|
return strings.ToLower(strings.TrimSpace(name))
|
|
}
|
|
|
|
// validateDomain enforces a strict server-side whitelist for sending-domain
|
|
// names (security.md). The result is safe to write verbatim into the OpenDKIM
|
|
// KeyTable/SigningTable and to use as a filesystem path segment: only
|
|
// lower-case letters, digits, '.' and '-' are allowed, in valid DNS label
|
|
// shape. Input must already be normalised with normalizeDomain.
|
|
//
|
|
// This is deliberately stricter than "any string DNS might accept" — no
|
|
// leading/trailing dots or hyphens, no empty or over-long labels, and at least
|
|
// two labels so single-word hostnames cannot be registered as sending domains.
|
|
func validateDomain(name string) error {
|
|
if name == "" {
|
|
return fmt.Errorf("domain is required")
|
|
}
|
|
if len(name) > maxDomainLen {
|
|
return fmt.Errorf("domain must be at most %d characters", maxDomainLen)
|
|
}
|
|
labels := strings.Split(name, ".")
|
|
if len(labels) < 2 {
|
|
return fmt.Errorf("domain must include at least one dot (e.g. example.com)")
|
|
}
|
|
for _, label := range labels {
|
|
if err := validateDomainLabel(label); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateDomainLabel(label string) error {
|
|
if len(label) == 0 {
|
|
return fmt.Errorf("domain must not contain an empty label")
|
|
}
|
|
if len(label) > 63 {
|
|
return fmt.Errorf("each domain label must be at most 63 characters")
|
|
}
|
|
if label[0] == '-' || label[len(label)-1] == '-' {
|
|
return fmt.Errorf("domain labels must not start or end with '-'")
|
|
}
|
|
for i := 0; i < len(label); i++ {
|
|
c := label[i]
|
|
lower := c >= 'a' && c <= 'z'
|
|
digit := c >= '0' && c <= '9'
|
|
if !lower && !digit && c != '-' {
|
|
return fmt.Errorf("domain may contain only lower-case letters, digits, '.' and '-'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|