A bounce could be recorded as a successful delivery. The log-tailer's Fixed: - A bounce could be recorded as a successful delivery. The log-tailer's - Log-tailer resumes where it stopped instead of jumping to end-of-file on - Level-2 rate limit no longer overshoots under concurrency: messages that Changed: - The project has a single public home: `github.com/mixeme/selfpost`. Codeberg - Code comments no longer cite the archived specification. References like - `docs/code-review.md` is gone. Its plan is finished — phases 0 (bar the - `docs/architecture.md` gained a *Code layers* section: a diagram of - Phase 1 doc/code hygiene (`docs/code-review.md`): removed ~30 stale … (1 more in CHANGELOG) Security: - Pre-release security review (plan § D, model Fable, 2026-08-06): full pass - `saslpasswd2` argv: the application login is now passed after a `--` Added: - Optional password encryption for the two secret-bearing downloads (plan - Domain import accepts an encrypted export: the envelope is detected by its - `selfpost-backup` writes encrypted archives and reads them back: - `TestParseDelivery` covers the exotic mail.log shapes the review asked for - docs: README *Encrypting a backup or export*; `docs/security.md` § … (14 more in CHANGELOG) Removed: - docs: `security.md` — accepted risk «restore old backup revives session rows» Changed: - docs: `implementation-plan.md` trimmed to the sole open v1.x gate — pre-release - docs: `architecture.md` — sessions (SQLite, idle renew, password change), - docs: `development.md` — expanded e2e stack and `release.yml` matrix workflow. - docs: `security.md` — accepted risk for send-log rows stuck at `queued` after - docs: `roadmap.md` — optional send-log / `mail.log` follow-ups under v1.x tail. … (10 more in CHANGELOG) Full detail: CHANGELOG.md (0.5.0).
108 lines
3.6 KiB
Go
108 lines
3.6 KiB
Go
package web
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"unicode"
|
|
)
|
|
|
|
// minAdminPasswordLen is the floor for the administrator password. The panel is
|
|
// public (security.md), so this is deliberately not tiny.
|
|
const minAdminPasswordLen = 12
|
|
|
|
const (
|
|
minUsernameLen = 3
|
|
maxUsernameLen = 64
|
|
)
|
|
|
|
// minSecretFilePasswordLen is the floor for the password protecting an
|
|
// encrypted backup or domain export. Such a file is offline and can be attacked
|
|
// at leisure, so the floor matches the administrator password's rather than the
|
|
// weaker "any password is better than none".
|
|
const minSecretFilePasswordLen = minAdminPasswordLen
|
|
|
|
// validateUsername enforces a strict server-side whitelist (security.md):
|
|
// letters, digits, dot, dash, underscore. Client validation is never trusted.
|
|
func validateUsername(u string) error {
|
|
if len(u) < minUsernameLen || len(u) > maxUsernameLen {
|
|
return fmt.Errorf("username must be %d-%d characters", minUsernameLen, maxUsernameLen)
|
|
}
|
|
for _, r := range u {
|
|
if r > unicode.MaxASCII || (!isASCIILetterOrDigit(r) && r != '.' && r != '-' && r != '_') {
|
|
return fmt.Errorf("username may contain only letters, digits, '.', '-' and '_'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// validateAdminPassword enforces a minimum length. Composition rules beyond
|
|
// length tend to reduce entropy in practice, so length is the sole gate.
|
|
func validateAdminPassword(p string) error {
|
|
if len(p) < minAdminPasswordLen {
|
|
return fmt.Errorf("password must be at least %d characters", minAdminPasswordLen)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func isASCIILetterOrDigit(r rune) bool {
|
|
return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9')
|
|
}
|
|
|
|
const maxDomainLen = 253 // RFC 1035 limit on a fully-qualified name
|
|
|
|
// normalizeDomain lower-cases and trims a domain name. Domain names are
|
|
// case-insensitive, and the generated OpenDKIM tables/keys use the canonical
|
|
// lower-case form, so we normalise before both validation and storage.
|
|
func normalizeDomain(name string) string {
|
|
return strings.ToLower(strings.TrimSpace(name))
|
|
}
|
|
|
|
// validateDomain enforces a strict server-side whitelist for sending-domain
|
|
// names (security.md). The result is safe to write verbatim into the OpenDKIM
|
|
// KeyTable/SigningTable and to use as a filesystem path segment: only
|
|
// lower-case letters, digits, '.' and '-' are allowed, in valid DNS label
|
|
// shape. Input must already be normalised with normalizeDomain.
|
|
//
|
|
// This is deliberately stricter than "any string DNS might accept" — no
|
|
// leading/trailing dots or hyphens, no empty or over-long labels, and at least
|
|
// two labels so single-word hostnames cannot be registered as sending domains.
|
|
func validateDomain(name string) error {
|
|
if name == "" {
|
|
return fmt.Errorf("domain is required")
|
|
}
|
|
if len(name) > maxDomainLen {
|
|
return fmt.Errorf("domain must be at most %d characters", maxDomainLen)
|
|
}
|
|
labels := strings.Split(name, ".")
|
|
if len(labels) < 2 {
|
|
return fmt.Errorf("domain must include at least one dot (e.g. example.com)")
|
|
}
|
|
for _, label := range labels {
|
|
if err := validateDomainLabel(label); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateDomainLabel(label string) error {
|
|
if len(label) == 0 {
|
|
return fmt.Errorf("domain must not contain an empty label")
|
|
}
|
|
if len(label) > 63 {
|
|
return fmt.Errorf("each domain label must be at most 63 characters")
|
|
}
|
|
if label[0] == '-' || label[len(label)-1] == '-' {
|
|
return fmt.Errorf("domain labels must not start or end with '-'")
|
|
}
|
|
for i := 0; i < len(label); i++ {
|
|
c := label[i]
|
|
lower := c >= 'a' && c <= 'z'
|
|
digit := c >= '0' && c <= '9'
|
|
if !lower && !digit && c != '-' {
|
|
return fmt.Errorf("domain may contain only lower-case letters, digits, '.' and '-'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|