c0d9aa7518
Codeberg is being retired as the project's public site, so every reference now points at GitHub. That includes the Go module path (codeberg.org/mix/selfpost → github.com/mixeme/selfpost): leaving an import path on a host that is going away would break `go get` and `go install`, so this is not only a docs change. Touches go.mod, test/e2e/go.mod, all imports, Makefile MODULE, the -ldflags version stamp in build/Dockerfile and docs/development.md, the licence headers in the SVG/HTML assets, and README (no more primary/mirror pair). Comments no longer cite the archived specification. "spec 7.6.1", "spec 5.1" and friends pointed into docs/archive/specification-v1.0.md, which is marked as not a source of truth; each is now a reference to the live document that owns the subject — architecture.md (with section), product.md, security.md or the README. The review only asked for the 7.x refs (code-review.md § 4), but 4/5/6/ 8/9 had the same defect, so they went too. Comments only, no behaviour change. Also closes the remaining review items: architecture.md gained a Code layers section with the layer diagram (A2), and TestParseDelivery gained the exotic mail.log cases (§ 3). Fixes a bug that last test found: the delivery-line pattern matched status= greedily, taking the *last* occurrence on the line. Postfix appends the remote server's reply verbatim, so a rejection whose reply quoted "status=sent" was filed as a delivered message in the send log. It now takes the first status= after the recipient, which is the real field. R7 (CONTRIBUTING.md) moved to roadmap 2.x — one developer, no external PR flow, so the file would have no audience yet. R1 (compose image tag) and the git tag stay in roadmap § v1.x as the release-commit steps. gofmt/go vet clean on both modules; go test ./... green except the three known Windows-only failures (file perms, backslash paths, renaming an open file). Not exercised on the dev server — no Docker locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
90 lines
2.7 KiB
Go
90 lines
2.7 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/mixeme/selfpost/internal/health"
|
|
)
|
|
|
|
// checkServer resolves the panel's own hostname and confirms the reverse
|
|
// lookup of each address points back at that name (FCrDNS). A missing or
|
|
// mismatched PTR is the single most common reason mail from a self-hosted
|
|
// server is rejected or scored as spam, which is why it is an error and not
|
|
// advice.
|
|
func (c *Checker) checkServer(ctx context.Context, hostname string) Server {
|
|
srv := Server{Hostname: hostname, CheckedAt: time.Now()}
|
|
if hostname == "" {
|
|
srv.PTR = Result{
|
|
Status: health.StatusUnknown,
|
|
Detail: "SELFPOST_HOSTNAME is not set, so the server's own name in DNS cannot be checked. Set it in the deployment environment.",
|
|
}
|
|
return srv
|
|
}
|
|
|
|
addrs, err := c.resolver.LookupIPAddr(ctx, hostname)
|
|
if err != nil || len(addrs) == 0 {
|
|
srv.PTR = Result{
|
|
Status: health.StatusError,
|
|
Detail: fmt.Sprintf("%s does not resolve to any address. Publish an A (or AAAA) record for it — receiving servers check the name this server announces in HELO.", hostname),
|
|
}
|
|
return srv
|
|
}
|
|
|
|
want := normalizeName(hostname)
|
|
matched, total := 0, len(addrs)
|
|
var records []string
|
|
for _, a := range addrs {
|
|
ip := a.IP.String()
|
|
srv.IPs = append(srv.IPs, ip)
|
|
|
|
names, err := c.resolver.LookupAddr(ctx, ip)
|
|
if err != nil || len(names) == 0 {
|
|
records = append(records, ip+" → no PTR record")
|
|
continue
|
|
}
|
|
hit := false
|
|
for _, n := range names {
|
|
if normalizeName(n) == want {
|
|
hit = true
|
|
}
|
|
}
|
|
if hit {
|
|
matched++
|
|
records = append(records, ip+" → "+normalizeName(names[0]))
|
|
} else {
|
|
records = append(records, ip+" → "+normalizeName(names[0])+" (does not match)")
|
|
}
|
|
}
|
|
|
|
srv.PTR.Records = records
|
|
switch {
|
|
case matched == total:
|
|
srv.PTR.Status = health.StatusOK
|
|
srv.PTR.Detail = fmt.Sprintf("%s resolves to %s and the reverse lookup points back at it.", hostname, joinIPs(srv.IPs))
|
|
case matched > 0:
|
|
srv.PTR.Status = health.StatusWarn
|
|
srv.PTR.Detail = fmt.Sprintf("Only %d of %d addresses of %s have a matching PTR record. Mail sent from the others may be rejected — set the reverse DNS of every address at your hosting provider.", matched, total, hostname)
|
|
default:
|
|
srv.PTR.Status = health.StatusError
|
|
srv.PTR.Detail = fmt.Sprintf("No address of %s has a reverse (PTR) record pointing back at it. Many receiving servers reject or spam-score mail from such a host — set the reverse DNS of the server's IP to %s at your hosting provider.", hostname, hostname)
|
|
}
|
|
return srv
|
|
}
|
|
|
|
func joinIPs(ips []string) string {
|
|
switch len(ips) {
|
|
case 0:
|
|
return "no address"
|
|
case 1:
|
|
return ips[0]
|
|
default:
|
|
out := ips[0]
|
|
for _, ip := range ips[1:] {
|
|
out += ", " + ip
|
|
}
|
|
return out
|
|
}
|
|
}
|