mix
efaf016c5f
test / test (push) Has been cancelled
The panel now suggests policy-only DMARC by default, lets operators configure a default and per-domain report address, and DNS-checks hub _report._dmarc records. Future in-panel report ingestion is tracked as dmarc-reports in the roadmap. Co-authored-by: Cursor <cursoragent@cursor.com>
95 lines
3.0 KiB
Go
95 lines
3.0 KiB
Go
package dnscheck
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mixeme/selfpost/internal/health"
|
|
)
|
|
|
|
func TestSPFExample(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
hostname string
|
|
ips []string
|
|
want string
|
|
}{
|
|
{"ipv4", "mail.example.com", []string{"203.0.113.10"}, "v=spf1 ip4:203.0.113.10 -all"},
|
|
{"both families", "mail.example.com", []string{"203.0.113.10", "2001:db8::1"},
|
|
"v=spf1 ip4:203.0.113.10 ip6:2001:db8::1 -all"},
|
|
{"no addresses", "mail.example.com", nil, "v=spf1 a:mail.example.com -all"},
|
|
{"unparsable addresses", "mail.example.com", []string{"not-an-ip"}, "v=spf1 a:mail.example.com -all"},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
if got := SPFExample(c.hostname, c.ips); got != c.want {
|
|
t.Errorf("SPFExample = %q, want %q", got, c.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestDMARCExample(t *testing.T) {
|
|
if got := DMARCExample(""); got != "v=DMARC1; p=none" {
|
|
t.Errorf("empty = %q", got)
|
|
}
|
|
want := "v=DMARC1; p=none; rua=mailto:reports@hub.example"
|
|
if got := DMARCExample("reports@hub.example"); got != want {
|
|
t.Errorf("with rua = %q, want %q", got, want)
|
|
}
|
|
}
|
|
|
|
func TestResolveDMARCRua(t *testing.T) {
|
|
inherit := sql.NullString{}
|
|
if got := ResolveDMARCRua(inherit, "a@b.com"); got != "a@b.com" {
|
|
t.Errorf("inherit profile = %q", got)
|
|
}
|
|
none := sql.NullString{Valid: true}
|
|
if got := ResolveDMARCRua(none, "a@b.com"); got != "" {
|
|
t.Errorf("explicit none = %q", got)
|
|
}
|
|
custom := sql.NullString{Valid: true, String: "x@y.com"}
|
|
if got := ResolveDMARCRua(custom, "a@b.com"); got != "x@y.com" {
|
|
t.Errorf("custom = %q", got)
|
|
}
|
|
}
|
|
|
|
func TestExternalReportAuth(t *testing.T) {
|
|
name, value, ok := ExternalReportAuth("shop.com", "reports@hub.com")
|
|
if !ok || name != "_report._dmarc.hub.com" || value != "v=DMARC1;" {
|
|
t.Fatalf("external = (%q, %q, %v)", name, value, ok)
|
|
}
|
|
if _, _, ok := ExternalReportAuth("shop.com", "dmarc@shop.com"); ok {
|
|
t.Fatal("same domain should not need external auth")
|
|
}
|
|
}
|
|
|
|
// The record the panel shows and the one a failed check suggests must be the
|
|
// same string, or the operator is told two different things on one page.
|
|
func TestMissingRecordChecksSuggestTheShownExample(t *testing.T) {
|
|
f := &fakeResolver{}
|
|
c := newTestChecker(f)
|
|
|
|
spf := c.checkSPF(context.Background(), Query{
|
|
Name: "example.com",
|
|
Hostname: "mail.example.com",
|
|
ServerIPs: []string{"203.0.113.10"},
|
|
})
|
|
if spf.Status != health.StatusError {
|
|
t.Fatalf("SPF status = %q, want error (%s)", spf.Status, spf.Detail)
|
|
}
|
|
if want := SPFExample("mail.example.com", []string{"203.0.113.10"}); !strings.Contains(spf.Detail, want) {
|
|
t.Errorf("SPF advice %q does not suggest %q", spf.Detail, want)
|
|
}
|
|
|
|
dmarc := c.checkDMARC(context.Background(), Query{Name: "example.com"})
|
|
if dmarc.Status != health.StatusWarn {
|
|
t.Fatalf("DMARC status = %q, want warn (%s)", dmarc.Status, dmarc.Detail)
|
|
}
|
|
if want := DMARCExample(""); !strings.Contains(dmarc.Detail, want) {
|
|
t.Errorf("DMARC advice %q does not suggest %q", dmarc.Detail, want)
|
|
}
|
|
}
|