Stage 3, step 2. Reviewed by Fable (read-only), fixed by Sonnet with a
failing test before each fix, checked by Opus. No Critical or High
finding: route authorization, tenant isolation by id, the /server/
subtree guard, output encoding and the origin check were found sound.
Fixed
- M1: a session was keyed by user name and had no link to the user. A
deleted or renamed user's cookie stayed alive (renewed on every hit,
before the user was looked up) and became a session of whoever was
later created under that name, with that account's role. The
baseline now has sessions.user_id REFERENCES users(id) ON DELETE
CASCADE; the principal is resolved by id and a session is renewed
only after its user was found. RenameSession is gone.
- M2: any user's password change deleted every other user's sessions.
It ends that user's other sessions only.
- L1: a password set on the user form ends that user's sessions (an
administrator editing their own account keeps the current one).
- L2: store, saslpasswd2 and Postfix reload errors were shown verbatim
on the application form, the inbound upstream / recipients forms and
the limit recalculation - pages a domain administrator reaches.
Validation errors (app.ValidationError, inbound.ValidationError,
store.ErrNotAutoRateLimit) keep their text; anything else is logged
and shown as "Could not save ... Check the logs and try again."
- L3: store.ListDMARCReports treated an empty domain list as "all". It
takes a scope now (AllDomains or a list; an empty list is no rows),
and the DMARC hub is open to the domain role as the plan says: the
reports of the assigned domains, without the instance-wide ingest
box. The menu entry was already shown to them and led to a 404.
- I1: /static/ answered with a listing of the embedded assets. A path
that is not a known asset is a 404.
Consequences
- The global DMARC hub lists reports of domains that were deleted
since, too.
- dev/migrate1x (not in the tree) no longer carries sessions over:
everyone signs in again after the transfer.
- docs/schema-migrations.md: the sessions row.
Recorded, not changed - for the owner:
- L4: the report-address select names the followed user and their
address to every administrator of the domain, by default the global
administrator's login name. The plan asks for it.
- L5: a delegated inbound upstream may be any host and port, loopback
and private ranges included - within the trusted-operator model; to
be listed among the accepted risks in security.md.
- L6: Account's profile is saved without the password; becomes a
requirement once password-reset mails to users.email.
- Still echoing an error's text: backup and domain import (global
only), the domain form's validation messages.
Not checked by the review: anything needing the container (e2e, real
Postfix / DNS), CSP behaviour in a live browser.
go test -count=1 ./internal/web/... ./internal/store/... ./internal/app/...
./internal/inbound/... ./internal/dmarc/... ./cmd/panel
ok (all eleven packages; dev/migrate1x also ok)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
125 lines
3.4 KiB
Go
125 lines
3.4 KiB
Go
// Package auth implements the panel's login sessions, one-time setup flow,
|
|
// and authentication middleware.
|
|
package auth
|
|
|
|
import (
|
|
"log"
|
|
"net"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/mixeme/selfpost/internal/store"
|
|
"github.com/mixeme/selfpost/internal/web/view"
|
|
)
|
|
|
|
// Config holds auth-specific panel configuration.
|
|
type Config struct {
|
|
CookieSecure bool
|
|
Hostname string
|
|
SessionIdleDays int
|
|
TrustedProxyCIDRs []*net.IPNet
|
|
}
|
|
|
|
// Module handles login, logout, setup, and session middleware.
|
|
type Module struct {
|
|
store *store.Store
|
|
cfg Config
|
|
view *view.Engine
|
|
sessions *sessionStore
|
|
setup *setupManager
|
|
|
|
loginLimiter *rateLimiter
|
|
setupLimiter *rateLimiter
|
|
|
|
trustedProxies []*net.IPNet
|
|
}
|
|
|
|
// New builds the auth module. setupTokenPath is where the current setup token
|
|
// is mirrored on disk (security.md).
|
|
func New(st *store.Store, cfg Config, v *view.Engine, setupTokenPath string) *Module {
|
|
idleDays := cfg.SessionIdleDays
|
|
if idleDays <= 0 {
|
|
idleDays = 7
|
|
}
|
|
m := &Module{
|
|
store: st,
|
|
cfg: cfg,
|
|
view: v,
|
|
sessions: newSessionStore(st, time.Duration(idleDays)*24*time.Hour),
|
|
setupLimiter: newRateLimiter(10, time.Minute),
|
|
loginLimiter: newRateLimiter(10, 15*time.Minute),
|
|
trustedProxies: cfg.TrustedProxyCIDRs,
|
|
}
|
|
m.setupLimiter.startSweeper()
|
|
m.loginLimiter.startSweeper()
|
|
m.setup = newSetupManager(st, cfg.Hostname, setupTokenPath)
|
|
return m
|
|
}
|
|
|
|
// Bootstrap runs once at startup. If setup is not complete it mints and
|
|
// announces the first setup token (security.md).
|
|
func (m *Module) Bootstrap() error {
|
|
return m.setup.bootstrap()
|
|
}
|
|
|
|
// AllowLoginAttempt reports whether a login or account-password change attempt
|
|
// from r is within the rate limit (security.md).
|
|
func (m *Module) AllowLoginAttempt(r *http.Request) bool {
|
|
return m.loginLimiter.Allow(clientIP(r, m.trustedProxies))
|
|
}
|
|
|
|
// SessionToken returns the session token the request carries, if exactly one
|
|
// cookie of that name is present.
|
|
func (m *Module) SessionToken(r *http.Request) (string, bool) {
|
|
return m.sessionToken(r)
|
|
}
|
|
|
|
// DestroyOtherSessions invalidates every session of the user except keep.
|
|
func (m *Module) DestroyOtherSessions(userID int64, keep string) {
|
|
m.sessions.DestroyOthers(userID, keep)
|
|
}
|
|
|
|
// DestroyUserSessions invalidates every session of the user.
|
|
func (m *Module) DestroyUserSessions(userID int64) {
|
|
m.sessions.DestroyAll(userID)
|
|
}
|
|
|
|
func logf(format string, args ...any) {
|
|
log.Printf(format, args...)
|
|
}
|
|
|
|
// clientIP extracts the peer IP for rate-limiting. By default it is the
|
|
// transport peer (RemoteAddr), which cannot be spoofed. If RemoteAddr matches
|
|
// one of trustedProxies, the last entry of X-Forwarded-For is used instead —
|
|
// that is the address the trusted proxy itself appended, so a client can't
|
|
// forge it by sending its own XFF header.
|
|
func clientIP(r *http.Request, trustedProxies []*net.IPNet) string {
|
|
host, _, err := net.SplitHostPort(r.RemoteAddr)
|
|
if err != nil {
|
|
host = r.RemoteAddr
|
|
}
|
|
|
|
if len(trustedProxies) > 0 {
|
|
if peer := net.ParseIP(host); peer != nil && ipInAny(peer, trustedProxies) {
|
|
if xff := r.Header.Get("X-Forwarded-For"); xff != "" {
|
|
parts := strings.Split(xff, ",")
|
|
if ip := net.ParseIP(strings.TrimSpace(parts[len(parts)-1])); ip != nil {
|
|
return ip.String()
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return host
|
|
}
|
|
|
|
func ipInAny(ip net.IP, nets []*net.IPNet) bool {
|
|
for _, n := range nets {
|
|
if n.Contains(ip) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|