Security review of the DMARC report path (Fable, 2026-10-11), which ran for the first time in 2.0.0. No Critical or High finding. Fixed: - Medium: a report was bounded only as 8 MiB of XML - some 160 000 records or one name of megabytes, all of it rows and table cells. At most 5 000 records (more is ErrRejected, dropped), text fields cut to 255 bytes on a character boundary, a record's count capped. - Medium: the cap of 500 reports was for the whole server, so a stranger filing under one domain's address evicted every other domain's reports. PruneDMARCReports counts per domain. - Low: the pipe service ran up to default_process_limit (100) commands at once against the panel's database; maxproc is 1. - Low: the reason logged for a dropped message carried the sender's bytes (header line, zip entry name) as they came; cut to 200 bytes and reduced to printable ASCII, zip entry names quoted. - Low: SELFPOST_DATA_DIR / SELFPOST_DB_PATH with whitespace or "$" would reach the command through export_environment as another path; refused at start when DMARC ingest is on. Left as they are, told to the owner: the parse-failure count is a lifetime figure shown under "This week"; a report larger than the command reads is dropped as unreadable; nested multipart is not searched. The hub's Retention line follows the design commit before this one. security.md: the review, and the accepted-risk entry says what a stranger can and cannot do now. The roadmap no longer calls the review pending. go vet ./cmd/... ./internal/dmarc/ ./internal/store/: ok go test ./cmd/... ./internal/dmarc/ ./internal/store/ ./internal/web/...: ok make e2e on the test server (with the port-25 scenarios of the next commit): ok Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
23 KiB
Security
What is here. (1) Mandatory requirements — the checklist v1.0 has to
meet; the full v1.0 audit passed. The pre-release review (plan § D, 2026-08-06)
covered the whole diff from the v1.0 audit (Phase 11) to HEAD and the checklist
in full: no exploitable findings; one defence-in-depth change — -- before the
login in the saslpasswd2 argv
(internal/app/sasl.go). The 2026-08-14 review
(code-review plan § P7, Fable; reviewer ≠ author) covered the P0–P1 diff of the
2026-08-13 full-tree review against this document — send-log authorization for
domain administrators, the atomic level-2 admit (tryAdmit), fail-closed
session creation, and application-delete ordering: no findings, and nothing
needed adding to the accepted risks. The 2026-08-19 review (Fable) covered the
whole diff from 1.3.0 (7052395) to HEAD past 1.9.1 — the inbound-relay path
(port 25, maps, panel), DMARC aggregate-report ingestion, automatic rate
limiting, application auth-IP allow-lists, and the new panel surface
(handlers, templates, settings): no exploitable findings; two deliberate
behaviours the pass examined are now recorded under Accepted risks
(unauthenticated DMARC ingest, fail-open auth-IP enforcement). The 2.0 review
(Fable, 2026-10-10; fixed and re-checked by other models) covered the route
rename, the /server/ subtree guard, inbound delegation and the new pages: no
Critical or High finding; sessions were keyed by user name (now by user id),
a password change ended other users' sessions, a password set for a user on
the user form did not end that user's sessions, internal errors reached forms a
domain user can open, and /static/ listed its files — all fixed
(see Authentication and sessions and Errors
shown to users); two deliberate behaviours are
recorded under Accepted risks (upstream of a delegated inbound domain, profile
saved without the password). The 2026-10-11 review (Fable) covered the DMARC
report path from port 25 to the report pages, which ran for the first time in
2.0.0 - the 2026-08-19 pass read code that Postfix could not yet start: no
Critical or High finding; a report's size was bounded only as bytes (now 5 000
records, 255 bytes a field), the retention cap was one for the whole server
(now per domain), the delivery command could run a hundred at once (now one),
and the reason logged for a dropped message carried the sender's bytes as they
came (now cut and reduced to printable ASCII).
(2) Accepted risks —
deliberate departures beyond the mandatory, recorded so the decision is not
lost.
Hardening beyond the mandatory (security headers, origin checking, __Host-
cookie with duplicate detection — Phase 14) is done; the history is in
CHANGELOG.md and git log.
Product boundaries: product.md. As-built design: architecture.md.
Mandatory requirements
The panel is exposed to the internet — the items below are not optional.
First-run administrator setup
- A one-time secret link
/setup/<token>, not an env variable holding a ready-made password hash. - Token ≥128 bits (
crypto/rand); mirrored to/data/setup-token. - Token lifetime — 10 minutes; after expiry, or after a restart with setup unfinished, it is regenerated and logged again.
- Rate limiting on
/setup/<token>per IP, separate from login. - Token comparison is constant-time (
subtle.ConstantTimeCompare). - Failed attempts do not invalidate the token early (protects setup from being DoS-ed).
- Once the administrator exists the token is void forever,
/setup/*→ 404. - The administrator password is bcrypt in SQLite only; no plaintext and no MD5.
PANEL_USERNAME/PANEL_PASSWORD_HASHin env are not used.
Application SASL passwords
- The panel generates the password on creation or reissue and shows it once.
- In
sasldb2it is stored in the form SASL requires (not plaintext held by the panel); a lost password can only be reissued.
Input and configuration
- Server-side validation of addresses and domains (character whitelist); client-side validation does not count as protection.
- In address-list mode every address is checked to belong to the application's domain before it is written.
postfix reloadand anyexecrun without shell interpolation of user input; arguments are passed as separate elements.- Writes to config files are escaped (no injection of Postfix directives).
Authentication and sessions
- Rate limiting on login (per IP, with lockout or delay).
- Sessions: cryptographically random token; cookie
HttpOnly,Secure,SameSite. - Sessions live in SQLite (SHA-256 of the token, not the token itself); sliding
idle timeout (
PANEL_SESSION_IDLE_DAYS). - A session belongs to a user by id (
sessions.user_id, deleted with the user). The user is loaded on every request and a session is renewed only after it was found, so the cookie of a deleted user is dead and cannot become the session of whoever is created under the same name later; renaming a user leaves their sessions alone. - What ends a user's sessions: deleting the user (all); a password change on Account (that user's other sessions — never another user's); a password set for them by a global user on the user form (all of theirs, except the current one when they set their own); signing out (the current one only). There is no "sign out everywhere", and a restored backup brings back the session rows it held.
- Polling by the monitoring screens (
HX-RequestGETs) does not renew a session.
Roles
Everyone who signs in to the panel is an administrator, so the two roles name a
reach, never a rank: global and domain (in the users list, the role
select, the page headers and these documents — not "admin"). A domain user is
assigned outbound domains and inbound domains separately, each list with
All (which includes domains added later and widens the list, not the role).
global |
domain |
|
|---|---|---|
| Overview, Server (Health, System log, Backup, Users, Settings, kit page) | yes | no — 404 |
| Outbound queue | yes | no — 404 (a queue is not filtered by domain) |
| Outbound: domain page, applications, Domain settings (report address, rate limit, export), log | every domain | assigned outbound domains |
| Outbound › DMARC reports | every report, with the server's ingest statistics | reports of assigned domains, without the ingest box |
| Inbound: domain page, upstream, recipients | every inbound domain | assigned inbound domains |
| Add or delete a domain, either direction; import a domain | yes | no |
| Account, Help | yes | yes |
- A path a user may not reach, a domain or application that does not exist, and one that belongs to another tenant answer the same 404, so the panel does not confirm what exists. A group with nothing assigned is absent from the user's menu.
/server/is guarded once, byglobalOnlywhere its routes are registered (a route outside the subtree cannot be added through that helper), and every handler checks again. Outbound and inbound handlers check per object (lookupDomain,requireInboundDomain) and lists are filtered by assignment in the query. Each denied path has a test for adomainuser, including another tenant's id.- The panel will not remove or demote the last
globaluser. - A
domainuser can export an assigned domain, and an export carries the working application passwords (encrypted unless the box is unticked): assign domains with that in mind.
State-changing requests
- Every state change is a
POST; aGETnever changes state (the delete confirmation pages only render a form). - Every non-read request first passes the origin check
(
originAllowed, internal/web/security.go):Sec-Fetch-Sitemust besame-origin, orOriginmust name the panel's own host; the session cookie isSameSiteas well. - There are no CSRF tokens yet. The decision, its price and the conditions for revisiting it are in the accepted risks and the ADR below.
Errors shown to users
A page shows a validation message (what to fix) and nothing else of an error. A
database, saslpasswd2 or Postfix-reload failure is logged and the page says
only that the change could not be saved and to check the logs. This holds on
every form a domain user can open. The global-only Backup page (full backup,
domain import) still shows the underlying message of an import failure, so the
operator can act on it.
Output and process
- Rendering goes through
html/templatewith auto-escaping (queue, log, journal, themes). - The panel process is not root (
user=panelin supervisord); path access is granted through theselfpostgroup with minimal permissions.
Mail path (security-relevant)
- Not an open relay — SASL only on 465/587;
reject_unauth_destination;smtpd_sender_login_maps+reject_sender_login_mismatch. - Inbound relay (optional,
INBOUND_RELAY_ENABLE) — port 25 is not an open relay either: SASL is off;smtpd_relay_restrictions/smtpd_recipient_restrictionsarereject_unauth_destinationandreject_unlisted_recipient; maps list only configured domains and recipients. Domains with no upstream host are omitted from the maps so mail is never accepted with nowhere to send it. Prefer recipient modelistto refuse unknown addresses at RCPT (no backscatter). OpenDKIM is not attached on inbound. An optional antispam milter is inbound-only; default action is fail-open (accept). - TLS is mandatory before credentials are transmitted (465 wrapper / 587
encrypt). TRUSTED_PROXY_CIDR— only explicitly trusted proxies may supplyX-Forwarded-Forfor login rate limiting; empty means XFF is ignored.
Backup and domain export
- Both files are secrets: a full backup carries DKIM keys,
sasldb2, the panel users' password hashes,docker-compose.yml,.env, and the TLS private key fromcerts/when present; a domain export carries the DKIM key and working application passwords in the clear (otherwise a transfer without recreating credentials would be impossible). - Both downloads are encrypted with a password unless the box on the form is unticked (it is ticked by default): scrypt (N=2¹⁵, r=8, p=1) → AES-256-GCM, streamed in 64 KiB chunks, each authenticated with the header, the chunk number, and an end-of-stream flag — a truncated or substituted file fails to open instead of silently restoring a partial "tail". Format and wrapper: internal/secretfile.
- Extensions:
.spbk(SelfPost backup — full backup),.spde(SelfPost domain export — domain export); unencrypted files stay.tar.gz/.json. Domain import detects encryption by the file's magic bytes, not by extension. - The password is never stored: without it the file cannot be recovered. In the
CLI the password comes only from
SELFPOST_BACKUP_PASSWORDor-password-file, never as an argument (the process list is readable by any process in the container). - Minimum password length matches the administrator password (12): the file sits offline and can be attacked without a time limit.
Accepted risks
An accepted risk is a decision with a condition for revisiting it, not a deferred item from the roadmap.
- A
POSTwith neitherSec-Fetch-SitenorOriginis allowed through. A client that sends neither — a genuinely old browser, or a webview with a frozen engine — stays vulnerable to CSRF from any site. Accepted deliberately: every panel user (roleglobalordomain) is an operator who picks their own browser, not an untrusted party the panel needs to defend against, and a strict mode would not "protect" such a client, it would simply break the panel in it. Tightening is one line inoriginAllowed(internal/web/security.go): returnfalseinstead oftruein the "neither header present" branch. - Session-bound CSRF tokens are not implemented. The origin check closes the
neighbouring-subdomain case but depends on browser behaviour; a token does
not. The price is a hidden field in roughly two dozen forms. The trigger to
revisit is a requirement for protection that holds regardless of the browser,
or a population of
domainusers the global user does not fully trust (see the ADR below). A token would not save the panel from XSS inside it either: code executing in the panel's origin sends the request itself — against that,html/templateauto-escaping and CSP do the work, which is why templates must contain no inline scripts and no inline styles. Tracked as csrf-tokens: implementing that item replaces this bullet and the ADR below, and dropping it leaves them as the single record of the decision. The two must not disagree. - Destructive-action confirmation (
data-confirm) is JavaScript-only. Delete, regenerate-password, and clear-rate-limit forms carry adata-confirmprompt handled entirely in panel.js; with JavaScript disabled or blocked the form submits immediately, exactly as it did before the prompts existed. Accepted deliberately: the prompt is a mis-click guard, not an authorization boundary — the same origin check and session/RBAC gate every one of thesePOSTs whether or not JavaScript ran. Progressive enhancement means the panel must work with JavaScript off; a server-rendered confirmation step would need a second page (or a?confirm=1round trip) for every one of these forms, which is what the delete pages (user_delete.html,out_domain_delete.html,in_domain_delete.html) already do for the highest-blast-radius deletes. - Encrypting backups and exports can be switched off. The panel's
Encrypt with a password box is ticked by default, but with it cleared the
file downloads in the clear, and the
selfpost-backupCLI writes a plain archive unless it is given a password. Otherwise an operator with nowhere to keep a password would lose the ability to take a backup at all, and a permanently undecryptable archive is worse than an unencrypted one: SelfPost does not store the password. The trigger to make encryption mandatory is a second administrator (at which point "who downloaded it" stops being one person). - A journal row left without delivery lines is closed as
bouncedrather than left as it is. The "foreverqueued" risk is gone:mail.logmoved to/data/log/and survives container recreation, and the log tailer keeps its read position (logtail_state), so the tail is read after a start. What remains are rows whose delivery lines are lost for good (the log rotated past 14 files while the panel was down, or was deleted): the reconciliation againstpostqueue -psees the message is not in the queue and after a 2-minute grace marks itbounced. If the message did in fact go out, the status is a false negative. Accepted deliberately: a delivery the panel cannot confirm must not be shown as confirmed, and a permanentqueuedis indistinguishable from "in flight right now". Reconciliation does not run until the tailer has read the log to the end, and touches nothing ifpostqueueis unreadable. See architecture.md § Log tailer. - DMARC aggregate reports are accepted without authentication. Anyone on
the internet can mail a fabricated report (or displace a genuine one — the
UNIQUE(reporter, report_id, domain)upsert is delete-then-insert) and skew the alignment statistics the panel shows. Inherent to howruaworks: reporters are arbitrary third parties and the mailbox address is published in DNS. The ingest already constrains the meaningful part — a report cannot be filed under a domain this instance does not host, and the claimed domain is cross-checked against the+tagof the delivery address (effective since 2.0.0: before it the recipient never reached the command) — and the data is advisory statistics only; nothing enforces off it. What a stranger can do is limited to a domain that chose a SelfPost-hosted address, through that address: file reports under it, replace one whose reporter and id they know, and fill that domain's 500 — not another domain's. A message that is not a report the relay keeps is dropped, not bounced (the envelope sender is the author's to write); a genuine report the parser cannot read is lost the same way, with a count and a line in the mail log. The trigger to revisit is any feature that lets report contents drive an automatic action (policy changes, rate limiting, alerting an operator into a config change). - The application auth-IP allow-list is enforced fail-open. The check runs
in the journal milter (
internal/milter/authip.go) withdefault_action=acceptand skips on store errors, so if the milter is down the restriction is not applied; the SASL login itself always succeeds. This is documented in guide.md as not an authentication boundary — it is a blast-radius limiter for a leaked application password, on the same fail-open path as level-2 rate limiting, and a milter outage already stops the journal from recording sends at all. The trigger to revisit is a requirement for the allow-list to hold as a security boundary — at which point it must move to the SASL/smtpd layer and fail closed. - Level-2 in-flight reservations can outlive a dropped SMTP session until TTL.
The journal milter cannot observe connection-close directly through
go-milter, so if a client disconnects without an explicit
Abort, its in-memory reservation is released by TTL expiry, not immediately. The map is bounded by key and TTL (currently 10 minutes), so the effect is temporary over-counting on that app/domain key under churn. Accepted deliberately: immediate cleanup would require protocol hooks the current milter interface does not expose; the TTL bound keeps it finite. Trigger to revisit: sustained high-volume false throttling attributable to orphaned reservations. - Access to
mail.logfrom the unprivileged panel. The/data/logdirectory is2750 postfix:selfpostand the file is0640:postlogd(userpostfix) writes, the panel reads through the sharedselfpostgroup, and the file is inaccessible to others. The log holds envelope addresses and client IPs, but neither message bodies nor headers; it is excluded from backups (log/is skipped) so that a dump stays state rather than diagnostics. - A
domainuser may point an inbound domain's upstream at any host and port. The upstream form checks that the host is a well-formed name or IP and the port is 1–65535; loopback, private and link-local addresses are allowed, so adomainuser with an assigned inbound domain can make this server's Postfix open SMTP connections to any address it can reach and hand mail for that domain to it. Accepted deliberately: delegation is within the trusted-operator model — adomainuser is an operator theglobaluser chose to give that domain, and the upstream of a backup-MX is by nature a host on someone's private network. The connection is made by Postfix and carries only mail for that domain; the panel itself makes no request to the upstream. Trigger to revisit:domainusers who are not trusted operators — the same condition as for CSRF tokens — at which point an allow-list of upstream networks, or restricting the field to the global role, is the fix. - Account's profile (username, e-mail) is saved without the password.
Saving the profile does not ask for the current password, as changing the
password does. Today the e-mail is only the address the Use my e-mail
button fills in, so a stolen session gains nothing it did not have. It
becomes a requirement to ask for the current password when changing
users.emailas soon as password-reset mails a link to it — from then on whoever can change the address could take the account over.
ADR: CSRF via origin checking, without tokens
Context. The panel is forms (POST) with a cookie session — the classic
CSRF surface. What is needed is a way to tell a request from the panel's own
page apart from one initiated by a third-party site in a logged-in user's
browser. The panel is multi-user since 1.2.0 (a global user plus
zero or more domain users, each scoped to their assigned domains), but
that is an authorization boundary (who can see or change what), not a change
to the CSRF threat: the attacker in scope here is still an external site
riding a legitimate user's cookie, not one panel user attacking another
through the browser.
Decision. originAllowed in
internal/web/security.go checks Sec-Fetch-Site
(when the browser sends it) or Origin (fallback) against the panel's host; a
request carrying neither header is allowed through rather than rejected.
There are no session-bound tokens embedded in forms. The check applies the same
way regardless of the requesting user's role.
Why not tokens. Cross-user CSRF is not the threat model here: a
domain user's browser sending a request still needs that user's own
cookie, so a token would not add a boundary between roles that the
authorization checks (Principal.CanAccessDomain,
internal/web/auth/principal.go; route
gating in internal/web/handlers/authz.go)
don't already enforce. The remaining case is an external site making a
logged-in user's browser send a request, which the origin check covers without
touching a single template.
A token would need a hidden field in roughly two dozen forms and
synchronisation with every new form, and it would still not protect against
XSS inside the panel — code executing in the panel's origin reads the token
and sends the request itself. XSS is handled by html/template auto-escaping
and CSP, so that is a separate line of defence, not a CSRF token.
Trade-off. A client that sends neither Sec-Fetch-Site nor Origin (a
genuinely old browser, or a webview with a frozen engine) stays vulnerable — see
"Accepted risks" above. This is a deliberate choice not to break the panel in
such a client, at the price of a narrow residual surface.
Revisit if: a requirement appears for protection that does not depend on
browser behaviour, or domain accounts stop being trusted operators (for
example, if a future release lets a global user invite domain users
whose browsers/devices are not vetted) — at that point cross-role request
forgery inside the panel would need its own analysis, separate from the
external-site case this ADR covers.
How this list grows
The pre-release vulnerability review (history — CHANGELOG [0.5.0] Security)
closes every finding in one of two ways: a fix before the tag, or an entry here
with its rationale and its condition for revisiting, like the items above.
There is no third option ("we looked at it and moved on").