mixandClaude Opus 5.5
1c6e04b7d3
test / test (push) Canceled after 0s
The runtime base is debian:trixie-slim, the build stage golang:1.26-trixie:
Postfix 3.10.13 with upstream's 2026 security fixes up to the August
batch, libmilter 8.18.1, OpenSSL 3.5. Every citation of another program in
code, scripts and documents was re-read against the trixie sources
(dev/upstream; bookworm's kept in dev/upstream-bookworm) and updated;
development.md's cited-package table holds the trixie versions.
What the re-reading changed in behaviour:
- logtail: reject lines with sasl_method/sasl_username/sasl_sender
(smtpd_check.c:1019-1026); cleanup's "removed (canceled)" forgets a
port-25 id (cleanup_api.c:363-364).
- internal/postfix/retry.go reads postconf's stdout only: since 3.9 a
deprecated-parameter warning on stderr made one value too many and the
panel fell back to the compiled-in retry policy.
- logrotate-loop.sh: logrotate 3.22 exits 1 when it ignores a config;
the loop refuses on that output whatever the status.
- postfix-config.sh: cyrus_sasl_config_path set explicitly (bookworm's
07_sasl_config.diff is gone); maillog_file_permissions=0640; mynetworks
explicit; Dockerfile: SYNC_CHROOT= in /etc/default/postfix,
opendkim-tools dropped, openssl named, systemd-standalone-sysusers so
cron does not bring the whole of systemd.
- The selfpost group is 10998, outside the system range 100-999: in
trixie a package took 998 and the build failed (owner's decision:
a conflict-free id, the distribution's own ids untouched). The
entrypoint hands /data back by name when the user or the group differs.
Guide, backup refusal text, help (design commit 68ec8b2), e2e.
- smtpd_hide_client_session=yes on smtps and submission (owner's
decision): Received: names no client, TLS, login or protocol; port 25
keeps the full header. e2e checks both.
- test/upstream/opendkim-probe.sh makes keys with openssl genrsa.
Tests: on the server, make e2e exit 0 (674 s, the image built on trixie),
go vet + go test 27 packages ok. CHANGELOG [Unreleased], guide,
architecture.md, security.md, roadmap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
59 lines
2.4 KiB
Go
59 lines
2.4 KiB
Go
package postfix
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// The listing is composed by hand: its first line in the field order of
|
|
// Postfix 3.10.13's src/postqueue/showq_json.c, format_json(); the others
|
|
// short of fields or broken on purpose.
|
|
func TestParseQueueJSON(t *testing.T) {
|
|
out := []byte(`{"queue_name": "deferred", "queue_id": "41E862C00D9E", "arrival_time": 1791000000, "message_size": 446, "forced_expire": false, "sender": "app@example.com", "recipients": [{"address": "a@example.net", "delay_reason": "connect to mx.example.net[203.0.113.9]:25: Connection timed out"}]}
|
|
{"queue_name": "active", "queue_id": "5F00AA12", "arrival_time": 1791250000, "message_size": 900, "sender": "", "recipients": [{"address": "b@example.net"}]}
|
|
|
|
not json at all
|
|
{"queue_name": "deferred", "queue_id": "", "arrival_time": 1791250000}
|
|
{"queue_name": "deferred", "queue_id": "6C00BB34", "arrival_time": 17912`)
|
|
|
|
got, err := parseQueueJSON(out)
|
|
if err != nil {
|
|
t.Fatalf("parse: %v", err)
|
|
}
|
|
if len(got) != 2 {
|
|
t.Fatalf("parsed %d messages, want 2: %+v", len(got), got)
|
|
}
|
|
if got[0].ID != "41E862C00D9E" || got[0].Queue != "deferred" || got[0].Sender != "app@example.com" ||
|
|
!got[0].Arrival.Equal(time.Unix(1791000000, 0)) {
|
|
t.Errorf("first message = %+v", got[0])
|
|
}
|
|
if len(got[0].Recipients) != 1 || got[0].Recipients[0] != "a@example.net" {
|
|
t.Errorf("first message's recipients = %v", got[0].Recipients)
|
|
}
|
|
if got[1].ID != "5F00AA12" || got[1].Queue != "active" {
|
|
t.Errorf("second message = %+v", got[1])
|
|
}
|
|
if empty, err := parseQueueJSON(nil); err != nil || len(empty) != 0 {
|
|
t.Errorf("an empty queue: %v, %v", empty, err)
|
|
}
|
|
// A line the reader cannot hold ends the listing with an error: what
|
|
// follows it is unknown, and "nothing old is left" must not be concluded.
|
|
long := append([]byte(`{"queue_id": "A", "arrival_time": 1, "sender": "`), make([]byte, 2<<20)...)
|
|
if _, err := parseQueueJSON(long); err == nil {
|
|
t.Error("a line longer than the reader's limit was not an error")
|
|
}
|
|
}
|
|
|
|
// A queue that cannot be listed is an error, not an empty queue: the caller
|
|
// must not conclude that nothing is waiting.
|
|
func TestQueueMessagesReportsAFailedListing(t *testing.T) {
|
|
old := readQueueJSON
|
|
t.Cleanup(func() { readQueueJSON = old })
|
|
readQueueJSON = func() ([]byte, error) { return nil, errors.New("postqueue: Permission denied") }
|
|
|
|
if msgs, err := QueueMessages(); err == nil {
|
|
t.Fatalf("no error for a failed listing (got %v)", msgs)
|
|
}
|
|
}
|