test / test (push) Canceled after 0s
Technical review (Opus) and security review (Fable) of a59e3d4..cb5a4a2;
reports in the session's scratchpad. Nothing critical, high or medium; no
outright bug. Fixed:
- F2, F3 (0008 backfill, before it runs on the live database): rows are
filled by the rule new rows follow - the application's domain, then the
name's - and only by a domain and application that existed when the row
was written (created_at); the inbound log likewise. Test: the migration's
UPDATEs re-run on prepared rows (before the domain, after, null sender,
application gone, a stranger's name). Dry run on a copy of the live
database: 68/68 and 10/10 rows filled, none disagreeing with its login's
domain, integrity ok.
- V2, F4: an application's statistics and level-2 count are its login's
rows of its domain (appByLogin), and StatsWindow starts no earlier than
the entity's creation; the message page's "may send as" only for a login
still of the row's domain. Test: a login taken again in another domain
starts at zero.
- F7: MAIL FROM:<> is held to the domain limit of its login
(ApplicationByLogin fills DomainName).
- V3: an imported DKIM selector is held to DNS labels (validate.Selector).
- F5, F6: an imported auto limit's numbers are dropped and recalculated
right after the import; its mode is stored trimmed.
- V6: the store refuses a role that is neither global nor domain.
- F9: SaveUser keeps the stored hash when no new password is given (the
form no longer writes back the hash it read). F10: a reach naming a
domain deleted meanwhile is ErrNoSuchDomain, answered on the form.
- V4, F12: from-lines-other.txt - lines naming another sender ({other}) in
a quoted string, a quoted pair, capitals, a comment, an encoded word, a
quoted local part; the unit test wants each refused, the e2e
(lines_naming_another_sender_never_signed_for_it) wants each refused and
none signed for it. The passed list gained a.{DOMAIN}, a comment after
the angle address, a quoted local part, and "b@ {other}" - passed by
design (security.md), and the e2e shows it signed for the own domain.
- F13: e2e login_in_other_capitals_does_not_authenticate - AUTH with the
login upper-cased gets 535.
Not changed, written down: V1/F1 - L8 is half closed (refused or passed
still tells an application which domains are hosted here); security.md's
accepted risks and the CHANGELOG say so, and the owner is asked whether to
refuse every foreign address in a display name (changes the 2.4.0 rule).
F11 - deleting a domain rewrites its rows' domain_id (seconds at 1e5 rows),
accepted at this size. F8 (test cannot tell write-first from read-first;
the reviewer verified it with two stores, 30/30), V5, V7, P2: noted.
Evidence on the test server for this tree: go vet clean, go test ./... 23
packages ok, make e2e exit 0 with the three new cases.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
187 lines
6.1 KiB
Go
187 lines
6.1 KiB
Go
// Package validate holds shared server-side form validation for the panel.
|
|
package validate
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"unicode"
|
|
)
|
|
|
|
// MinAdminPasswordLen is the floor for the administrator password. The panel is
|
|
// public (security.md), so this is deliberately not tiny.
|
|
const MinAdminPasswordLen = 12
|
|
|
|
const (
|
|
minUsernameLen = 3
|
|
maxUsernameLen = 64
|
|
)
|
|
|
|
// MinSecretFilePasswordLen is the floor for the password protecting an
|
|
// encrypted backup or domain export. Such a file is offline and can be attacked
|
|
// at leisure, so the floor matches the administrator password's rather than the
|
|
// weaker "any password is better than none".
|
|
const MinSecretFilePasswordLen = MinAdminPasswordLen
|
|
|
|
// Username enforces a strict server-side whitelist (security.md): letters,
|
|
// digits, dot, dash, underscore. Client validation is never trusted.
|
|
func Username(u string) error {
|
|
if len(u) < minUsernameLen || len(u) > maxUsernameLen {
|
|
return fmt.Errorf("username must be %d-%d characters", minUsernameLen, maxUsernameLen)
|
|
}
|
|
for _, r := range u {
|
|
if r > unicode.MaxASCII || (!isASCIILetterOrDigit(r) && r != '.' && r != '-' && r != '_') {
|
|
return fmt.Errorf("username may contain only letters, digits, '.', '-' and '_'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// AdminPassword enforces a minimum length. Composition rules beyond length tend
|
|
// to reduce entropy in practice, so length is the sole gate.
|
|
func AdminPassword(p string) error {
|
|
if len(p) < MinAdminPasswordLen {
|
|
return fmt.Errorf("password must be at least %d characters", MinAdminPasswordLen)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func isASCIILetterOrDigit(r rune) bool {
|
|
return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z') || (r >= '0' && r <= '9')
|
|
}
|
|
|
|
const maxDomainLen = 253 // RFC 1035 limit on a fully-qualified name
|
|
|
|
// NormalizeDomain lower-cases and trims a domain name. Domain names are
|
|
// case-insensitive, and the generated OpenDKIM tables/keys use the canonical
|
|
// lower-case form, so we normalise before both validation and storage.
|
|
func NormalizeDomain(name string) string {
|
|
return strings.ToLower(strings.TrimSpace(name))
|
|
}
|
|
|
|
// Domain enforces a strict server-side whitelist for sending-domain names
|
|
// (security.md). The result is safe to write verbatim into the OpenDKIM
|
|
// KeyTable/SigningTable and to use as a filesystem path segment: only
|
|
// lower-case letters, digits, '.' and '-' are allowed, in valid DNS label
|
|
// shape. Input must already be normalised with NormalizeDomain.
|
|
func Domain(name string) error {
|
|
if name == "" {
|
|
return fmt.Errorf("domain is required")
|
|
}
|
|
if len(name) > maxDomainLen {
|
|
return fmt.Errorf("domain must be at most %d characters", maxDomainLen)
|
|
}
|
|
labels := strings.Split(name, ".")
|
|
if len(labels) < 2 {
|
|
return fmt.Errorf("domain must include at least one dot (e.g. example.com)")
|
|
}
|
|
for _, label := range labels {
|
|
if err := domainLabel(label); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Selector checks a DKIM selector: one or more DNS labels as Domain allows
|
|
// them, at most 63 characters in all. The panel's own selector is fixed in
|
|
// its configuration; this is for one read from a domain export file, which
|
|
// goes into OpenDKIM's tables, a key file's name and every signature's s=
|
|
// (review of audit stage 2).
|
|
func Selector(s string) error {
|
|
if s == "" {
|
|
return fmt.Errorf("selector is required")
|
|
}
|
|
if len(s) > 63 {
|
|
return fmt.Errorf("selector must be at most 63 characters")
|
|
}
|
|
for _, label := range strings.Split(s, ".") {
|
|
if err := domainLabel(label); err != nil {
|
|
return fmt.Errorf("selector: %w", err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func domainLabel(label string) error {
|
|
if len(label) == 0 {
|
|
return fmt.Errorf("domain must not contain an empty label")
|
|
}
|
|
if len(label) > 63 {
|
|
return fmt.Errorf("each domain label must be at most 63 characters")
|
|
}
|
|
if label[0] == '-' || label[len(label)-1] == '-' {
|
|
return fmt.Errorf("domain labels must not start or end with '-'")
|
|
}
|
|
for i := 0; i < len(label); i++ {
|
|
c := label[i]
|
|
lower := c >= 'a' && c <= 'z'
|
|
digit := c >= '0' && c <= '9'
|
|
if !lower && !digit && c != '-' {
|
|
return fmt.Errorf("domain may contain only lower-case letters, digits, '.' and '-'")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// freemailDomains lists public mail hosts that cannot publish _report._dmarc
|
|
// authorisation for third-party sending domains.
|
|
var freemailDomains = map[string]struct{}{
|
|
"gmail.com": {},
|
|
"googlemail.com": {},
|
|
"outlook.com": {},
|
|
"hotmail.com": {},
|
|
"live.com": {},
|
|
"yahoo.com": {},
|
|
"icloud.com": {},
|
|
"me.com": {},
|
|
"proton.me": {},
|
|
"protonmail.com": {},
|
|
}
|
|
|
|
// AccountEmail checks a panel user's own address: where the panel writes to
|
|
// them. Empty is allowed. It is the address check of Email without that
|
|
// function's refusal of public mail hosts - a mailbox at one of those is a
|
|
// perfectly good place to be notified, and for many administrators the only
|
|
// one that does not depend on the server the notification is about.
|
|
func AccountEmail(addr string) error {
|
|
return emailAddress(addr, true)
|
|
}
|
|
|
|
// Email checks a DMARC rua= mailbox. Empty is allowed (policy-only).
|
|
func Email(addr string) error {
|
|
return emailAddress(addr, false)
|
|
}
|
|
|
|
func emailAddress(addr string, publicHosts bool) error {
|
|
addr = strings.TrimSpace(addr)
|
|
if addr == "" {
|
|
return nil
|
|
}
|
|
at := strings.LastIndex(addr, "@")
|
|
if at <= 0 || at >= len(addr)-1 {
|
|
return fmt.Errorf("enter a valid email address")
|
|
}
|
|
local := addr[:at]
|
|
// An address is handed to sendmail(1) as an argument; one that begins like
|
|
// an option is refused here, where the user can be told.
|
|
if strings.HasPrefix(local, "-") {
|
|
return fmt.Errorf("email address must not begin with '-'")
|
|
}
|
|
domain := NormalizeDomain(addr[at+1:])
|
|
if err := Domain(domain); err != nil {
|
|
return fmt.Errorf("email domain is invalid: %w", err)
|
|
}
|
|
for _, r := range local {
|
|
if r > unicode.MaxASCII {
|
|
return fmt.Errorf("email address must be ASCII")
|
|
}
|
|
if !isASCIILetterOrDigit(r) && r != '.' && r != '-' && r != '_' && r != '+' {
|
|
return fmt.Errorf("email address contains invalid characters")
|
|
}
|
|
}
|
|
if _, blocked := freemailDomains[domain]; blocked && !publicHosts {
|
|
return fmt.Errorf("use an address on a domain you control; public mail hosts cannot receive authorised DMARC reports")
|
|
}
|
|
return nil
|
|
}
|